mirror of
https://codeberg.org/forgejo/forgejo
synced 2024-11-29 21:26:10 +01:00
8fb027fea5
- Backport of #2518
- The content history table contains the content history of issues and
comments. For issues they are saved with an comment id of zero.
- If you want to check if the issue has an content history, it should
take into account that SQL has `comment_id = 0`, as it otherwise could
return incorrect results when for example the issue already has an
comment that has an content history.
- Fix the code of `HasIssueContentHistory` to take this into account, it
relied on XORM to generate the SQL from the non-default values of the
struct, this wouldn't generate the `comment_id = 0` SQL as `0` is the
default value of an integer.
- Remove an unncessary log (it's not the responsibility of `models`
code to do logging).
- Adds unit test.
- Resolves #2513
(cherry picked from commit 331fa44956)
94 lines
3.6 KiB
Go
94 lines
3.6 KiB
Go
// Copyright 2021 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package issues_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"code.gitea.io/gitea/models/db"
|
|
issues_model "code.gitea.io/gitea/models/issues"
|
|
"code.gitea.io/gitea/models/unittest"
|
|
"code.gitea.io/gitea/modules/timeutil"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestContentHistory(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
dbCtx := db.DefaultContext
|
|
timeStampNow := timeutil.TimeStampNow()
|
|
|
|
_ = issues_model.SaveIssueContentHistory(dbCtx, 1, 10, 0, timeStampNow, "i-a", true)
|
|
_ = issues_model.SaveIssueContentHistory(dbCtx, 1, 10, 0, timeStampNow.Add(2), "i-b", false)
|
|
_ = issues_model.SaveIssueContentHistory(dbCtx, 1, 10, 0, timeStampNow.Add(7), "i-c", false)
|
|
|
|
_ = issues_model.SaveIssueContentHistory(dbCtx, 1, 10, 100, timeStampNow, "c-a", true)
|
|
_ = issues_model.SaveIssueContentHistory(dbCtx, 1, 10, 100, timeStampNow.Add(5), "c-b", false)
|
|
_ = issues_model.SaveIssueContentHistory(dbCtx, 1, 10, 100, timeStampNow.Add(20), "c-c", false)
|
|
_ = issues_model.SaveIssueContentHistory(dbCtx, 1, 10, 100, timeStampNow.Add(50), "c-d", false)
|
|
_ = issues_model.SaveIssueContentHistory(dbCtx, 1, 10, 100, timeStampNow.Add(51), "c-e", false)
|
|
|
|
h1, _ := issues_model.GetIssueContentHistoryByID(dbCtx, 1)
|
|
assert.EqualValues(t, 1, h1.ID)
|
|
|
|
m, _ := issues_model.QueryIssueContentHistoryEditedCountMap(dbCtx, 10)
|
|
assert.Equal(t, 3, m[0])
|
|
assert.Equal(t, 5, m[100])
|
|
|
|
/*
|
|
we can not have this test with real `User` now, because we can not depend on `User` model (circle-import), so there is no `user` table
|
|
when the refactor of models are done, this test will be possible to be run then with a real `User` model.
|
|
*/
|
|
type User struct {
|
|
ID int64
|
|
Name string
|
|
FullName string
|
|
}
|
|
_ = db.GetEngine(dbCtx).Sync(&User{})
|
|
|
|
list1, _ := issues_model.FetchIssueContentHistoryList(dbCtx, 10, 0)
|
|
assert.Len(t, list1, 3)
|
|
list2, _ := issues_model.FetchIssueContentHistoryList(dbCtx, 10, 100)
|
|
assert.Len(t, list2, 5)
|
|
|
|
hasHistory1, _ := issues_model.HasIssueContentHistory(dbCtx, 10, 0)
|
|
assert.True(t, hasHistory1)
|
|
hasHistory2, _ := issues_model.HasIssueContentHistory(dbCtx, 10, 1)
|
|
assert.False(t, hasHistory2)
|
|
|
|
h6, h6Prev, _ := issues_model.GetIssueContentHistoryAndPrev(dbCtx, 10, 6)
|
|
assert.EqualValues(t, 6, h6.ID)
|
|
assert.EqualValues(t, 5, h6Prev.ID)
|
|
|
|
// soft-delete
|
|
_ = issues_model.SoftDeleteIssueContentHistory(dbCtx, 5)
|
|
h6, h6Prev, _ = issues_model.GetIssueContentHistoryAndPrev(dbCtx, 10, 6)
|
|
assert.EqualValues(t, 6, h6.ID)
|
|
assert.EqualValues(t, 4, h6Prev.ID)
|
|
|
|
// only keep 3 history revisions for comment_id=100, the first and the last should never be deleted
|
|
issues_model.KeepLimitedContentHistory(dbCtx, 10, 100, 3)
|
|
list1, _ = issues_model.FetchIssueContentHistoryList(dbCtx, 10, 0)
|
|
assert.Len(t, list1, 3)
|
|
list2, _ = issues_model.FetchIssueContentHistoryList(dbCtx, 10, 100)
|
|
assert.Len(t, list2, 3)
|
|
assert.EqualValues(t, 8, list2[0].HistoryID)
|
|
assert.EqualValues(t, 7, list2[1].HistoryID)
|
|
assert.EqualValues(t, 4, list2[2].HistoryID)
|
|
}
|
|
|
|
func TestHasIssueContentHistory(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
// Ensures that comment_id is into taken account even if it's zero.
|
|
_ = issues_model.SaveIssueContentHistory(db.DefaultContext, 1, 11, 100, timeutil.TimeStampNow(), "c-a", true)
|
|
_ = issues_model.SaveIssueContentHistory(db.DefaultContext, 1, 11, 100, timeutil.TimeStampNow().Add(5), "c-b", false)
|
|
|
|
hasHistory1, _ := issues_model.HasIssueContentHistory(db.DefaultContext, 11, 0)
|
|
assert.False(t, hasHistory1)
|
|
hasHistory2, _ := issues_model.HasIssueContentHistory(db.DefaultContext, 11, 100)
|
|
assert.True(t, hasHistory2)
|
|
}
|