Shiny Nematoda
928f188689
fix(code search): various ui/ux improvements raised by user research ( #4332 )
...
various improvements from [user research](https://codeberg.org/forgejo/user-research/src/branch/main/interviews/2024-06/issues%28search%2Cfeatures%29%2Cselfhosting%2CCI%2Caccessibility%2Ccodesearch.md )
- filenames are links to the respective files
fixes: `fold menu: user clicked and expected to view file, instead the file collapsed`
- refactor(searchfile.tmpl): ordered lists with lines grouped together instead of table
fixes: `multiple matches per file are "merged", only visible in the code lines (no visual separation)`
- feat: display fuzzy as "Either" when using git-grep which is much more accurate than "fuzzy"
git-grep does not support fuzzy searching, in this context selecting fuzzy searching worked similar to an OR of white space separated keywords
fixes: `typo doesn't bring results in fuzzy search`
---
<details>
<summary>Before</summary>
</details>
<details>
<summary>After</summary>
</details>
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4332
Reviewed-by: 0ko <0ko@noreply.codeberg.org>
Co-authored-by: Shiny Nematoda <snematoda.751k2@aleeas.com>
Co-committed-by: Shiny Nematoda <snematoda.751k2@aleeas.com>
2024-07-10 05:25:32 +00:00
Earl Warren
2d85d51879
docs(release-notes): for pull requests #4400 , #4375 [skip ci] ( #4442 )
...
Refs: https://codeberg.org/forgejo/forgejo/pulls/4400
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4442
Reviewed-by: 0ko <0ko@noreply.codeberg.org>
Co-authored-by: Earl Warren <contact@earl-warren.org>
Co-committed-by: Earl Warren <contact@earl-warren.org>
2024-07-10 05:14:16 +00:00
Earl Warren
8acaa427d6
Merge pull request 'Port of Refactor login page' ( #4400 ) from 0ko/forgejo:ui-login-redesign into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4400
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-07-10 04:15:56 +00:00
Earl Warren
cd70d36bbb
Merge pull request 'Update module golang.org/x/tools to v0.23.0 (forgejo)' ( #4441 ) from renovate/forgejo-xtools into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4441
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-07-10 04:13:47 +00:00
Renovate Bot
6154befef6
Update module golang.org/x/tools to v0.23.0
2024-07-10 00:01:50 +00:00
Earl Warren
1efec2adab
Merge pull request 'Update module github.com/buildkite/terminal-to-html/v3 to v3.14.0 (forgejo)' ( #4429 ) from renovate/forgejo-github.com-buildkite-terminal-to-html-v3-3.x into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4429
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
2024-07-09 21:58:01 +00:00
Earl Warren
51c5b993ab
Merge pull request 'chore(renovate): group x/tools/* upgrade' ( #4436 ) from earl-warren/forgejo:wip-renovate-x/tools into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4436
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
2024-07-09 06:57:02 +00:00
Earl Warren
e2d09101d4
docs(release-notes): display URLs in .sh-session files
2024-07-09 08:24:46 +02:00
Earl Warren
4f6c823ae7
Merge pull request '[gitea] week 2024-28 cherry pick (gitea/main -> forgejo)' ( #4391 ) from earl-warren/wcp/2024-28 into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4391
Reviewed-by: twenty-panda <twenty-panda@noreply.codeberg.org>
2024-07-09 05:37:52 +00:00
Earl Warren
f915532703
chore(renovate): group x/tools/* upgrade
...
Refs: https://codeberg.org/forgejo/forgejo/pulls?q=x%2Ftools&type=all
2024-07-09 07:23:22 +02:00
Earl Warren
6c9e0a6641
Merge pull request 'test: add valkey to remote cache test' ( #4434 ) from jthvai/forgejo:test-valkey into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4434
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-07-09 05:21:15 +00:00
Earl Warren
cf5fb9a2e7
Merge pull request 'Update module golang.org/x/net to v0.27.0 (forgejo)' ( #4430 ) from renovate/forgejo-golang.org-x-net-0.x into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4430
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-07-09 05:02:44 +00:00
Earl Warren
6c2106b5be
Merge pull request 'Update module golang.org/x/tools/cmd/deadcode to v0.23.0 (forgejo)' ( #4433 ) from renovate/forgejo-golang.org-x-tools-cmd-deadcode-0.x into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4433
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-07-09 04:54:08 +00:00
Elias Elwyn
f3f6bc5b33
test: add valkey to remote cache test
2024-07-09 14:26:46 +10:00
Renovate Bot
a86380419e
Update module golang.org/x/tools/cmd/deadcode to v0.23.0
2024-07-09 00:03:39 +00:00
Renovate Bot
a8f35f6edd
Update module github.com/buildkite/terminal-to-html/v3 to v3.14.0
2024-07-09 00:03:10 +00:00
Earl Warren
764b9abc6b
Merge pull request 'tests: run JavaScript tests when web_src/js is modified' ( #4419 ) from earl-warren/forgejo:wip-e2e into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4419
Reviewed-by: twenty-panda <twenty-panda@noreply.codeberg.org>
2024-07-08 18:50:02 +00:00
banaanihillo
099682892b
accessibility: anchor elements' missing href added ( #4375 )
...
Add an empty hash `href="#"` attribute to anchors that did not yet have any `href` attribute, as a quick work-around to make those elements possible to interact with via keyboard. See discussion on linked issue (https://codeberg.org/forgejo/forgejo/issues/4273 ) for more information on how the button-like elements like this could eventually be improved even more.
Fixes https://codeberg.org/forgejo/forgejo/issues/4273 .
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4375
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: banaanihillo <banaanihillo@noreply.codeberg.org>
Co-committed-by: banaanihillo <banaanihillo@noreply.codeberg.org>
2024-07-08 17:32:59 +00:00
Earl Warren
a6a64f1fdc
tests: run JavaScript tests when web_src/js is modified
...
otherwise they are not useful
2024-07-08 19:26:14 +02:00
Earl Warren
dd39b6d1bc
Merge pull request 'Update renovate to v37.425.2 (forgejo)' ( #4418 ) from renovate/forgejo-renovate into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4418
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
2024-07-08 13:42:29 +00:00
Renovate Bot
faaf03a44a
Update renovate to v37.425.2
2024-07-08 13:01:21 +00:00
Earl Warren
01bda22721
Merge pull request 'Fix branch selector in commit graph' ( #4401 ) from beowulf/fix-commit-graph-branch-selector into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4401
Reviewed-by: 0ko <0ko@noreply.codeberg.org>
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-07-08 11:21:54 +00:00
Earl Warren
964310b7ba
Merge pull request 'chore(renovate): remove schedules for stable branches' ( #4409 ) from viceice/renovate-schedules into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4409
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-07-08 08:17:11 +00:00
Michael Kriese
f4a9fb73b4
chore(renovate): remove schedules for stable branches
2024-07-08 09:03:37 +02:00
Earl Warren
567fccb02e
Merge pull request 'Update module golang.org/x/crypto to v0.25.0 (forgejo)' ( #4408 ) from renovate/forgejo-golang.org-x-crypto-0.x into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4408
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-07-08 05:42:30 +00:00
Renovate Bot
1630a94cfa
Update module golang.org/x/net to v0.27.0
2024-07-08 00:05:03 +00:00
Renovate Bot
e4e2e91467
Update module golang.org/x/crypto to v0.25.0
2024-07-08 00:04:57 +00:00
Earl Warren
8d64891b8b
Merge pull request '[BUG] Fix mobile UI for organisation creation' ( #4382 ) from gusted/mobile-org into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4382
Reviewed-by: Beowulf <beowulf@noreply.codeberg.org>
2024-07-07 19:28:30 +00:00
Beowulf
11ff38dd40
fix branch selector in commit graph
...
Regression from 5ef80ceb64
2024-07-07 20:26:30 +02:00
0ko
7d5972d330
i18n: separate string for OpenID
2024-07-07 22:23:11 +05:00
0ko
2a03e2c6b9
i18n: cleanup
2024-07-07 22:18:39 +05:00
0ko
458bbe3f1a
ui: remove non-working passkey link
2024-07-07 22:11:50 +05:00
Earl Warren
502adec4ce
Merge pull request '[CHORE] Remove github.com/yuin/goldmark-meta' ( #4383 ) from gusted/chore-goldmark-meta into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4383
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-07-07 13:47:30 +00:00
0ko
dcd1039215
i18n: fix strings related to sign in
...
Improve localizability, clean up.
2024-07-07 14:40:50 +05:00
0ko
577dc2d7d6
i18n: fix sign up strings
...
To avoid conflicting with existing strings in translations. Also improve localizability.
2024-07-07 14:37:45 +05:00
Anbraten
629ca22a97
Refactor login page ( #31530 )
...
As requested in
https://github.com/go-gitea/gitea/pull/31504#issuecomment-2196196646 .
This PR refactor the login page:
- [x] use separate box for passkey login and go to registration
- [x] move forgot passoword next to password label
- [x] fix password required label `*` and padding
- [x] remove tabs from login page
---------
Co-authored-by: silverwind <me@silverwind.io>
(cherry picked from commit 9c00dda33ad7bd594dd8f331fa1bf0acefc2ca54)
Conflict resolution:
* signin_navbar.tmpl has been deleted
* additions in form.css
* major code changes in signin_openid
* ...
2024-07-07 14:22:44 +05:00
Brecht Van Lommel
33f9fb8150
Fix slow patch checking with commits that add or remove many files ( #31548 )
...
Running git update-index for every individual file is slow, so add and
remove everything with a single git command.
When such a big commit lands in the default branch, it could cause PR
creation and patch checking for all open PRs to be slow, or time out
entirely. For example, a commit that removes 1383 files was measured to
take more than 60 seconds and timed out. With this change checking took
about a second.
This is related to #27967 , though this will not help with commits that
change many lines in few files.
(cherry picked from commit b88e5fc72d99e9d4a0aa9c13f70e0a9e967fe057)
2024-07-07 07:33:01 +02:00
charles
f92591b825
Fix markdown preview $$ support ( #31514 )
...
close #31481
currently `$$A + B$$ test` will ignore text after $$ block
test text
before fix
after fix
github display
(cherry picked from commit f0033051d5ce07f5a18d2aacef6bfdca5fc69014)
2024-07-07 07:29:49 +02:00
silverwind
e1b90212e4
Use stable version of fabric ( #31526 )
...
Fabric 6 is [now
stable](https://github.com/fabricjs/fabric.js/releases/tag/v6.0.0-rc5 ),
use it.
(cherry picked from commit 5821d22891cb3aa1e1c9590d8b921728b4969c5f)
2024-07-07 07:27:53 +02:00
0ko
c19222b22f
ui: improve button gap consistency in repos ( #4365 )
...
Improve UI in a few areas in a similar way to dc0d3a40abhttps://codeberg.org/attachments/cfca200a-3b68-4ba8-9876-75cea7822a00
https://codeberg.org/attachments/aaa5d387-919b-45af-8854-6d0f5273125f
https://codeberg.org/attachments/989225b7-b1dd-491d-bf76-7e4a962ea54e
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4365
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
2024-07-07 03:21:58 +00:00
Gusted
cf8f26d616
[CHORE] Remove github.com/yuin/goldmark-meta
...
- Remove a unused dependency. This dependency was added to handle YAML
'frontmatter' meta, parsing them and converting them to a table or
details in the resulting HTML. As can be read in the issue that reported
the behavior of YAML frontmatter being rendered literally,
https://github.com/go-gitea/gitea/issues/5377 .
- It's an unused dependency as the codebase since then moved on to do this YAML
parsing and rendering on their own, this was implemented in
812cfd0ad9
2024-07-07 03:18:13 +02:00
Gusted
610487eb83
[BUG] Fix mobile UI for organisation creation
...
- Don't make checkpoints or radio inputs full width on a small screen,
these obviously shouldn't try to take up the whole width of a container.
- Wrap the label for organisation permission box inside a `<span
class="inline field">`, so it gets a left-margin from the `.inline.field
> :first-child` selector. This make the checkboxes and radio buttons
groups look indented from the left.
- Resolves #4361
2024-07-07 01:37:38 +02:00
Earl Warren
3ff661fe9e
Merge pull request '[BUG] Use correct SHA in GetCommitPullRequest' ( #4377 ) from gusted/commit-to-pull into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4377
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-07-06 20:59:18 +00:00
Earl Warren
bf0c9837cc
Merge pull request '[ENHANCEMENT] Improve caching of contributor stats' ( #4367 ) from gusted/contributors-stats-cache into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4367
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-07-06 20:12:35 +00:00
Gusted
a8460bb132
[BUG] Use correct SHA in GetCommitPullRequest
...
- The param wasn't `sha`, it was `ref`. Use this instead.
- Adds new integration tests.
- Resolves #4190
- Resolves #4025
2024-07-06 22:04:31 +02:00
Gusted
70a7d6a0de
[ENHANCEMENT] Improve caching of contributor stats
...
- It was noticed [in the Forgejo matrix channel](https://matrix.to/#/!qjPHwFPdxhpLkXMkyP:matrix.org/$vk78UR0eFCwQMDMTZ7-DWjMVB_LIAwHW6SkjhEcGkQQ?via=matrix.org ) that the generation of the Forgejo project contributor stats was taking quite a while on codeberg.org. This was continued with the fact that a few moments later it was once again generating them again; it seemed like they weren't being cached while they were.
- The problem was that the cache TTL is hardcoded to ten minutes and not to the configured TTL. This patch changes that by using the configured TLL for the contributor cache, as this is a computationally heavy operation and should be cached for as long as possible for a good user experience. This doesn't impact the accuracy of this feature because the commit ID of the default branch is used as a cache key.
- Also changed in this patch, is that errors aren't cached and are instead being logged, this is more helpful to the administrator. For the user essentially nothing changed on this side, the contributor stats just looks like it's loading indefinitely.
- Realistically, testing this isn't possible, as the cache library Forgejo currently uses doesn't expose the TTL or expiration time of a key. Manually testing this behavior is quite lengthy, as one of the steps would need to be "wait for ten minutes" and describe how you can notice the data was cached or was just generated, and because you could use different types of cache, it will be quite hard to write down how you could check the TTL of a key for a particular cache (I'm not even sure it's even possible for some).
2024-07-06 21:23:46 +02:00
Mai-Lapyst
98c8d45f0b
Fixes an visual bug where the info box to dispatch a workflow is shown even for users that lack permissions to actualy run the workflow. ( #4305 )
...
Example: Visit https://v8.next.forgejo.org/Mai-Lapyst/test/actions?workflow=dispatch.yaml&actor=0&status=0 without being logged in.
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4305
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: Mai-Lapyst <mai-lapyst@noreply.codeberg.org>
Co-committed-by: Mai-Lapyst <mai-lapyst@noreply.codeberg.org>
2024-07-06 05:30:58 +00:00
Earl Warren
c49afdf0ff
Merge pull request 'Lock file maintenance (forgejo)' ( #4344 ) from renovate/forgejo-lock-file-maintenance into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4344
Reviewed-by: Caesar Schinas <caesar@caesarschinas.com>
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
2024-07-05 12:18:20 +00:00
Renovate Bot
e487dfbbc6
Lock file maintenance
2024-07-05 10:42:17 +00:00
Earl Warren
c953aafb05
Merge pull request 'chore(renovate): fix base branches regex' ( #4338 ) from viceice/renovat-base-branches-fix into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4338
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-07-05 10:17:40 +00:00
