mirror of
https://codeberg.org/forgejo/forgejo
synced 2024-11-27 20:26:09 +01:00
d92c2048b3
This PR will avoid load pullrequest.Issue twice in pull request list page. It will reduce x times database queries for those WIP pull requests. Partially fix #29585 --------- Co-authored-by: Giteabot <teabot@gitea.io> (cherry picked from commit 62f8174aa2fae1481c7e17a6afcb731a5b178cd0) Conflicts: models/activities/notification_list.go moved to models/activities/notification.go
99 lines
3.4 KiB
Go
99 lines
3.4 KiB
Go
// Copyright 2020 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package convert
|
|
|
|
import (
|
|
"context"
|
|
"net/url"
|
|
|
|
activities_model "code.gitea.io/gitea/models/activities"
|
|
"code.gitea.io/gitea/models/perm"
|
|
access_model "code.gitea.io/gitea/models/perm/access"
|
|
api "code.gitea.io/gitea/modules/structs"
|
|
)
|
|
|
|
// ToNotificationThread convert a Notification to api.NotificationThread
|
|
func ToNotificationThread(ctx context.Context, n *activities_model.Notification) *api.NotificationThread {
|
|
result := &api.NotificationThread{
|
|
ID: n.ID,
|
|
Unread: !(n.Status == activities_model.NotificationStatusRead || n.Status == activities_model.NotificationStatusPinned),
|
|
Pinned: n.Status == activities_model.NotificationStatusPinned,
|
|
UpdatedAt: n.UpdatedUnix.AsTime(),
|
|
URL: n.APIURL(),
|
|
}
|
|
|
|
// since user only get notifications when he has access to use minimal access mode
|
|
if n.Repository != nil {
|
|
result.Repository = ToRepo(ctx, n.Repository, access_model.Permission{AccessMode: perm.AccessModeRead})
|
|
|
|
// This permission is not correct and we should not be reporting it
|
|
for repository := result.Repository; repository != nil; repository = repository.Parent {
|
|
repository.Permissions = nil
|
|
}
|
|
}
|
|
|
|
// handle Subject
|
|
switch n.Source {
|
|
case activities_model.NotificationSourceIssue:
|
|
result.Subject = &api.NotificationSubject{Type: api.NotifySubjectIssue}
|
|
if n.Issue != nil {
|
|
result.Subject.Title = n.Issue.Title
|
|
result.Subject.URL = n.Issue.APIURL(ctx)
|
|
result.Subject.HTMLURL = n.Issue.HTMLURL()
|
|
result.Subject.State = n.Issue.State()
|
|
comment, err := n.Issue.GetLastComment(ctx)
|
|
if err == nil && comment != nil {
|
|
result.Subject.LatestCommentURL = comment.APIURL(ctx)
|
|
result.Subject.LatestCommentHTMLURL = comment.HTMLURL(ctx)
|
|
}
|
|
}
|
|
case activities_model.NotificationSourcePullRequest:
|
|
result.Subject = &api.NotificationSubject{Type: api.NotifySubjectPull}
|
|
if n.Issue != nil {
|
|
result.Subject.Title = n.Issue.Title
|
|
result.Subject.URL = n.Issue.APIURL(ctx)
|
|
result.Subject.HTMLURL = n.Issue.HTMLURL()
|
|
result.Subject.State = n.Issue.State()
|
|
comment, err := n.Issue.GetLastComment(ctx)
|
|
if err == nil && comment != nil {
|
|
result.Subject.LatestCommentURL = comment.APIURL(ctx)
|
|
result.Subject.LatestCommentHTMLURL = comment.HTMLURL(ctx)
|
|
}
|
|
|
|
if err := n.Issue.LoadPullRequest(ctx); err == nil &&
|
|
n.Issue.PullRequest != nil &&
|
|
n.Issue.PullRequest.HasMerged {
|
|
result.Subject.State = "merged"
|
|
}
|
|
}
|
|
case activities_model.NotificationSourceCommit:
|
|
url := n.Repository.HTMLURL() + "/commit/" + url.PathEscape(n.CommitID)
|
|
result.Subject = &api.NotificationSubject{
|
|
Type: api.NotifySubjectCommit,
|
|
Title: n.CommitID,
|
|
URL: url,
|
|
HTMLURL: url,
|
|
}
|
|
case activities_model.NotificationSourceRepository:
|
|
result.Subject = &api.NotificationSubject{
|
|
Type: api.NotifySubjectRepository,
|
|
Title: n.Repository.FullName(),
|
|
// FIXME: this is a relative URL, rather useless and inconsistent, but keeping for backwards compat
|
|
URL: n.Repository.Link(),
|
|
HTMLURL: n.Repository.HTMLURL(),
|
|
}
|
|
}
|
|
|
|
return result
|
|
}
|
|
|
|
// ToNotifications convert list of Notification to api.NotificationThread list
|
|
func ToNotifications(ctx context.Context, nl activities_model.NotificationList) []*api.NotificationThread {
|
|
result := make([]*api.NotificationThread, 0, len(nl))
|
|
for _, n := range nl {
|
|
result = append(result, ToNotificationThread(ctx, n))
|
|
}
|
|
return result
|
|
}
|