sillyguodong e8e871b44e Fix cannot reopen after pushing commits to a closed PR (#23189) (#23324) ... Backport: #23189 Close: #22784 1. On GH, we can reopen a PR which was closed before after pushing commits. After reopening PR, we can see the commits that were pushed after closing PR in the time line. So the case of [issue](https://github.com/go-gitea/gitea/issues/22784) is a bug which needs to be fixed. 2. After closing a PR and pushing commits, `headBranchSha` is not equal to `sha`(which is the last commit ID string of reference). If the judgement exists, the button of reopen will not display. So, skip the judgement if the status of PR is closed.  3. Even if PR is already close, we should still insert comment record into DB when we push commits. So we should still call function `CreatePushPullComment()`. 067b0c2664/services/pull/pull.go (L260-L282) So, I add a switch(`includeClosed`) to the `GetUnmergedPullRequestsByHeadInfo` func to control whether the status of PR must be open. In this case, by setting `includeClosed` to `true`, we can query the closed PR.  4. In the loop of comments, I use the`latestCloseCommentID` variable to record the last occurrence of the close comment. In the go template, if the status of PR is closed, the comments whose type is `CommentTypePullRequestPush(29)` after `latestCloseCommentID` won't be rendered.  e.g. 1). The initial status of the PR is opened.  2). Then I click the button of `Close`. PR is closed now.  3). I try to push a commit to this PR, even though its current status is closed.  But in comments list, this commit do not display.This is as expected ：）  4). Click the `Reopen` button, the commit which is pushed after closing PR display now.  --------- Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>		2023-03-07 18:47:23 +08:00
..
actions	Avoid panic caused by broken payload when creating commit status (#23216) (#23294)	2023-03-04 14:23:49 +00:00
activity.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
attachment.go	Add API management for issue/pull and comment attachments (#21783)	2022-12-09 14:35:56 +08:00
blame.go	Add context cache as a request level cache (#22294)	2023-02-15 21:37:34 +08:00
branch.go	Supports wildcard protected branch (#20825)	2023-01-16 16:00:22 +08:00
cherry_pick.go	Rename almost all Ctx functions (#22071)	2022-12-10 10:46:31 +08:00
commit.go	Add context cache as a request level cache (#22294)	2023-02-15 21:37:34 +08:00
compare.go	Use beforeCommit instead of baseCommit (#22949)	2023-02-20 11:56:07 +08:00
download.go	Use context parameter in models/git (#22367)	2023-01-09 11:50:54 +08:00
editor.go	Rename almost all Ctx functions (#22071)	2022-12-10 10:46:31 +08:00
editor_test.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
find.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
http.go	Return 404 instead of 403 if user can not access the repo (#23155) (#23158)	2023-02-26 20:20:44 +08:00
http_test.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
issue.go	Fix cannot reopen after pushing commits to a closed PR (#23189) (#23324)	2023-03-07 18:47:23 +08:00
issue_content_history.go	Move helpers to be prefixed with gt- (#22879)	2023-02-13 17:59:59 +00:00
issue_dependency.go	Fix improper HTMLURL usages in Go code (#22839)	2023-02-11 14:34:11 +08:00
issue_label.go	Add loading yaml label template files (#22976) (#23232)	2023-03-01 21:57:34 -05:00
issue_label_test.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
issue_lock.go	Fix improper HTMLURL usages in Go code (#22839)	2023-02-11 14:34:11 +08:00
issue_stopwatch.go	Fix improper HTMLURL usages in Go code (#22839)	2023-02-11 14:34:11 +08:00
issue_test.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
issue_timetrack.go	Fix improper HTMLURL usages in Go code (#22839)	2023-02-11 14:34:11 +08:00
issue_watch.go	Fix improper HTMLURL usages in Go code (#22839)	2023-02-11 14:34:11 +08:00
lfs.go	Refactor git command package to improve security and maintainability (#22678)	2023-02-04 10:30:43 +08:00
main_test.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
middlewares.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
migrate.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
milestone.go	Rename almost all Ctx functions (#22071)	2022-12-10 10:46:31 +08:00
packages.go	Use dynamic package type list (#22263)	2022-12-29 00:31:54 +01:00
patch.go	Redirect to the commit page after applying patch (#23056) (#23127)	2023-02-24 22:43:26 -05:00
projects.go	Preview images for Issue cards in Project Board view (#22112)	2023-02-11 16:12:41 +08:00
projects_test.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
pull.go	Fix cannot reopen after pushing commits to a closed PR (#23189) (#23324)	2023-03-07 18:47:23 +08:00
pull_review.go	Fix improper HTMLURL usages in Go code (#22839)	2023-02-11 14:34:11 +08:00
release.go	Fix improper HTMLURL usages in Go code (#22839)	2023-02-11 14:34:11 +08:00
release_test.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
render.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
repo.go	Fix improper HTMLURL usages in Go code (#22839)	2023-02-11 14:34:11 +08:00
runners.go	Implement actions (#21937)	2023-01-31 09:45:19 +08:00
search.go	Fix improper HTMLURL usages in Go code (#22839)	2023-02-11 14:34:11 +08:00
setting.go	Rename repo.GetOwner to repo.LoadOwner (#22967)	2023-02-18 20:11:03 +08:00
setting_protected_branch.go	Get rules by id when editing branch protection rule (#22932)	2023-02-20 19:30:41 +08:00
setting_secrets.go	Add user secrets (#22191)	2023-02-01 20:53:04 +08:00
settings_test.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
tag.go	Add main landmark to templates and adjust titles (#22670)	2023-02-01 22:56:10 +00:00
topic.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
treelist.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
view.go	Use correct README link to render the README (#23152) (#23264)	2023-03-04 00:38:11 -05:00
view_test.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00
webhook.go	Add context cache as a request level cache (#22294)	2023-02-15 21:37:34 +08:00
wiki.go	Use context parameter in models/git (#22367)	2023-01-09 11:50:54 +08:00
wiki_test.go	Implement FSFE REUSE for golang files (#21840)	2022-11-27 18:20:29 +00:00