Template
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo synced 2024-12-05 02:54:46 +01:00
forgejo/routers/private/tests/repos/repo1_hook_verification
CaiCandong 815d267c80
Fix verifyCommits error when push a new branch (#26664)
> ### Description
> If a new branch is pushed, and the repository has a rule that would
require signed commits for the new branch, the commit is rejected with a
500 error regardless of whether it's signed.
> 
> When pushing a new branch, the "old" commit is the empty ID
(0000000000000000000000000000000000000000). verifyCommits has no
provision for this and passes an invalid commit range to git rev-list.
Prior to 1.19 this wasn't an issue because only pre-existing individual
branches could be protected.
> 
> I was able to reproduce with
[try.gitea.io/CraigTest/test](https://try.gitea.io/CraigTest/test),
which is set up with a blanket rule to require commits on all branches.


Fix #25565
Very thanks to @Craig-Holmquist-NTI for reporting the bug and suggesting
an valid solution!

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2023-08-30 02:27:53 +00:00
..
info Fix verifyCommits error when push a new branch (#26664) 2023-08-30 02:27:53 +00:00
logs Fix verifyCommits error when push a new branch (#26664) 2023-08-30 02:27:53 +00:00
objects Fix verifyCommits error when push a new branch (#26664) 2023-08-30 02:27:53 +00:00
refs/heads Fix verifyCommits error when push a new branch (#26664) 2023-08-30 02:27:53 +00:00
config Fix verifyCommits error when push a new branch (#26664) 2023-08-30 02:27:53 +00:00
HEAD Fix verifyCommits error when push a new branch (#26664) 2023-08-30 02:27:53 +00:00