mirror of
https://codeberg.org/forgejo/forgejo
synced 2024-11-28 04:36:11 +01:00
7a687caca4
Before:
After:
There's a bug in the recent logic, `CalcCommitStatus` will always return
the first item of `statuses` or error status, because `state` is defined
with default value which should be `CommitStatusSuccess`
Then
``` golang
if status.State.NoBetterThan(state) {
```
this `if` will always return false unless `status.State =
CommitStatusError` which makes no sense.
So `lastStatus` will always be `nil` or error status.
Then we will always return the first item of `statuses` here or only
return error status, and this is why in the first picture the commit
status is `Success` but not `Failure`.
|
||
|---|---|---|
| .. | ||
| branch.go | ||
| branch_list.go | ||
| branch_test.go | ||
| commit_status.go | ||
| commit_status_test.go | ||
| lfs.go | ||
| lfs_lock.go | ||
| main_test.go | ||
| protected_banch_list_test.go | ||
| protected_branch.go | ||
| protected_branch_list.go | ||
| protected_branch_test.go | ||
| protected_tag.go | ||
| protected_tag_test.go | ||