mirror of
https://codeberg.org/forgejo/forgejo
synced 2024-11-29 21:26:10 +01:00
e953bce5d7
Fix adopt repository has empty object name in database (#31333)
Fix #31330
Fix #31311
A workaround to fix the old database is to update object_format_name to
`sha1` if it's empty or null.
(cherry picked from commit 1968c2222dcf47ebd1697afb4e79a81e74702d31)
With tests services/repository/adopt_test.go
(cherry picked from commit 8efef06fb1)
116 lines
3.5 KiB
Go
116 lines
3.5 KiB
Go
// Copyright 2021 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package repository
|
|
|
|
import (
|
|
"os"
|
|
"path"
|
|
"testing"
|
|
|
|
"code.gitea.io/gitea/models/db"
|
|
"code.gitea.io/gitea/models/unittest"
|
|
user_model "code.gitea.io/gitea/models/user"
|
|
"code.gitea.io/gitea/modules/git"
|
|
"code.gitea.io/gitea/modules/setting"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestCheckUnadoptedRepositories_Add(t *testing.T) {
|
|
start := 10
|
|
end := 20
|
|
unadopted := &unadoptedRepositories{
|
|
start: start,
|
|
end: end,
|
|
index: 0,
|
|
}
|
|
|
|
total := 30
|
|
for i := 0; i < total; i++ {
|
|
unadopted.add("something")
|
|
}
|
|
|
|
assert.Equal(t, total, unadopted.index)
|
|
assert.Len(t, unadopted.repositories, end-start)
|
|
}
|
|
|
|
func TestCheckUnadoptedRepositories(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
//
|
|
// Non existent user
|
|
//
|
|
unadopted := &unadoptedRepositories{start: 0, end: 100}
|
|
err := checkUnadoptedRepositories(db.DefaultContext, "notauser", []string{"repo"}, unadopted)
|
|
assert.NoError(t, err)
|
|
assert.Empty(t, unadopted.repositories)
|
|
//
|
|
// Unadopted repository is returned
|
|
// Existing (adopted) repository is not returned
|
|
//
|
|
userName := "user2"
|
|
repoName := "repo2"
|
|
unadoptedRepoName := "unadopted"
|
|
unadopted = &unadoptedRepositories{start: 0, end: 100}
|
|
err = checkUnadoptedRepositories(db.DefaultContext, userName, []string{repoName, unadoptedRepoName}, unadopted)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, []string{path.Join(userName, unadoptedRepoName)}, unadopted.repositories)
|
|
//
|
|
// Existing (adopted) repository is not returned
|
|
//
|
|
unadopted = &unadoptedRepositories{start: 0, end: 100}
|
|
err = checkUnadoptedRepositories(db.DefaultContext, userName, []string{repoName}, unadopted)
|
|
assert.NoError(t, err)
|
|
assert.Empty(t, unadopted.repositories)
|
|
assert.Equal(t, 0, unadopted.index)
|
|
}
|
|
|
|
func TestListUnadoptedRepositories_ListOptions(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
username := "user2"
|
|
unadoptedList := []string{path.Join(username, "unadopted1"), path.Join(username, "unadopted2")}
|
|
for _, unadopted := range unadoptedList {
|
|
_ = os.Mkdir(path.Join(setting.RepoRootPath, unadopted+".git"), 0o755)
|
|
}
|
|
|
|
opts := db.ListOptions{Page: 1, PageSize: 1}
|
|
repoNames, count, err := ListUnadoptedRepositories(db.DefaultContext, "", &opts)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, 2, count)
|
|
assert.Equal(t, unadoptedList[0], repoNames[0])
|
|
|
|
opts = db.ListOptions{Page: 2, PageSize: 1}
|
|
repoNames, count, err = ListUnadoptedRepositories(db.DefaultContext, "", &opts)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, 2, count)
|
|
assert.Equal(t, unadoptedList[1], repoNames[0])
|
|
}
|
|
|
|
func TestAdoptRepository(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
username := "user2"
|
|
|
|
unadopted := "unadopted"
|
|
assert.NoError(t, unittest.CopyDir(
|
|
"../../modules/git/tests/repos/repo1_bare",
|
|
path.Join(setting.RepoRootPath, username, unadopted+".git"),
|
|
))
|
|
|
|
opts := db.ListOptions{Page: 1, PageSize: 1}
|
|
repoNames, _, err := ListUnadoptedRepositories(db.DefaultContext, "", &opts)
|
|
require.NoError(t, err)
|
|
require.Contains(t, repoNames, path.Join(username, unadopted))
|
|
|
|
doer := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 1})
|
|
owner := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
|
|
repo, err := AdoptRepository(db.DefaultContext, doer, owner, CreateRepoOptions{
|
|
Name: unadopted,
|
|
Description: "description",
|
|
IsPrivate: false,
|
|
AutoInit: true,
|
|
})
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, git.Sha1ObjectFormat.Name(), repo.ObjectFormatName)
|
|
}
|