Template
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo synced 2024-11-24 18:56:11 +01:00
forgejo/routers/api/packages
Giteabot 45b1f4dd3b
Add support for different Maven POM encoding (#25873) (#25890)
Backport #25873 by @KN4CK3R

Fixes #25853

- Maven POM files aren't always UTF-8 encoded.
- Reject the upload of unparsable POM files

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
2023-07-14 10:27:15 +00:00
..
alpine Replace interface{} with any (#25686) (#25687) 2023-07-04 23:41:32 -04:00
cargo Replace interface{} with any (#25686) (#25687) 2023-07-04 23:41:32 -04:00
chef Replace interface{} with any (#25686) (#25687) 2023-07-04 23:41:32 -04:00
composer Replace interface{} with any (#25686) (#25687) 2023-07-04 23:41:32 -04:00
conan Replace interface{} with any (#25686) (#25687) 2023-07-04 23:41:32 -04:00
conda Replace interface{} with any (#25686) (#25687) 2023-07-04 23:41:32 -04:00
container Test if container blob is accessible before mounting (#22759) (#25784) 2023-07-09 12:00:04 +00:00
cran Replace interface{} with any (#25686) (#25687) 2023-07-04 23:41:32 -04:00
debian Replace interface{} with any (#25686) (#25687) 2023-07-04 23:41:32 -04:00
generic Replace interface{} with any (#25686) (#25687) 2023-07-04 23:41:32 -04:00
goproxy Replace interface{} with any (#25686) (#25687) 2023-07-04 23:41:32 -04:00
helm Replace interface{} with any (#25686) (#25687) 2023-07-04 23:41:32 -04:00
helper Replace interface{} with any (#25686) (#25687) 2023-07-04 23:41:32 -04:00
maven Add support for different Maven POM encoding (#25873) (#25890) 2023-07-14 10:27:15 +00:00
npm Replace interface{} with any (#25686) (#25687) 2023-07-04 23:41:32 -04:00
nuget Replace interface{} with any (#25686) (#25687) 2023-07-04 23:41:32 -04:00
pub Replace interface{} with any (#25686) (#25687) 2023-07-04 23:41:32 -04:00
pypi Replace interface{} with any (#25686) (#25687) 2023-07-04 23:41:32 -04:00
rpm Replace interface{} with any (#25686) (#25687) 2023-07-04 23:41:32 -04:00
rubygems Replace interface{} with any (#25686) (#25687) 2023-07-04 23:41:32 -04:00
swift Replace interface{} with any (#25686) (#25687) 2023-07-04 23:41:32 -04:00
vagrant Replace interface{} with any (#25686) (#25687) 2023-07-04 23:41:32 -04:00
api.go Add CRAN package registry (#22331) 2023-05-22 10:57:49 +08:00
README.md Add package registry architecture overview (#23445) 2023-03-13 18:15:09 -04:00

Gitea Package Registry

This document gives a brief overview how the package registry is organized in code.

Structure

The package registry code is divided into multiple modules to split the functionality and make code reuse possible.

Module Description
models/packages Common methods and models used by all registry types
models/packages/<type> Methods used by specific registry type. There should be no need to use type specific models.
modules/packages Common methods and types used by multiple registry types
modules/packages/<type> Registry type specific methods and types (e.g. metadata extraction of package files)
routers/api/packages Route definitions for all registry types
routers/api/packages/<type> Route implementation for a specific registry type
services/packages Helper methods used by registry types to handle common tasks like package creation and deletion in routers
services/packages/<type> Registry type specific methods used by routers and services

Models

Every package registry implementation uses the same underlaying models:

Model Description
Package The root of a package providing values fixed for every version (e.g. the package name)
PackageVersion A version of a package containing metadata (e.g. the package description)
PackageFile A file of a package describing its content (e.g. file name)
PackageBlob The content of a file (may be shared by multiple files)
PackageProperty Additional properties attached to Package, PackageVersion or PackageFile (e.g. used if metadata is needed for routing)

The following diagram shows the relationship between the models:

Package <1---*> PackageVersion <1---*> PackageFile <*---1> PackageBlob

Adding a new package registry type

Before adding a new package registry type have a look at the existing implementation to get an impression of how it could work. Most registry types offer endpoints to retrieve the metadata, upload and download package files. The upload endpoint is often the heavy part because it must validate the uploaded blob, extract metadata and create the models. The methods to validate and extract the metadata should be added in the modules/packages/<type> package. If the upload is valid the methods in services/packages allow to store the upload and create the corresponding models. It depends if the registry type allows multiple files per package version which method should be called:

  • CreatePackageAndAddFile: error if package version already exists
  • CreatePackageOrAddFileToExisting: error if file already exists
  • AddFileToExistingPackage: error if package version does not exist or file already exists

services/packages also contains helper methods to download a file or to remove a package version. There are no helper methods for metadata endpoints because they are very type specific.