mirror of
https://codeberg.org/forgejo/forgejo
synced 2024-11-30 13:56:09 +01:00
637451a45e
Fixes #26548 This PR refactors the rendering of markup links. The old code uses `strings.Replace` to change some urls while the new code uses more context to decide which link should be generated. The added tests should ensure the same output for the old and new behaviour (besides the bug). We may need to refactor the rendering a bit more to make it clear how the different helper methods render the input string. There are lots of options (resolve links / images / mentions / git hashes / emojis / ...) but you don't really know what helper uses which options. For example, we currently support images in the user description which should not be allowed I think: <details> <summary>Profile</summary> https://try.gitea.io/KN4CK3R  </details> --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
51 lines
2.1 KiB
Handlebars
51 lines
2.1 KiB
Handlebars
{{$index := 0}}
|
|
<div class="timeline-item commits-list">
|
|
{{range .comment.Commits}}
|
|
{{$tag := printf "%s-%d" $.comment.HashTag $index}}
|
|
{{$index = Eval $index "+" 1}}
|
|
<div class="singular-commit" id="{{$tag}}">
|
|
<span class="badge badge-commit">{{svg "octicon-git-commit"}}</span>
|
|
{{if .User}}
|
|
<a class="avatar" href="{{.User.HomeLink}}">{{ctx.AvatarUtils.Avatar .User}}</a>
|
|
{{else}}
|
|
{{ctx.AvatarUtils.AvatarByEmail .Author.Email .Author.Name}}
|
|
{{end}}
|
|
|
|
{{$commitLink:= printf "%s/commit/%s" $.comment.Issue.PullRequest.BaseRepo.Link (PathEscape .ID.String)}}
|
|
|
|
<span class="shabox gt-df gt-ac gt-float-right">
|
|
{{template "repo/commit_statuses" dict "Status" .Status "Statuses" .Statuses}}
|
|
{{$class := "ui sha label"}}
|
|
{{if .Signature}}
|
|
{{$class = (print $class " isSigned")}}
|
|
{{if .Verification.Verified}}
|
|
{{if eq .Verification.TrustStatus "trusted"}}
|
|
{{$class = (print $class " isVerified")}}
|
|
{{else if eq .Verification.TrustStatus "untrusted"}}
|
|
{{$class = (print $class " isVerifiedUntrusted")}}
|
|
{{else}}
|
|
{{$class = (print $class " isVerifiedUnmatched")}}
|
|
{{end}}
|
|
{{else if .Verification.Warning}}
|
|
{{$class = (print $class " isWarning")}}
|
|
{{end}}
|
|
{{end}}
|
|
<a href="{{$commitLink}}" rel="nofollow" class="gt-ml-3 {{$class}}">
|
|
<span class="shortsha">{{ShortSha .ID.String}}</span>
|
|
{{if .Signature}}
|
|
{{template "repo/shabox_badge" dict "root" $.root "verification" .Verification}}
|
|
{{end}}
|
|
</a>
|
|
</span>
|
|
|
|
<span class="gt-mono commit-summary {{if gt .ParentCount 1}} grey text{{end}}" title="{{.Summary}}">{{RenderCommitMessageLinkSubject $.root.Context .Message $commitLink ($.comment.Issue.PullRequest.BaseRepo.ComposeMetas ctx)}}</span>
|
|
{{if IsMultilineCommitMessage .Message}}
|
|
<button class="ui button js-toggle-commit-body ellipsis-button" aria-expanded="false">...</button>
|
|
{{end}}
|
|
{{if IsMultilineCommitMessage .Message}}
|
|
<pre class="commit-body gt-hidden">{{RenderCommitBody $.root.Context .Message ($.comment.Issue.PullRequest.BaseRepo.ComposeMetas ctx)}}</pre>
|
|
{{end}}
|
|
</div>
|
|
{{end}}
|
|
</div>
|