mirror of
https://codeberg.org/forgejo/forgejo
synced 2024-11-28 04:36:11 +01:00
ea385f5d39
The API should only return the real Mail of a User, if the caller is logged in. The check do to this don't work. This PR fixes this. This not really a security issue, but can lead to Spam. --------- Co-authored-by: silverwind <me@silverwind.io>
68 lines
1.9 KiB
Go
68 lines
1.9 KiB
Go
// Copyright 2022 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package integration
|
|
|
|
import (
|
|
"fmt"
|
|
"net/http"
|
|
"testing"
|
|
|
|
auth_model "code.gitea.io/gitea/models/auth"
|
|
"code.gitea.io/gitea/models/unittest"
|
|
user_model "code.gitea.io/gitea/models/user"
|
|
api "code.gitea.io/gitea/modules/structs"
|
|
"code.gitea.io/gitea/tests"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestAPIUserInfo(t *testing.T) {
|
|
defer tests.PrepareTestEnv(t)()
|
|
|
|
user := "user1"
|
|
user2 := "user31"
|
|
|
|
user3 := unittest.AssertExistsAndLoadBean(t, &user_model.User{Name: "user3"})
|
|
|
|
session := loginUser(t, user)
|
|
token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeReadUser)
|
|
|
|
t.Run("GetInfo", func(t *testing.T) {
|
|
defer tests.PrintCurrentTest(t)()
|
|
|
|
req := NewRequest(t, "GET", fmt.Sprintf("/api/v1/users/%s?token=%s", user2, token))
|
|
resp := MakeRequest(t, req, http.StatusOK)
|
|
|
|
var u api.User
|
|
DecodeJSON(t, resp, &u)
|
|
assert.Equal(t, user2, u.UserName)
|
|
|
|
req = NewRequest(t, "GET", fmt.Sprintf("/api/v1/users/%s", user2))
|
|
MakeRequest(t, req, http.StatusNotFound)
|
|
|
|
// test if the placaholder Mail is returned if a User is not logged in
|
|
req = NewRequest(t, "GET", fmt.Sprintf("/api/v1/users/%s", user3.Name))
|
|
resp = MakeRequest(t, req, http.StatusOK)
|
|
DecodeJSON(t, resp, &u)
|
|
assert.Equal(t, user3.GetPlaceholderEmail(), u.Email)
|
|
|
|
// Test if the correct Mail is returned if a User is logged in
|
|
req = NewRequest(t, "GET", fmt.Sprintf("/api/v1/users/%s?token=%s", user3.Name, token))
|
|
resp = MakeRequest(t, req, http.StatusOK)
|
|
DecodeJSON(t, resp, &u)
|
|
assert.Equal(t, user3.GetEmail(), u.Email)
|
|
})
|
|
|
|
t.Run("GetAuthenticatedUser", func(t *testing.T) {
|
|
defer tests.PrintCurrentTest(t)()
|
|
|
|
req := NewRequest(t, "GET", fmt.Sprintf("/api/v1/user?token=%s", token))
|
|
resp := MakeRequest(t, req, http.StatusOK)
|
|
|
|
var u api.User
|
|
DecodeJSON(t, resp, &u)
|
|
assert.Equal(t, user, u.UserName)
|
|
})
|
|
}
|