mirror of
https://codeberg.org/forgejo/forgejo
synced 2024-11-25 03:06:10 +01:00
0ca13c5eae
When opening a repository, it will call `ensureValidRepository` and also `CatFileBatch`. But sometimes these will not be used until repository closed. So it's a waste of CPU to invoke 3 times git command for every open repository. This PR removed all of these from `OpenRepository` but only kept checking whether the folder exists. When a batch is necessary, the necessary functions will be invoked. --- Conflict resolution: Because of the removal of go-git in (#4941) `_nogogit.go` files were either renamed or merged into the 'common' file. Git does handle the renames correctly, but for those that were merged has to be manually copied pasted over. The patch looks the same, 201 additions 90 deletions as the original patch. (cherry picked from commit c03baab678ba5b2e9d974aea147e660417f5d3f7)
47 lines
1.2 KiB
Go
47 lines
1.2 KiB
Go
// Copyright 2024 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package git
|
|
|
|
import (
|
|
"bufio"
|
|
"context"
|
|
)
|
|
|
|
type Batch struct {
|
|
cancel context.CancelFunc
|
|
Reader *bufio.Reader
|
|
Writer WriteCloserError
|
|
}
|
|
|
|
func (repo *Repository) NewBatch(ctx context.Context) (*Batch, error) {
|
|
// Now because of some insanity with git cat-file not immediately failing if not run in a valid git directory we need to run git rev-parse first!
|
|
if err := ensureValidGitRepository(ctx, repo.Path); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
var batch Batch
|
|
batch.Writer, batch.Reader, batch.cancel = catFileBatch(ctx, repo.Path)
|
|
return &batch, nil
|
|
}
|
|
|
|
func (repo *Repository) NewBatchCheck(ctx context.Context) (*Batch, error) {
|
|
// Now because of some insanity with git cat-file not immediately failing if not run in a valid git directory we need to run git rev-parse first!
|
|
if err := ensureValidGitRepository(ctx, repo.Path); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
var check Batch
|
|
check.Writer, check.Reader, check.cancel = catFileBatchCheck(ctx, repo.Path)
|
|
return &check, nil
|
|
}
|
|
|
|
func (b *Batch) Close() {
|
|
if b.cancel != nil {
|
|
b.cancel()
|
|
b.Reader = nil
|
|
b.Writer = nil
|
|
b.cancel = nil
|
|
}
|
|
}
|