mirror of
https://codeberg.org/forgejo/forgejo
synced 2024-11-25 11:16:11 +01:00
81fe5d6185
This improves a lot of accessibility shortcomings. Every possible instance of `<div class="button">` matching the command `ag '<[^ab].*?class=.*?[" ]button[ "]' templates/ | grep -v 'dropdown'` has been converted when possible. divs with the `dropdown` class and their children were omitted as 1. more analysis must be conducted whether the dropdowns still work as intended when they are a `button` instead of a `div`. 2. most dropdowns have `div`s as children. The HTML standard disallows `div`s inside `button`s. 3. When a dropdown child that's part of the displayed text content is converted to a `button`, the dropdown can be focused twice Further changes include that all "gitea-managed" buttons with JS code received an `e.preventDefault()` so that they don't accidentally submit an underlying form, which would execute instead of cancel the action. Lastly, some minor issues were fixed as well during the refactoring. ## Future improvements As mentioned in https://github.com/go-gitea/gitea/pull/23337#discussion_r1127277391, `<a>`s without `href` attribute are not focusable. They should later on be converted to `<button>`s. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
69 lines
2.6 KiB
Handlebars
69 lines
2.6 KiB
Handlebars
{{template "base/head" .}}
|
|
<div role="main" aria-label="{{.Title}}" class="page-content repository settings options">
|
|
{{template "user/overview/header" .}}
|
|
<div class="ui container">
|
|
{{template "base/alert" .}}
|
|
<p><a href="{{.PackageDescriptor.FullWebLink}}">{{.PackageDescriptor.Package.Name}} ({{.PackageDescriptor.Version.Version}})</a> / <strong>{{.locale.Tr "repo.settings"}}</strong></p>
|
|
<h4 class="ui top attached header">
|
|
{{.locale.Tr "packages.settings.link"}}
|
|
</h4>
|
|
<div class="ui attached segment">
|
|
<p>{{.locale.Tr "packages.settings.link.description"}}</p>
|
|
<form class="ui form" action="{{.Link}}" method="post">
|
|
{{template "base/disable_form_autofill"}}
|
|
{{.CsrfTokenHtml}}
|
|
<input type="hidden" name="action" value="link">
|
|
<div class="field">
|
|
<div class="ui clearable selection dropdown">
|
|
{{$repoID := 0}}
|
|
{{if .PackageDescriptor.Repository}}
|
|
{{$repoID = .PackageDescriptor.Repository.ID}}
|
|
{{end}}
|
|
<input type="hidden" name="repo_id" value="{{$repoID}}">
|
|
<i class="dropdown icon"></i>
|
|
<div class="default text">{{.locale.Tr "packages.settings.link.select"}}</div>
|
|
<div class="menu">
|
|
{{range .Repos}}
|
|
<div class="item" data-value="{{.ID}}">{{.Name}}</div>
|
|
{{end}}
|
|
</div>
|
|
</div>
|
|
</div>
|
|
<div class="field">
|
|
<button class="ui green button">{{.locale.Tr "packages.settings.link.button"}}</button>
|
|
</div>
|
|
</form>
|
|
</div>
|
|
<h4 class="ui top attached error header">
|
|
{{.locale.Tr "repo.settings.danger_zone"}}
|
|
</h4>
|
|
<div class="ui attached error table danger segment">
|
|
<div class="item">
|
|
<div class="ui right">
|
|
<button class="ui basic red show-modal button" data-modal="#delete-package-modal">{{.locale.Tr "packages.settings.delete"}}</button>
|
|
</div>
|
|
<div>
|
|
<h5>{{.locale.Tr "packages.settings.delete"}}</h5>
|
|
<p>{{.locale.Tr "packages.settings.delete.description"}}</p>
|
|
</div>
|
|
<div class="ui tiny modal" id="delete-package-modal">
|
|
<div class="header">
|
|
{{.locale.Tr "packages.settings.delete"}}
|
|
</div>
|
|
<div class="content">
|
|
<div class="ui warning message text left gt-word-break">
|
|
{{.locale.Tr "packages.settings.delete.notice" .PackageDescriptor.Package.Name .PackageDescriptor.Version.Version}}
|
|
</div>
|
|
<form class="ui form" action="{{.Link}}" method="post">
|
|
{{.CsrfTokenHtml}}
|
|
<input type="hidden" name="action" value="delete">
|
|
{{template "base/delete_modal_actions" .}}
|
|
</form>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
{{template "base/footer" .}}
|