mirror of
https://codeberg.org/forgejo/forgejo
synced 2024-11-27 12:16:10 +01:00
7db542a029
Backport #28848 by @brechtvl
When LFS hooks are present in gitea-repositories, operations like git
push for creating a pull request fail. These repositories are not meant
to include LFS files or git push them, that is handled separately. And
so they should not have LFS hooks.
Installing git-lfs on some systems (like Debian Linux) will
automatically set up /etc/gitconfig to create LFS hooks in repositories.
For most git commands in Gitea this is not a problem, either because
they run on a temporary clone or the git command does not create LFS
hooks.
But one case where this happens is git archive for creating repository
archives. To fix that, add a GIT_CONFIG_NOSYSTEM=1 to disable using the
system configuration for that command.
According to a comment, GIT_CONFIG_NOSYSTEM is not used for all git
commands because the system configuration can be intentionally set up
for Gitea to use.
Resolves #19810, #21148
Co-authored-by: Brecht Van Lommel <brecht@blender.org>
(cherry picked from commit 0d50f27469)
81 lines
1.6 KiB
Go
81 lines
1.6 KiB
Go
// Copyright 2015 The Gogs Authors. All rights reserved.
|
|
// Copyright 2020 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package git
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"io"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
)
|
|
|
|
// ArchiveType archive types
|
|
type ArchiveType int
|
|
|
|
const (
|
|
// ZIP zip archive type
|
|
ZIP ArchiveType = iota + 1
|
|
// TARGZ tar gz archive type
|
|
TARGZ
|
|
// BUNDLE bundle archive type
|
|
BUNDLE
|
|
)
|
|
|
|
// String converts an ArchiveType to string
|
|
func (a ArchiveType) String() string {
|
|
switch a {
|
|
case ZIP:
|
|
return "zip"
|
|
case TARGZ:
|
|
return "tar.gz"
|
|
case BUNDLE:
|
|
return "bundle"
|
|
}
|
|
return "unknown"
|
|
}
|
|
|
|
func ToArchiveType(s string) ArchiveType {
|
|
switch s {
|
|
case "zip":
|
|
return ZIP
|
|
case "tar.gz":
|
|
return TARGZ
|
|
case "bundle":
|
|
return BUNDLE
|
|
}
|
|
return 0
|
|
}
|
|
|
|
// CreateArchive create archive content to the target path
|
|
func (repo *Repository) CreateArchive(ctx context.Context, format ArchiveType, target io.Writer, usePrefix bool, commitID string) error {
|
|
if format.String() == "unknown" {
|
|
return fmt.Errorf("unknown format: %v", format)
|
|
}
|
|
|
|
cmd := NewCommand(ctx, "archive")
|
|
if usePrefix {
|
|
cmd.AddOptionFormat("--prefix=%s", filepath.Base(strings.TrimSuffix(repo.Path, ".git"))+"/")
|
|
}
|
|
cmd.AddOptionFormat("--format=%s", format.String())
|
|
cmd.AddDynamicArguments(commitID)
|
|
|
|
// Avoid LFS hooks getting installed because of /etc/gitconfig, which can break pull requests.
|
|
env := append(os.Environ(), "GIT_CONFIG_NOSYSTEM=1")
|
|
|
|
var stderr strings.Builder
|
|
err := cmd.Run(&RunOpts{
|
|
Dir: repo.Path,
|
|
Stdout: target,
|
|
Stderr: &stderr,
|
|
Env: env,
|
|
})
|
|
if err != nil {
|
|
return ConcatenateError(err, stderr.String())
|
|
}
|
|
return nil
|
|
}
|