mirror of
https://codeberg.org/forgejo/forgejo
synced 2024-11-28 04:36:11 +01:00
353dcc5ad4
Backport #25701 by @CaiCandong we refactored `userIDFromToken` for the token parsing part into a new function `parseToken`. `parseToken` returns the string `token` from request, and a boolean `ok` representing whether the token exists or not. So we can distinguish between token non-existence and token inconsistency in the `verfity` function, thus solving the problem of no proper error message when the token is inconsistent. close #24439 related #22119 Co-authored-by: caicandong <50507092+CaiCandong@users.noreply.github.com> Co-authored-by: Jason Song <i@wolfogre.com>
113 lines
2.7 KiB
Go
113 lines
2.7 KiB
Go
// Copyright 2021 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package auth
|
|
|
|
import (
|
|
"context"
|
|
"net/http"
|
|
"reflect"
|
|
"strings"
|
|
|
|
user_model "code.gitea.io/gitea/models/user"
|
|
)
|
|
|
|
// Ensure the struct implements the interface.
|
|
var (
|
|
_ Method = &Group{}
|
|
_ Initializable = &Group{}
|
|
_ Freeable = &Group{}
|
|
)
|
|
|
|
// Group implements the Auth interface with serval Auth.
|
|
type Group struct {
|
|
methods []Method
|
|
}
|
|
|
|
// NewGroup creates a new auth group
|
|
func NewGroup(methods ...Method) *Group {
|
|
return &Group{
|
|
methods: methods,
|
|
}
|
|
}
|
|
|
|
// Add adds a new method to group
|
|
func (b *Group) Add(method Method) {
|
|
b.methods = append(b.methods, method)
|
|
}
|
|
|
|
// Name returns group's methods name
|
|
func (b *Group) Name() string {
|
|
names := make([]string, 0, len(b.methods))
|
|
for _, m := range b.methods {
|
|
if n, ok := m.(Named); ok {
|
|
names = append(names, n.Name())
|
|
} else {
|
|
names = append(names, reflect.TypeOf(m).Elem().Name())
|
|
}
|
|
}
|
|
return strings.Join(names, ",")
|
|
}
|
|
|
|
// Init does nothing as the Basic implementation does not need to allocate any resources
|
|
func (b *Group) Init(ctx context.Context) error {
|
|
for _, method := range b.methods {
|
|
initializable, ok := method.(Initializable)
|
|
if !ok {
|
|
continue
|
|
}
|
|
|
|
if err := initializable.Init(ctx); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// Free does nothing as the Basic implementation does not have to release any resources
|
|
func (b *Group) Free() error {
|
|
for _, method := range b.methods {
|
|
freeable, ok := method.(Freeable)
|
|
if !ok {
|
|
continue
|
|
}
|
|
if err := freeable.Free(); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// Verify extracts and validates
|
|
func (b *Group) Verify(req *http.Request, w http.ResponseWriter, store DataStore, sess SessionStore) (*user_model.User, error) {
|
|
// Try to sign in with each of the enabled plugins
|
|
var retErr error
|
|
for _, ssoMethod := range b.methods {
|
|
user, err := ssoMethod.Verify(req, w, store, sess)
|
|
if err != nil {
|
|
if retErr == nil {
|
|
retErr = err
|
|
}
|
|
// Try other methods if this one failed.
|
|
// Some methods may share the same protocol to detect if they are matched.
|
|
// For example, OAuth2 and conan.Auth both read token from "Authorization: Bearer <token>" header,
|
|
// If OAuth2 returns error, we should give conan.Auth a chance to try.
|
|
continue
|
|
}
|
|
|
|
// If any method returns a user, we can stop trying.
|
|
// Return the user and ignore any error returned by previous methods.
|
|
if user != nil {
|
|
if store.GetData()["AuthedMethod"] == nil {
|
|
if named, ok := ssoMethod.(Named); ok {
|
|
store.GetData()["AuthedMethod"] = named.Name()
|
|
}
|
|
}
|
|
return user, nil
|
|
}
|
|
}
|
|
|
|
// If no method returns a user, return the error returned by the first method.
|
|
return nil, retErr
|
|
}
|