mirror of
https://codeberg.org/forgejo/forgejo
synced 2024-12-03 07:16:11 +01:00
138942c09e
- Go's deadcode eliminator is quite simple, if you put a public function in a package `aa/bb` that is used only by tests, it would still be built if package `aa/bb` was imported. This means that if such functions use libraries relevant only to tests that those libraries would still be be built and increase the binary size of a Go binary. - This is also the case with Forgejo, `models/migrations/base/tests.go` contained functions exclusively used by tests which (skipping some steps here) imports https://github.com/ClickHouse/clickhouse-go, which is 2MiB. The `code.gitea.io/gitea/models/migrations/base` package is imported by `cmd/doctor` and thus the code of the clickhouse library is also built and included in the Forgejo binary, although entirely unused and not reachable. - This patch moves the test-related functions to their own package, so Go's deadcode eliminator knows not to build the test-related functions and thus reduces the size of the Forgejo binary. - It is not possible to move this to a `_test.go` file because Go does not allow importing functions from such files, so any test helper function must be in a non-test package and file. - Reduction of size (built with `TAGS="sqlite sqlite_unlock_notify" make build`): - Before: 95912040 bytes (92M) - After: 92306888 bytes (89M)
56 lines
1.3 KiB
Go
56 lines
1.3 KiB
Go
// Copyright 2021 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package v1_15 //nolint
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
|
|
migration_tests "code.gitea.io/gitea/models/migrations/test"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func Test_AddPrimaryEmail2EmailAddress(t *testing.T) {
|
|
type User struct {
|
|
ID int64
|
|
Email string
|
|
IsActive bool
|
|
}
|
|
|
|
// Prepare and load the testing database
|
|
x, deferable := migration_tests.PrepareTestEnv(t, 0, new(User))
|
|
if x == nil || t.Failed() {
|
|
defer deferable()
|
|
return
|
|
}
|
|
defer deferable()
|
|
|
|
err := AddPrimaryEmail2EmailAddress(x)
|
|
assert.NoError(t, err)
|
|
|
|
type EmailAddress struct {
|
|
ID int64 `xorm:"pk autoincr"`
|
|
UID int64 `xorm:"INDEX NOT NULL"`
|
|
Email string `xorm:"UNIQUE NOT NULL"`
|
|
LowerEmail string `xorm:"UNIQUE NOT NULL"`
|
|
IsActivated bool
|
|
IsPrimary bool `xorm:"DEFAULT(false) NOT NULL"`
|
|
}
|
|
|
|
users := make([]User, 0, 20)
|
|
err = x.Find(&users)
|
|
assert.NoError(t, err)
|
|
|
|
for _, user := range users {
|
|
var emailAddress EmailAddress
|
|
has, err := x.Where("lower_email=?", strings.ToLower(user.Email)).Get(&emailAddress)
|
|
assert.NoError(t, err)
|
|
assert.True(t, has)
|
|
assert.True(t, emailAddress.IsPrimary)
|
|
assert.EqualValues(t, user.IsActive, emailAddress.IsActivated)
|
|
assert.EqualValues(t, user.ID, emailAddress.UID)
|
|
}
|
|
}
|