mirror of
https://codeberg.org/forgejo/forgejo
synced 2024-11-29 21:26:10 +01:00
b6e81357bd
_This is a different approach to #20267, I took the liberty of adapting some parts, see below_ ## Context In some cases, a weebhook endpoint requires some kind of authentication. The usual way is by sending a static `Authorization` header, with a given token. For instance: - Matrix expects a `Bearer <token>` (already implemented, by storing the header cleartext in the metadata - which is buggy on retry #19872) - TeamCity #18667 - Gitea instances #20267 - SourceHut https://man.sr.ht/graphql.md#authentication-strategies (this is my actual personal need :) ## Proposed solution Add a dedicated encrypt column to the webhook table (instead of storing it as meta as proposed in #20267), so that it gets available for all present and future hook types (especially the custom ones #19307). This would also solve the buggy matrix retry #19872. As a first step, I would recommend focusing on the backend logic and improve the frontend at a later stage. For now the UI is a simple `Authorization` field (which could be later customized with `Bearer` and `Basic` switches):  The header name is hard-coded, since I couldn't fine any usecase justifying otherwise. ## Questions - What do you think of this approach? @justusbunsi @Gusted @silverwind - ~~How are the migrations generated? Do I have to manually create a new file, or is there a command for that?~~ - ~~I started adding it to the API: should I complete it or should I drop it? (I don't know how much the API is actually used)~~ ## Done as well: - add a migration for the existing matrix webhooks and remove the `Authorization` logic there _Closes #19872_ Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Gusted <williamzijl7@hotmail.com> Co-authored-by: delvh <dev.lh@web.de> |
||
|---|---|---|
| .. | ||
| activity.go | ||
| attachment.go | ||
| blame.go | ||
| branch.go | ||
| cherry_pick.go | ||
| commit.go | ||
| compare.go | ||
| download.go | ||
| editor.go | ||
| editor_test.go | ||
| find.go | ||
| http.go | ||
| http_test.go | ||
| issue.go | ||
| issue_content_history.go | ||
| issue_dependency.go | ||
| issue_label.go | ||
| issue_label_test.go | ||
| issue_lock.go | ||
| issue_stopwatch.go | ||
| issue_test.go | ||
| issue_timetrack.go | ||
| issue_watch.go | ||
| lfs.go | ||
| main_test.go | ||
| middlewares.go | ||
| migrate.go | ||
| milestone.go | ||
| packages.go | ||
| patch.go | ||
| projects.go | ||
| projects_test.go | ||
| pull.go | ||
| pull_review.go | ||
| release.go | ||
| release_test.go | ||
| render.go | ||
| repo.go | ||
| search.go | ||
| setting.go | ||
| setting_protected_branch.go | ||
| settings_test.go | ||
| tag.go | ||
| topic.go | ||
| treelist.go | ||
| view.go | ||
| view_test.go | ||
| webhook.go | ||
| wiki.go | ||
| wiki_test.go | ||
