mirror of
https://codeberg.org/forgejo/forgejo
synced 2024-12-03 23:36:09 +01:00
81fe5d6185
This improves a lot of accessibility shortcomings. Every possible instance of `<div class="button">` matching the command `ag '<[^ab].*?class=.*?[" ]button[ "]' templates/ | grep -v 'dropdown'` has been converted when possible. divs with the `dropdown` class and their children were omitted as 1. more analysis must be conducted whether the dropdowns still work as intended when they are a `button` instead of a `div`. 2. most dropdowns have `div`s as children. The HTML standard disallows `div`s inside `button`s. 3. When a dropdown child that's part of the displayed text content is converted to a `button`, the dropdown can be focused twice Further changes include that all "gitea-managed" buttons with JS code received an `e.preventDefault()` so that they don't accidentally submit an underlying form, which would execute instead of cancel the action. Lastly, some minor issues were fixed as well during the refactoring. ## Future improvements As mentioned in https://github.com/go-gitea/gitea/pull/23337#discussion_r1127277391, `<a>`s without `href` attribute are not focusable. They should later on be converted to `<button>`s. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
91 lines
3.1 KiB
Handlebars
91 lines
3.1 KiB
Handlebars
<div class="runner-container">
|
|
{{template "base/alert" .}}
|
|
|
|
<h4 class="ui top attached header">
|
|
{{.locale.Tr "actions.runners.runner_manage_panel"}} ({{.locale.Tr "admin.total" .Total}})
|
|
<div class="ui right">
|
|
<div class="ui top right pointing dropdown">
|
|
<button class="ui button primary">
|
|
{{.locale.Tr "actions.runners.new"}}
|
|
{{svg "octicon-triangle-down" 14 "dropdown icon"}}
|
|
</button>
|
|
<div class="menu">
|
|
<div class="item">
|
|
{{/* TODO: replece the document link when there's a better one than the README of act_runner */}}
|
|
<a href="https://gitea.com/gitea/act_runner/src/branch/main/README.md">{{.locale.Tr "actions.runners.new_notice"}}</a>
|
|
</div>
|
|
<div class="divider"></div>
|
|
<div class="header">
|
|
Registration Token
|
|
</div>
|
|
<div class="ui input">
|
|
<input type="text" value="{{.RegistrationToken}}">
|
|
<button class="ui basic label button" aria-label="{{.locale.Tr "copy"}}" data-clipboard-text="{{.RegistrationToken}}">
|
|
{{svg "octicon-copy" 14}}
|
|
</button>
|
|
</div>
|
|
<div class="divider"></div>
|
|
<div class="item">
|
|
<a href="{{$.Link}}/reset_registration_token">Reset registration token</a>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
|
|
</div>
|
|
</h4>
|
|
<div class="ui attached segment">
|
|
<form class="ui form ignore-dirty" id="user-list-search-form" action="{{$.Link}}">
|
|
<!-- Search Text -->
|
|
<div class="ui fluid action input" style="max-width: 70%;">
|
|
<input name="q" value="{{.Keyword}}" placeholder="{{.locale.Tr "explore.search"}}..." autofocus>
|
|
<button class="ui primary button">{{.locale.Tr "explore.search"}}</button>
|
|
</div>
|
|
</form>
|
|
</div>
|
|
<div class="ui attached table segment">
|
|
<table class="ui very basic striped table unstackable">
|
|
<thead>
|
|
<tr>
|
|
<th data-sortt-asc="online" data-sortt-desc="offline">{{.locale.Tr "actions.runners.status"}}</th>
|
|
<th data-sortt-asc="alphabetically">{{.locale.Tr "actions.runners.id"}}</th>
|
|
<th>{{.locale.Tr "actions.runners.name"}}</th>
|
|
<th>{{.locale.Tr "actions.runners.owner_type"}}</th>
|
|
<th>{{.locale.Tr "actions.runners.labels"}}</th>
|
|
<th>{{.locale.Tr "actions.runners.last_online"}}</th>
|
|
<th></th>
|
|
</tr>
|
|
</thead>
|
|
<tbody>
|
|
{{if .Runners}}
|
|
{{range .Runners}}
|
|
<tr>
|
|
<td>
|
|
<span class="runner-status-{{if .IsOnline}}online{{else}}offline{{end}}">{{.StatusLocaleName $.locale}}</span>
|
|
</td>
|
|
<td>{{.ID}}</td>
|
|
<td><p class="tooltip" data-content="{{.Description}}">{{.Name}}</p></td>
|
|
<td>{{.OwnType}}</td>
|
|
<td class="runner-tags">
|
|
{{range .AllLabels}}<span class="ui label">{{.}}</span>{{end}}
|
|
</td>
|
|
<td>{{if .LastOnline}}{{TimeSinceUnix .LastOnline $.locale}}{{else}}{{$.locale.Tr "never"}}{{end}}</td>
|
|
<td class="runner-ops">
|
|
{{if .Editable $.RunnerOnwerID $.RunnerRepoID}}
|
|
<a href="{{$.Link}}/{{.ID}}">{{svg "octicon-pencil"}}</a>
|
|
{{end}}
|
|
</td>
|
|
</tr>
|
|
{{end}}
|
|
{{else}}
|
|
<tr>
|
|
<td class="center aligned" colspan="6">{{.locale.Tr "actions.runners.none"}}</td>
|
|
</tr>
|
|
{{end}}
|
|
</tbody>
|
|
</table>
|
|
</div>
|
|
|
|
{{template "base/paginate" .}}
|
|
|
|
</div>
|