Template
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo synced 2024-11-29 21:26:10 +01:00
forgejo/modules/markup
KN4CK3R 875b398e5e
Rework markup link rendering (#26745) (#28803)
Backport #26745
Fixes #26548

This PR refactors the rendering of markup links. The old code uses
`strings.Replace` to change some urls while the new code uses more
context to decide which link should be generated.

The added tests should ensure the same output for the old and new
behaviour (besides the bug).

We may need to refactor the rendering a bit more to make it clear how
the different helper methods render the input string. There are lots of
options (resolve links / images / mentions / git hashes / emojis / ...)
but you don't really know what helper uses which options. For example,
we currently support images in the user description which should not be
allowed I think:

<details>
  <summary>Profile</summary>

https://try.gitea.io/KN4CK3R

![grafik](https://github.com/go-gitea/gitea/assets/1666336/109ae422-496d-4200-b52e-b3a528f553e5)

</details>

(cherry picked from commit 022552d5b6)
2024-01-16 14:41:11 +00:00
..
asciicast Support asciicast files as new markup (#22448) 2023-01-18 08:46:58 +08:00
common [GITEA] test markdown CleanValue to prevent regression 2023-12-13 18:12:08 +01:00
console Add context when rendering labels or emojis (#23281) 2023-03-05 22:59:05 +01:00
csv Add context when rendering labels or emojis (#23281) 2023-03-05 22:59:05 +01:00
external Rework markup link rendering (#26745) (#28803) 2024-01-16 14:41:11 +00:00
markdown Rework markup link rendering (#26745) (#28803) 2024-01-16 14:41:11 +00:00
mdstripper Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
orgmode Rework markup link rendering (#26745) (#28803) 2024-01-16 14:41:11 +00:00
camo.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
camo_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
html.go Rework markup link rendering (#26745) (#28803) 2024-01-16 14:41:11 +00:00
html_internal_test.go Rework markup link rendering (#26745) (#28803) 2024-01-16 14:41:11 +00:00
html_test.go Rework markup link rendering (#26745) (#28803) 2024-01-16 14:41:11 +00:00
renderer.go Rework markup link rendering (#26745) (#28803) 2024-01-16 14:41:11 +00:00
renderer_test.go Move IsReadmeFile* from modules/markup/ to modules/util (#22877) 2023-02-13 15:01:09 -05:00
sanitizer.go [GITEA] Use restricted sanitizer for repository description 2023-11-13 14:06:30 +01:00
sanitizer_test.go [GITEA] Use restricted sanitizer for repository description 2023-11-13 14:06:30 +01:00