magic_rb/forgejo
Template
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo synced 2024-11-24 02:36:10 +01:00
Code Issues Packages Projects Releases Wiki Activity
forgejo/models/issues
History
KN4CK3R 637451a45e
Rework markup link rendering (#26745) 
Fixes #26548

This PR refactors the rendering of markup links. The old code uses
`strings.Replace` to change some urls while the new code uses more
context to decide which link should be generated.

The added tests should ensure the same output for the old and new
behaviour (besides the bug).

We may need to refactor the rendering a bit more to make it clear how
the different helper methods render the input string. There are lots of
options (resolve links / images / mentions / git hashes / emojis / ...)
but you don't really know what helper uses which options. For example,
we currently support images in the user description which should not be
allowed I think:

<details>
  <summary>Profile</summary> 

https://try.gitea.io/KN4CK3R

![grafik](https://github.com/go-gitea/gitea/assets/1666336/109ae422-496d-4200-b52e-b3a528f553e5)

</details>

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-01-15 08:49:24 +00:00
..
assignees.go Remove GetByBean method because sometimes it's danger when query condition parameter is zero and also introduce new generic methods (#28220) 2023-12-07 15:27:36 +08:00
assignees_test.go Remove deadcode under models/issues (#28536) 2023-12-19 20:12:02 +01:00
comment.go Move more functions to db.Find (#28419) 2024-01-15 02:19:25 +00:00
comment_code.go Rework markup link rendering (#26745) 2024-01-15 08:49:24 +00:00
comment_list.go Add logs for data broken of comment review (#27326) 2023-09-29 02:31:36 +00:00
comment_test.go More db.DefaultContext refactor (#27265) 2023-09-29 12:12:54 +00:00
content_history.go Fix comment permissions (#28213) 2023-11-25 17:21:21 +00:00
content_history_test.go Fix comment permissions (#28213) 2023-11-25 17:21:21 +00:00
dependency.go Penultimate round of db.DefaultContext refactor (#27414) 2023-10-11 04:24:07 +00:00
dependency_test.go Penultimate round of db.DefaultContext refactor (#27414) 2023-10-11 04:24:07 +00:00
issue.go Remove deadcode under models/issues (#28536) 2023-12-19 20:12:02 +01:00
issue_index.go Another round of db.DefaultContext refactor (#27103) 2023-09-25 13:17:37 +00:00
issue_label.go Penultimate round of db.DefaultContext refactor (#27414) 2023-10-11 04:24:07 +00:00
issue_label_test.go Penultimate round of db.DefaultContext refactor (#27414) 2023-10-11 04:24:07 +00:00
issue_list.go Add context parameter to some database functions (#26055) 2023-07-22 22:14:27 +08:00
issue_list_test.go Add context parameter to some database functions (#26055) 2023-07-22 22:14:27 +08:00
issue_lock.go Penultimate round of db.DefaultContext refactor (#27414) 2023-10-11 04:24:07 +00:00
issue_project.go Clean some functions about project issue (#27705) 2023-10-20 14:01:25 +02:00
issue_search.go Remove deadcode under models/issues (#28536) 2023-12-19 20:12:02 +01:00
issue_stats.go Another round of db.DefaultContext refactor (#27103) 2023-09-25 13:17:37 +00:00
issue_test.go Refactor deletion (#28610) 2023-12-25 21:25:29 +01:00
issue_update.go Don't use subselect in DeleteIssuesByRepoID (#27332) 2023-10-03 08:17:28 +00:00
issue_user.go Add combined index for issue_user.uid and issue_id (#28080) 2023-12-14 09:26:59 +00:00
issue_user_test.go Fix bug with sqlite load read (#26305) 2023-08-05 10:40:27 +08:00
issue_watch.go Even more db.DefaultContext refactor (#27352) 2023-10-03 10:30:41 +00:00
issue_watch_test.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
issue_xref.go More db.DefaultContext refactor (#27265) 2023-09-29 12:12:54 +00:00
issue_xref_test.go Replace 'userxx' with 'orgxx' in all test files when the user type is org (#27052) 2023-09-14 02:59:53 +00:00
label.go Refactor deletion (#28610) 2023-12-25 21:25:29 +01:00
label_test.go Remove deadcode under models/issues (#28536) 2023-12-19 20:12:02 +01:00
main_test.go make writing main test easier (#27270) 2023-09-28 01:38:53 +00:00
milestone.go Refactor timeutil package (#28623) 2023-12-28 10:09:57 +00:00
milestone_list.go Remove deadcode under models/issues (#28536) 2023-12-19 20:12:02 +01:00
milestone_test.go Remove deadcode under models/issues (#28536) 2023-12-19 20:12:02 +01:00
pull.go Add branch protection setting for ignoring stale approvals (#28498) 2024-01-15 07:20:01 +00:00
pull_list.go More refactoring of db.DefaultContext (#27083) 2023-09-15 06:13:19 +00:00
pull_test.go Penultimate round of db.DefaultContext refactor (#27414) 2023-10-11 04:24:07 +00:00
reaction.go Another round of db.DefaultContext refactor (#27103) 2023-09-25 13:17:37 +00:00
reaction_test.go Another round of db.DefaultContext refactor (#27103) 2023-09-25 13:17:37 +00:00
review.go Refactor some legacy code and remove unused code (#28622) 2023-12-28 09:38:59 +00:00
review_list.go Another round of db.DefaultContext refactor (#27103) 2023-09-25 13:17:37 +00:00
review_test.go Fix 500 when deleting a dismissed review (#27903) 2023-11-05 13:25:40 +00:00
stopwatch.go Remove deadcode under models/issues (#28536) 2023-12-19 20:12:02 +01:00
stopwatch_test.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
tracked_time.go Move more functions to db.Find (#28419) 2024-01-15 02:19:25 +00:00
tracked_time_test.go Show total TrackedTime on issue/pull/milestone lists (#26672) 2023-10-19 14:08:31 +00:00