Template
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo synced 2024-12-13 23:11:57 +01:00
forgejo/services/auth/source
Giteabot 37d3e0ec33
Fix accidental overwriting of LDAP team memberships (#24050) (#24065)
Backport #24050 by @sillyguodong

In the `for` loop, the value of `membershipsToAdd[org]` and
`membershipsToRemove[org]` is a slice that should be appended instead of
overwritten.
Due to the current overwrite, the LDAP group sync only matches the last
group at the moment.

## Example reproduction
- an LDAP user is both a member of
`cn=admin_staff,ou=people,dc=planetexpress,dc=com` and
`cn=ship_crew,ou=people,dc=planetexpress,dc=com`.
- configuration of `Map LDAP groups to Organization teams ` in
`Authentication Sources`:
```json
{
    "cn=admin_staff,ou=people,dc=planetexpress,dc=com":{
        "test_organization":[
            "admin_staff",
            "test_add"
        ]
    },
    "cn=ship_crew,ou=people,dc=planetexpress,dc=com":{
        "test_organization":[
            "ship_crew"
        ]
}
```
- start `Synchronize external user data` task in the `Dashboard`.
- the user was only added for the team `test_organization.ship_crew`

Co-authored-by: sillyguodong <33891828+sillyguodong@users.noreply.github.com>
2023-04-12 07:22:02 -04:00
..
db Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
ldap Don't apply the group filter when listing LDAP group membership if it is empty (#23745) (#23788) 2023-03-29 15:00:12 -04:00
oauth2 Handle OpenID discovery URL errors a little nicer when creating/editing sources (#23397) (#23403) 2023-03-10 08:29:28 -06:00
pam Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
smtp Improve utils of slices (#22379) 2023-01-11 13:31:16 +08:00
sspi Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
source_group_sync.go Fix accidental overwriting of LDAP team memberships (#24050) (#24065) 2023-04-12 07:22:02 -04:00