Template
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo synced 2024-11-22 09:54:24 +01:00
forgejo/tests
wxiaoguang 59d060622d
Improve RSS (#24335)
Follow  #22719

### Major changes

1. `ServerError` doesn't do format, so remove the `%s`
2. Simplify `RenderBranchFeed` (slightly)
3. Remove unused `BranchFeedRSS`
4. Make `feed.RenderBranchFeed` respect `EnableFeed` config
5. Make `RepoBranchTagSelector.vue` respect `EnableFeed` setting,
otherwise there is always RSS icon
6. The `(branchURLPrefix + item.url).replace('src', 'rss')` doesn't seem
right for all cases, for example, the string `src` could appear in
`branchURLPrefix`, so we need a separate `rssURLPrefix`
7. The `<a>` in Vue menu needs `@click.stop`, otherwise the menu itself
would be triggered at the same time
8. Change `<a><button></button></a>` to `<a role=button>`
9. Use `{{PathEscapeSegments .TreePath}}` instead of `{{range $i, $v :=
.TreeNames}}/{{$v}}{{end}}`


Screenshot of changed parts:

<details>


![image](https://user-images.githubusercontent.com/2114189/234315538-66603694-9093-48a8-af33-83575fd7a018.png)


![image](https://user-images.githubusercontent.com/2114189/234315786-f1efa60b-012e-490b-8ce2-d448dc6fe5c9.png)


![image](https://user-images.githubusercontent.com/2114189/234334941-446941bc-1baa-4256-8850-ccc439476cda.png)

</details>


### Other thoughts

Should we remove the RSS icon from the branch dropdown list? It seems
too complex for a list UI, and users already have the chance to get the
RSS feed URL from "branches" page.

---------

Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: silverwind <me@silverwind.io>
2023-04-25 22:53:44 -04:00
..
e2e Enable forbidigo linter (#24278) 2023-04-24 05:50:58 -04:00
fuzz Move fuzz tests into tests/fuzz (#22376) 2023-01-09 15:30:14 +08:00
gitea-lfs-meta Test views of LFS files (#22196) 2022-12-23 07:41:56 +08:00
gitea-repositories-meta Remove git sample files and ignore them (#24271) 2023-04-22 20:29:29 +08:00
integration Improve RSS (#24335) 2023-04-25 22:53:44 -04:00
mssql.ini.tmpl Kd/ci playwright go test (#20123) 2022-09-02 15:18:23 -04:00
mysql.ini.tmpl Split CI pipelines (#23385) 2023-03-10 01:13:17 -05:00
mysql8.ini.tmpl Kd/ci playwright go test (#20123) 2022-09-02 15:18:23 -04:00
pgsql.ini.tmpl Make minio package support legacy MD5 checksum (#23768) 2023-03-28 11:10:24 -04:00
sqlite.ini.tmpl Clean some legacy files and move some build files (#23699) 2023-03-25 16:22:51 -04:00
test_utils.go Enable forbidigo linter (#24278) 2023-04-24 05:50:58 -04:00
testlogger.go Improve test logger (#24235) 2023-04-21 16:32:25 -04:00