mirror of
https://codeberg.org/forgejo/forgejo
synced 2024-11-24 10:46:10 +01:00
138942c09e
- Go's deadcode eliminator is quite simple, if you put a public function in a package `aa/bb` that is used only by tests, it would still be built if package `aa/bb` was imported. This means that if such functions use libraries relevant only to tests that those libraries would still be be built and increase the binary size of a Go binary. - This is also the case with Forgejo, `models/migrations/base/tests.go` contained functions exclusively used by tests which (skipping some steps here) imports https://github.com/ClickHouse/clickhouse-go, which is 2MiB. The `code.gitea.io/gitea/models/migrations/base` package is imported by `cmd/doctor` and thus the code of the clickhouse library is also built and included in the Forgejo binary, although entirely unused and not reachable. - This patch moves the test-related functions to their own package, so Go's deadcode eliminator knows not to build the test-related functions and thus reduces the size of the Forgejo binary. - It is not possible to move this to a `_test.go` file because Go does not allow importing functions from such files, so any test helper function must be in a non-test package and file. - Reduction of size (built with `TAGS="sqlite sqlite_unlock_notify" make build`): - Before: 95912040 bytes (92M) - After: 92306888 bytes (89M)
119 lines
2.5 KiB
Go
119 lines
2.5 KiB
Go
// Copyright 2023 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package v1_22 //nolint
|
|
|
|
import (
|
|
"testing"
|
|
|
|
migration_tests "code.gitea.io/gitea/models/migrations/test"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"xorm.io/xorm"
|
|
)
|
|
|
|
func PrepareOldRepository(t *testing.T) (*xorm.Engine, func()) {
|
|
type Repository struct { // old struct
|
|
ID int64 `xorm:"pk autoincr"`
|
|
}
|
|
|
|
type CommitStatus struct {
|
|
ID int64
|
|
ContextHash string `xorm:"char(40) index"`
|
|
}
|
|
|
|
type RepoArchiver struct {
|
|
ID int64
|
|
RepoID int64 `xorm:"index unique(s)"`
|
|
Type int `xorm:"unique(s)"`
|
|
CommitID string `xorm:"VARCHAR(40) unique(s)"`
|
|
}
|
|
|
|
type ReviewState struct {
|
|
ID int64
|
|
UserID int64 `xorm:"NOT NULL UNIQUE(pull_commit_user)"`
|
|
PullID int64 `xorm:"NOT NULL INDEX UNIQUE(pull_commit_user) DEFAULT 0"`
|
|
CommitSHA string `xorm:"NOT NULL VARCHAR(40) UNIQUE(pull_commit_user)"`
|
|
}
|
|
|
|
type Comment struct {
|
|
ID int64
|
|
CommitSHA string
|
|
}
|
|
|
|
type PullRequest struct {
|
|
ID int64
|
|
CommitSHA string
|
|
MergeBase string
|
|
MergedCommitID string
|
|
}
|
|
|
|
type Release struct {
|
|
ID int64
|
|
Sha1 string
|
|
}
|
|
|
|
type RepoIndexerStatus struct {
|
|
ID int64
|
|
CommitSHA string
|
|
}
|
|
|
|
type Review struct {
|
|
ID int64
|
|
CommitID string
|
|
}
|
|
|
|
// Prepare and load the testing database
|
|
return migration_tests.PrepareTestEnv(t, 0,
|
|
new(Repository),
|
|
new(CommitStatus),
|
|
new(RepoArchiver),
|
|
new(ReviewState),
|
|
new(Review),
|
|
new(Comment),
|
|
new(PullRequest),
|
|
new(Release),
|
|
new(RepoIndexerStatus),
|
|
)
|
|
}
|
|
|
|
func Test_RepositoryFormat(t *testing.T) {
|
|
x, deferable := PrepareOldRepository(t)
|
|
defer deferable()
|
|
|
|
assert.NoError(t, AdjustDBForSha256(x))
|
|
|
|
type Repository struct {
|
|
ID int64 `xorm:"pk autoincr"`
|
|
ObjectFormatName string `xorg:"not null default('sha1')"`
|
|
}
|
|
|
|
repo := new(Repository)
|
|
|
|
// check we have some records to migrate
|
|
count, err := x.Count(new(Repository))
|
|
assert.NoError(t, err)
|
|
assert.EqualValues(t, 4, count)
|
|
|
|
repo.ObjectFormatName = "sha256"
|
|
_, err = x.Insert(repo)
|
|
assert.NoError(t, err)
|
|
id := repo.ID
|
|
|
|
count, err = x.Count(new(Repository))
|
|
assert.NoError(t, err)
|
|
assert.EqualValues(t, 5, count)
|
|
|
|
repo = new(Repository)
|
|
ok, err := x.ID(2).Get(repo)
|
|
assert.NoError(t, err)
|
|
assert.EqualValues(t, true, ok)
|
|
assert.EqualValues(t, "sha1", repo.ObjectFormatName)
|
|
|
|
repo = new(Repository)
|
|
ok, err = x.ID(id).Get(repo)
|
|
assert.NoError(t, err)
|
|
assert.EqualValues(t, true, ok)
|
|
assert.EqualValues(t, "sha256", repo.ObjectFormatName)
|
|
}
|