Template
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo synced 2024-11-26 19:56:11 +01:00
forgejo/services
Giteabot 37d3e0ec33
Fix accidental overwriting of LDAP team memberships (#24050) (#24065)
Backport #24050 by @sillyguodong

In the `for` loop, the value of `membershipsToAdd[org]` and
`membershipsToRemove[org]` is a slice that should be appended instead of
overwritten.
Due to the current overwrite, the LDAP group sync only matches the last
group at the moment.

## Example reproduction
- an LDAP user is both a member of
`cn=admin_staff,ou=people,dc=planetexpress,dc=com` and
`cn=ship_crew,ou=people,dc=planetexpress,dc=com`.
- configuration of `Map LDAP groups to Organization teams ` in
`Authentication Sources`:
```json
{
    "cn=admin_staff,ou=people,dc=planetexpress,dc=com":{
        "test_organization":[
            "admin_staff",
            "test_add"
        ]
    },
    "cn=ship_crew,ou=people,dc=planetexpress,dc=com":{
        "test_organization":[
            "ship_crew"
        ]
}
```
- start `Synchronize external user data` task in the `Dashboard`.
- the user was only added for the team `test_organization.ship_crew`

Co-authored-by: sillyguodong <33891828+sillyguodong@users.noreply.github.com>
2023-04-12 07:22:02 -04:00
..
actions Refactor commit status for Actions jobs (#23786) (#24060) 2023-04-11 22:37:34 -04:00
agit Rename almost all Ctx functions (#22071) 2022-12-10 10:46:31 +08:00
asymkey Add context cache as a request level cache (#22294) 2023-02-15 21:37:34 +08:00
attachment Preserve file size when creating attachments (#23406) (#23426) 2023-03-12 12:45:39 +01:00
auth Fix accidental overwriting of LDAP team memberships (#24050) (#24065) 2023-04-12 07:22:02 -04:00
automerge Add force_merge to merge request and fix checking mergable (#23010) 2023-02-21 08:42:07 -06:00
context Use User.ID instead of User.Name in ActivityPub API for Person IRI (#23823) (#23905) 2023-04-03 22:41:57 -05:00
convert Fix SyncOnCommit always return false in API of push_mirrors (#23088) (#23100) 2023-02-24 14:36:25 +08:00
cron Add Cargo package registry (#21888) 2023-02-05 18:12:31 +08:00
externalaccount Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
forms Title can be empty when creating tag only (#23917) (#23961) 2023-04-07 20:13:57 +08:00
gitdiff Fix broken code editor diff preview (#23307) (#23320) 2023-03-06 12:05:35 -06:00
issue Webhooks: for issue close/reopen action, add commit ID that caused it (#22583) 2023-01-24 23:47:53 -05:00
lfs Check IsActionsToken for LFS authentication (#23841) (#23875) 2023-04-02 21:30:33 +01:00
mailer Preserve file size when creating attachments (#23406) (#23426) 2023-03-12 12:45:39 +01:00
markup Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
migrations Add loading yaml label template files (#22976) (#23232) 2023-03-01 21:57:34 -05:00
mirror Fill head commit to in payload when notifying push commits for mirroring (#23215) (#23292) 2023-03-04 19:02:50 +01:00
org Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
packages Use import of OCI structs (#22765) 2023-02-06 10:07:09 +00:00
pull [Patch] Fix closed PR also triggers Webhooks and actions (#23782) (#23834) 2023-03-31 14:29:23 +08:00
release Delete deleted release attachments immediately from storage (#23913) (#23958) 2023-04-06 18:38:34 -04:00
repository fix submodule is nil panic (#23588) (#23601) 2023-03-21 09:39:40 +08:00
task Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
user Add context cache as a request level cache (#22294) 2023-02-15 21:37:34 +08:00
webhook Fix incorrect HookEventType of pull request review comments (#23650) (#23678) 2023-03-24 20:56:15 -04:00
wiki Improve utils of slices (#22379) 2023-01-11 13:31:16 +08:00