Template
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo synced 2024-11-24 18:56:11 +01:00
forgejo/routers/repo
mrsdizzie 8d99ee2773
Add Organization Wide Labels (#10814)
* Add organization wide labels

Implement organization wide labels similar to organization wide
webhooks. This lets you create individual labels for organizations that can be used
for all repos under that organization (so being able to reuse the same
label across multiple repos).

This makes it possible for small organizations with many repos to use
labels effectively.

Fixes #7406

* Add migration

* remove comments

* fix tests

* Update options/locale/locale_en-US.ini

Removed unused translation string

* show org labels in issue search label filter

* Use more clear var name

* rename migration after merge from master

* comment typo

* update migration again after rebase with master

* check for orgID <=0 per guillep2k review

* fmt

* Apply suggestions from code review

Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>

* remove unused code

* Make sure RepoID is 0 when searching orgID per code review

* more changes/code review requests

* More descriptive translation var per code review

* func description/delete comment when issue label deleted instead of hiding it

* remove comment

* only use issues in that repo when calculating number of open issues for org label on repo label page

* Add integration test for IssuesSearch API with labels

* remove unused function

* Update models/issue_label.go

Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>

* Use subquery in GetLabelIDsInReposByNames

* Fix tests to use correct orgID

* fix more tests

* IssuesSearch api now uses new BuildLabelNamesIssueIDsCondition. Add a few more tests as well

* update comment for clarity

* Revert previous code change now that we can use the new BuildLabelNamesIssueIDsCondition

* Don't sort repos by date in IssuesSearch API

After much debugging I've found a strange issue where in some cases MySQL will return a different result than other enigines if a query is sorted by a null collumn. For example with our integration test data where we don't set updated_unix in repository fixtures:

SELECT `id`, `owner_id`, `owner_name`, `lower_name`, `name`, `description`, `website`, `original_service_type`, `original_url`, `default_branch`, `num_watches`, `num_stars`, `num_forks`, `num_issues`, `num_closed_issues`, `num_pulls`, `num_closed_pulls`, `num_milestones`, `num_closed_milestones`, `is_private`, `is_empty`, `is_archived`, `is_mirror`, `status`, `is_fork`, `fork_id`, `is_template`, `template_id`, `size`, `is_fsck_enabled`, `close_issues_via_commit_in_any_branch`, `topics`, `avatar`, `created_unix`, `updated_unix` FROM `repository` ORDER BY updated_unix DESC LIMIT 15 OFFSET 45

Returns different results for MySQL than other engines. However, the similar query:

SELECT `id`, `owner_id`, `owner_name`, `lower_name`, `name`, `description`, `website`, `original_service_type`, `original_url`, `default_branch`, `num_watches`, `num_stars`, `num_forks`, `num_issues`, `num_closed_issues`, `num_pulls`, `num_closed_pulls`, `num_milestones`, `num_closed_milestones`, `is_private`, `is_empty`, `is_archived`, `is_mirror`, `status`, `is_fork`, `fork_id`, `is_template`, `template_id`, `size`, `is_fsck_enabled`, `close_issues_via_commit_in_any_branch`, `topics`, `avatar`, `created_unix`, `updated_unix` FROM `repository` ORDER BY updated_unix DESC LIMIT 15 OFFSET 30

Returns the same results.

This causes integration tests to fail on MySQL in certain cases but would never show up in a real installation. Since this API call always returns issues based on the optionally provided repo_priority_id or the issueID itself, there is no change to results by changing the repo sorting method used to get ids earlier in the function.

* linter is back!

* code review

* remove now unused option

* Fix newline at end of files

* more unused code

* update to master

* check for matching ids before query

* Update models/issue_label.go

Co-Authored-By: 6543 <6543@obermui.de>

* Update models/issue_label.go

* update comments

* Update routers/org/setting.go

Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
Co-authored-by: 6543 <6543@obermui.de>
2020-04-01 01:14:46 -03:00
..
activity.go Add top author stats to activity page (#9615) 2020-01-20 12:07:30 +02:00
attachment.go Move dropzone.js to npm/webpack (#10645) 2020-03-07 21:06:15 +00:00
blame.go make avatar lookup occur at image request (#10540) 2020-03-27 14:34:39 +02:00
branch.go Handle push rejection in branch and upload (#10854) 2020-03-28 01:13:18 -03:00
commit.go Fix potential bugs (#10513) 2020-02-27 20:10:27 -03:00
compare.go Add Organization Wide Labels (#10814) 2020-04-01 01:14:46 -03:00
download.go Fix download file wrong content-type (#9825) 2020-01-17 20:16:05 +08:00
editor.go Handle push rejection in branch and upload (#10854) 2020-03-28 01:13:18 -03:00
editor_test.go Add Close() method to gogitRepository (#8901) 2019-11-13 07:01:19 +00:00
http.go add remote ip to the invalid credentials error message (#9918) 2020-01-21 17:51:39 -05:00
issue.go Add Organization Wide Labels (#10814) 2020-04-01 01:14:46 -03:00
issue_dependency.go Fix wrong permissions check when issues/prs shared operations (#9885) 2020-01-20 13:00:32 +01:00
issue_label.go Add Organization Wide Labels (#10814) 2020-04-01 01:14:46 -03:00
issue_label_test.go fix go vet error (#3740) 2018-03-30 07:21:27 +08:00
issue_lock.go Implement "conversation lock" for issue comments (#5073) 2019-02-18 22:55:04 +02:00
issue_stopwatch.go Automatically clear stopwatch on merging a PR (#4327) 2019-02-05 13:38:11 +02:00
issue_timetrack.go [API] Extend times API (#9200) 2019-12-27 20:30:58 +00:00
issue_watch.go Fix PR/issue redirects when having external tracker (#9339) 2019-12-14 01:53:32 +01:00
lfs.go Migrate to go-git/go-git v5.0.0 (#10735) 2020-03-17 12:19:58 -04:00
main_test.go Unit tests for wiki routers (#3022) 2017-11-30 17:52:15 +02:00
middlewares.go fix wrong system notice when repository is empty (#9010) 2019-11-15 10:53:20 +00:00
milestone.go move jquery-datetimepicker to npm/webpack (#10713) 2020-03-17 15:08:15 -04:00
pull.go Various Merge Base fixes (#10786) 2020-03-31 16:42:44 +03:00
pull_review.go Upgrade golangci-lint to 1.24.0 (#10894) 2020-03-30 21:52:45 +03:00
release.go API add/generalize pagination (#9452) 2020-01-24 14:00:29 -05:00
release_test.go Add Close() method to gogitRepository (#8901) 2019-11-13 07:01:19 +00:00
repo.go Option to set default branch at repository creation (#10803) 2020-03-26 19:14:51 +00:00
search.go Add detected file language to code search (#10256) 2020-02-20 16:53:55 -03:00
setting.go API endpoint for repo transfer (#9947) 2020-01-31 15:49:04 +00:00
setting_protected_branch.go Allow to set protected file patterns that can not be changed under no conditions (#10806) 2020-03-27 00:26:34 +02:00
settings_test.go Stop various tests from adding to the source tree (#9515) 2019-12-28 10:08:05 +08:00
topic.go Add API endpoint for accessing repo topics (#7963) 2019-09-03 23:46:24 +08:00
view.go Show Signer in commit lists and add basic trust (#10425) 2020-02-27 16:20:55 -03:00
webhook.go Add Matrix webhook (#10831) 2020-03-28 15:09:55 +02:00
wiki.go Show Signer in commit lists and add basic trust (#10425) 2020-02-27 16:20:55 -03:00
wiki_test.go Fix wiki raw view on sub path (#10002) 2020-01-28 09:44:08 +00:00