Template
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo synced 2024-11-27 04:06:10 +01:00
forgejo/routers
Otto Richter (fnetX) 3362620ee3
Fix api error message if fork exists (#24487)
On the @Forgejo instance of Codeberg, we discovered that forking a repo
which is already forked now returns a 500 Internal Server Error, which
is unexpected. This is an attempt at fixing this.

The error message in the log:
~~~
2023/05/02 08:36:30 .../api/v1/repo/fork.go:147:CreateFork() [E]
[6450cb8e-113] ForkRepository: repository is already forked by user
[uname: ...., repo path: .../..., fork path: .../...]
~~~

The service that is used for forking returns a custom error message
which is not checked against.

About the order of options:
The case that the fork already exists should be more common, followed by
the case that a repo with the same name already exists for other
reasons. The case that the global repo limit is hit is probably not the
likeliest.

Co-authored-by: Otto Richter <otto@codeberg.org>
Co-authored-by: Giteabot <teabot@gitea.io>
2023-05-02 20:26:38 -04:00
..
api Fix api error message if fork exists (#24487) 2023-05-02 20:26:38 -04:00
common Refactor "route" related code, fix Safari cookie bug (#24330) 2023-04-27 02:06:45 -04:00
install Use globally shared HTMLRender (#24436) 2023-04-30 08:22:23 -04:00
private Refactor web route (#24080) 2023-04-20 14:49:06 -04:00
utils Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
web Add Debian package registry (#24426) 2023-05-02 12:31:35 -04:00
init.go Use globally shared HTMLRender (#24436) 2023-04-30 08:22:23 -04:00