Template
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo synced 2024-11-27 12:16:10 +01:00
forgejo/web_src/js/markup
silverwind dcde4701a5
Fix math and mermaid rendering bugs (#24049)
1. Fix multiple error display for math and mermaid:


![err](https://user-images.githubusercontent.com/115237/231126411-8a21a777-cd53-4b7e-ac67-5332623106e8.gif)

2. Fix height calculation of certain mermaid diagrams by reading the
iframe inner height from it's document instead of parsing it from SVG:

Before:
<img width="866" alt="Screenshot 2023-04-11 at 11 56 27"
src="https://user-images.githubusercontent.com/115237/231126480-b194e02b-ea8c-4ddf-8c79-50c525815d92.png">

After:
<img width="855" alt="Screenshot 2023-04-11 at 11 56 35"
src="https://user-images.githubusercontent.com/115237/231126494-5fe86a48-8d21-455a-8b95-79b6ee27a16f.png">

3. Refactor error handling to a common function
4. Rename to `renderAsciicast` for consistency
5. Improve mermaid loading sequence

Note: I did try `securityLevel: 'sandbox'` to make mermaid output a
iframe directly, but that showed a bug in mermaid where the iframe style
height was set incorrectly. Opened
https://github.com/mermaid-js/mermaid/issues/4289 for this.

---------

Co-authored-by: Giteabot <teabot@gitea.io>
2023-04-17 12:10:22 +02:00
..
anchors.js Fix markdown anchor re-clicking (#21931) 2022-11-26 19:15:44 +08:00
asciicast.js Fix math and mermaid rendering bugs (#24049) 2023-04-17 12:10:22 +02:00
codecopy.js Add Mermaid copy button, avoid unnecessary tooltip hide (#22225) 2022-12-25 18:17:48 +01:00
common.js Fix math and mermaid rendering bugs (#24049) 2023-04-17 12:10:22 +02:00
content.js Fix math and mermaid rendering bugs (#24049) 2023-04-17 12:10:22 +02:00
math.js Fix math and mermaid rendering bugs (#24049) 2023-04-17 12:10:22 +02:00
mermaid.js Fix math and mermaid rendering bugs (#24049) 2023-04-17 12:10:22 +02:00
tasklist.js Use explicit jQuery import, remove unused eslint globals (#18435) 2022-01-28 21:00:11 +00:00