mirror of
https://codeberg.org/forgejo/forgejo
synced 2024-11-29 13:16:10 +01:00
38c3cc4eb7
meilisearch does not have an search option to contorl fuzzynes per query right now: - https://github.com/meilisearch/meilisearch/issues/1192 - https://github.com/orgs/meilisearch/discussions/377 - https://github.com/meilisearch/meilisearch/discussions/1096 so we have to create a workaround by post-filter the search result in gitea until this is addressed. For future works I added an option in backend only atm, to enable fuzzynes for issue indexer too. And also refactored the code so the fuzzy option is equal in logic to code indexer --- *Sponsored by Kithara Software GmbH* Conflicts: routers/web/repo/search.go trivial context confict s/isMatch/isFuzzy/
97 lines
2.5 KiB
Go
97 lines
2.5 KiB
Go
// Copyright 2023 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package meilisearch
|
|
|
|
import (
|
|
"fmt"
|
|
"net/http"
|
|
"os"
|
|
"testing"
|
|
"time"
|
|
|
|
"code.gitea.io/gitea/modules/indexer/issues/internal"
|
|
"code.gitea.io/gitea/modules/indexer/issues/internal/tests"
|
|
|
|
"github.com/meilisearch/meilisearch-go"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestMeilisearchIndexer(t *testing.T) {
|
|
t.Skip("meilisearch not found in Forgejo test yet")
|
|
// The meilisearch instance started by pull-db-tests.yml > test-unit > services > meilisearch
|
|
url := "http://meilisearch:7700"
|
|
key := "" // auth has been disabled in test environment
|
|
|
|
if os.Getenv("CI") == "" {
|
|
// Make it possible to run tests against a local meilisearch instance
|
|
url = os.Getenv("TEST_MEILISEARCH_URL")
|
|
if url == "" {
|
|
t.Skip("TEST_MEILISEARCH_URL not set and not running in CI")
|
|
return
|
|
}
|
|
key = os.Getenv("TEST_MEILISEARCH_KEY")
|
|
}
|
|
|
|
ok := false
|
|
for i := 0; i < 60; i++ {
|
|
resp, err := http.Get(url)
|
|
if err == nil && resp.StatusCode == http.StatusOK {
|
|
ok = true
|
|
break
|
|
}
|
|
t.Logf("Waiting for meilisearch to be up: %v", err)
|
|
time.Sleep(time.Second)
|
|
}
|
|
if !ok {
|
|
t.Fatalf("Failed to wait for meilisearch to be up")
|
|
return
|
|
}
|
|
|
|
indexer := NewIndexer(url, key, fmt.Sprintf("test_meilisearch_indexer_%d", time.Now().Unix()))
|
|
defer indexer.Close()
|
|
|
|
tests.TestIndexer(t, indexer)
|
|
}
|
|
|
|
func TestNonFuzzyWorkaround(t *testing.T) {
|
|
// get unexpected return
|
|
_, err := nonFuzzyWorkaround(&meilisearch.SearchResponse{
|
|
Hits: []any{"aa", "bb", "cc", "dd"},
|
|
}, "bowling", false)
|
|
assert.ErrorIs(t, err, ErrMalformedResponse)
|
|
|
|
validResponse := &meilisearch.SearchResponse{
|
|
Hits: []any{
|
|
map[string]any{
|
|
"id": float64(11),
|
|
"title": "a title",
|
|
"content": "issue body with no match",
|
|
"comments": []any{"hey whats up?", "I'm currently bowling", "nice"},
|
|
},
|
|
map[string]any{
|
|
"id": float64(22),
|
|
"title": "Bowling as title",
|
|
"content": "",
|
|
"comments": []any{},
|
|
},
|
|
map[string]any{
|
|
"id": float64(33),
|
|
"title": "Bowl-ing as fuzzy match",
|
|
"content": "",
|
|
"comments": []any{},
|
|
},
|
|
},
|
|
}
|
|
|
|
// nonFuzzy
|
|
hits, err := nonFuzzyWorkaround(validResponse, "bowling", false)
|
|
assert.NoError(t, err)
|
|
assert.EqualValues(t, []internal.Match{{ID: 11}, {ID: 22}}, hits)
|
|
|
|
// fuzzy
|
|
hits, err = nonFuzzyWorkaround(validResponse, "bowling", true)
|
|
assert.NoError(t, err)
|
|
assert.EqualValues(t, []internal.Match{{ID: 11}, {ID: 22}, {ID: 33}}, hits)
|
|
}
|