Template
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo synced 2024-11-25 19:26:09 +01:00
forgejo/release-notes/8.0.0
Victoria Nadasdi df0d1a2134 feat: parse prefix from redis URI for queues (#3836)
For security reasons, scoping access to a redis server via ACL rules is
a good practice. Some parts of the codebase handles prefix like cache[^1]
and session[^2], but the queue module doesn't.

This patch adds this missing functionality to the queue module.

Note about relevant test:
I tried to keep the PR as small as possible (and reasonable), and not
change how the test runs. Updated the existing test to use the same
redis address and basically duplicated the test with the extra flag. It
does NOT test if the keys are correct, it ensures only it works as
expected. To make assertions about the keys, the whole test has to be
updated as the general wrapper doesn't allow the main test to check
anything provider (redis) specific property. That's not something I
wanted to take on now.

[^1]: e4c3c039be/modules/cache/cache_redis.go (L139-L150)
[^2]: e4c3c039be/modules/session/redis.go (L122-L129)

Signed-off-by: Victoria Nadasdi <victoria@efertone.me>

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3836
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Co-authored-by: Victoria Nadasdi <victoria@efertone.me>
Co-committed-by: Victoria Nadasdi <victoria@efertone.me>
2024-05-20 14:10:54 +00:00
..
feat feat: parse prefix from redis URI for queues (#3836) 2024-05-20 14:10:54 +00:00
fix badges: Relax the default workflow badge conditions 2024-05-20 11:20:11 +02:00
3139.md Add release note for #3139 2024-04-28 22:44:59 +02:00
3285.md Add a release note for #3285 2024-05-10 09:32:07 +02:00
3383.md Release notes for Limit database max connections by default 2024-04-27 22:03:25 +02:00
3414.md ldap: default domain name (#3414) 2024-04-26 22:38:58 +00:00
3572.md FIX gogs migration if gogs is hosted at a subpath (#3572) 2024-05-01 16:28:44 +00:00
3583.md Fix inconsistent required field (#3583) 2024-05-01 18:29:42 +00:00
3608.md [THEME] fix text selection color 2024-05-02 21:31:03 +05:00
3671.md fix(security): CVE-2024-24788 malformed DNS message 2024-05-08 14:25:08 +02:00
3724.md Update module github.com/caddyserver/certmagic to v0.21.0 (#3724) 2024-05-12 14:56:39 +00:00
3811.md Add minimal implementation for RubyGems compact index API. (#3811) 2024-05-19 23:30:41 +00:00
3830.md fix(actions): prevent deleted records' UUID from colliding with new records (#3830) 2024-05-19 10:46:15 +00:00