Template
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo synced 2024-11-24 10:46:10 +01:00
forgejo/modules/context
Lunny Xiao 900e158064
refactor auth interface to return error when verify failure (#22119) (#22259)
backport #22119

This PR changed the Auth interface signature from `Verify(http
*http.Request, w http.ResponseWriter, store DataStore, sess
SessionStore) *user_model.User`
to 
`Verify(http *http.Request, w http.ResponseWriter, store DataStore, sess
SessionStore) (*user_model.User, error)`.

There is a new return argument `error` which means the verification
condition matched but verify process failed, we should stop the auth
process.

Before this PR, when return a `nil` user, we don't know the reason why
it returned `nil`. If the match condition is not satisfied or it
verified failure? For these two different results, we should have
different handler. If the match condition is not satisfied, we should
try next auth method and if there is no more auth method, it's an
anonymous user. If the condition matched but verify failed, the auth
process should be stop and return immediately.

This will fix #20563

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: Jason Song <i@wolfogre.com>
2022-12-29 13:50:09 +08:00
..
access_log.go Pass down SignedUserName down to AccessLogger context (#16605) 2021-08-04 13:26:30 -04:00
api.go refactor auth interface to return error when verify failure (#22119) (#22259) 2022-12-29 13:50:09 +08:00
api_org.go Move organization related structs into sub package (#18518) 2022-03-29 14:29:02 +08:00
api_test.go format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
auth.go Respond with a 401 on git push when password isn't changed yet (#20026) 2022-06-19 20:23:00 +01:00
captcha.go format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
context.go refactor auth interface to return error when verify failure (#22119) (#22259) 2022-12-29 13:50:09 +08:00
csrf.go Refactor CSRF protection modules, make sure CSRF tokens can be up-to-date. (#19337) 2022-04-08 13:21:05 +08:00
form.go Add config options to hide issue events (#17414) 2022-01-21 18:59:26 +01:00
org.go Add user/organization code search (#19977) 2022-10-11 00:12:03 +01:00
package.go Fix package access for admins and inactive users (#21580) 2022-10-24 22:23:25 +03:00
pagination.go Remove tab/TabName usage where it's not needed (#19973) 2022-06-15 23:05:32 +08:00
permission.go Move access and repo permission to models/perm/access (#19350) 2022-05-11 12:09:36 +02:00
private.go Add more linters to improve code readability (#19989) 2022-06-20 12:02:49 +02:00
repo.go Use complete SHA to create and query commit status (#22244) (#22257) 2022-12-28 11:03:21 +01:00
response.go format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
utils.go Add more linters to improve code readability (#19989) 2022-06-20 12:02:49 +02:00
xsrf.go Refactor CSRF protection modules, make sure CSRF tokens can be up-to-date. (#19337) 2022-04-08 13:21:05 +08:00
xsrf_test.go Refactor CSRF protection modules, make sure CSRF tokens can be up-to-date. (#19337) 2022-04-08 13:21:05 +08:00