mirror of
https://codeberg.org/forgejo/forgejo
synced 2024-12-01 06:16:09 +01:00
5b1990b3b2
Replace #32001. To prevent the context cache from being misused for long-term work (which would result in using invalid cache without awareness), the context cache is designed to exist for a maximum of 10 seconds. This leads to many false reports, especially in the case of slow SQL. This PR increases it to 5 minutes to reduce false reports. 5 minutes is not a very safe value, as a lot of changes may have occurred within that time frame. However, as far as I know, there has not been a case of misuse of context cache discovered so far, so I think 5 minutes should be OK. Please note that after this PR, if warning logs are found again, it should get attention, at that time it can be almost 100% certain that it is a misuse. (cherry picked from commit a323a82ec4bde6ae39b97200439829bf67c0d31e)
80 lines
1.9 KiB
Go
80 lines
1.9 KiB
Go
// Copyright 2022 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package cache
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestWithCacheContext(t *testing.T) {
|
|
ctx := WithCacheContext(context.Background())
|
|
|
|
v := GetContextData(ctx, "empty_field", "my_config1")
|
|
assert.Nil(t, v)
|
|
|
|
const field = "system_setting"
|
|
v = GetContextData(ctx, field, "my_config1")
|
|
assert.Nil(t, v)
|
|
SetContextData(ctx, field, "my_config1", 1)
|
|
v = GetContextData(ctx, field, "my_config1")
|
|
assert.NotNil(t, v)
|
|
assert.EqualValues(t, 1, v.(int))
|
|
|
|
RemoveContextData(ctx, field, "my_config1")
|
|
RemoveContextData(ctx, field, "my_config2") // remove a non-exist key
|
|
|
|
v = GetContextData(ctx, field, "my_config1")
|
|
assert.Nil(t, v)
|
|
|
|
vInt, err := GetWithContextCache(ctx, field, "my_config1", func() (int, error) {
|
|
return 1, nil
|
|
})
|
|
require.NoError(t, err)
|
|
assert.EqualValues(t, 1, vInt)
|
|
|
|
v = GetContextData(ctx, field, "my_config1")
|
|
assert.EqualValues(t, 1, v)
|
|
|
|
now := timeNow
|
|
defer func() {
|
|
timeNow = now
|
|
}()
|
|
timeNow = func() time.Time {
|
|
return now().Add(5 * time.Minute)
|
|
}
|
|
v = GetContextData(ctx, field, "my_config1")
|
|
assert.Nil(t, v)
|
|
}
|
|
|
|
func TestWithNoCacheContext(t *testing.T) {
|
|
ctx := context.Background()
|
|
|
|
const field = "system_setting"
|
|
|
|
v := GetContextData(ctx, field, "my_config1")
|
|
assert.Nil(t, v)
|
|
SetContextData(ctx, field, "my_config1", 1)
|
|
v = GetContextData(ctx, field, "my_config1")
|
|
assert.Nil(t, v) // still no cache
|
|
|
|
ctx = WithCacheContext(ctx)
|
|
v = GetContextData(ctx, field, "my_config1")
|
|
assert.Nil(t, v)
|
|
SetContextData(ctx, field, "my_config1", 1)
|
|
v = GetContextData(ctx, field, "my_config1")
|
|
assert.NotNil(t, v)
|
|
|
|
ctx = WithNoCacheContext(ctx)
|
|
v = GetContextData(ctx, field, "my_config1")
|
|
assert.Nil(t, v)
|
|
SetContextData(ctx, field, "my_config1", 1)
|
|
v = GetContextData(ctx, field, "my_config1")
|
|
assert.Nil(t, v) // still no cache
|
|
}
|