mirror of
https://codeberg.org/forgejo/forgejo
synced 2024-11-30 05:46:09 +01:00
4a20eadfd7
Unfortunately #17643 prevented all propagation of ErrDependenciesLeft meaning that dependency errors that prevent closing of issues get swallowed. This PR restores propagation of the error but instead swallows the error in the places where it needs to be swallowed. Fix #18223 Signed-off-by: Andrew Thornton <art27@cantab.net>
37 lines
1 KiB
Go
37 lines
1 KiB
Go
// Copyright 2019 The Gitea Authors. All rights reserved.
|
|
// Use of this source code is governed by a MIT-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package issue
|
|
|
|
import (
|
|
"code.gitea.io/gitea/models"
|
|
"code.gitea.io/gitea/models/db"
|
|
user_model "code.gitea.io/gitea/models/user"
|
|
"code.gitea.io/gitea/modules/log"
|
|
"code.gitea.io/gitea/modules/notification"
|
|
)
|
|
|
|
// ChangeStatus changes issue status to open or closed.
|
|
func ChangeStatus(issue *models.Issue, doer *user_model.User, closed bool) error {
|
|
comment, err := issue.ChangeStatus(doer, closed)
|
|
if err != nil {
|
|
if models.IsErrDependenciesLeft(err) && closed {
|
|
if err := models.FinishIssueStopwatchIfPossible(db.DefaultContext, doer, issue); err != nil {
|
|
log.Error("Unable to stop stopwatch for issue[%d]#%d: %v", issue.ID, issue.Index, err)
|
|
}
|
|
}
|
|
return err
|
|
}
|
|
|
|
if closed {
|
|
if err := models.FinishIssueStopwatchIfPossible(db.DefaultContext, doer, issue); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
notification.NotifyIssueChangeStatus(doer, issue, comment, closed)
|
|
|
|
return nil
|
|
}
|