mirror of
https://codeberg.org/forgejo/forgejo
synced 2024-11-24 10:46:10 +01:00
71aa64ae25
Backport #20967 Currently, it's impossible to connect to self-signed TLS encrypted redis instances. The problem lies in inproper error handling, when building redis tls options - only invalid booleans are allowed to be used in `tlsConfig` builder. The problem is, when `strconv.ParseBool(...)` returns error, it always defaults to false - meaning it's impossible to set `tlsOptions.InsecureSkipVerify` to true. Fixes #19213 Co-authored-by: Igor Rzegocki <ajgon@users.noreply.github.com>
83 lines
1.8 KiB
Go
83 lines
1.8 KiB
Go
// Copyright 2022 The Gitea Authors. All rights reserved.
|
|
// Use of this source code is governed by a MIT-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package nosql
|
|
|
|
import (
|
|
"net/url"
|
|
"testing"
|
|
)
|
|
|
|
func TestRedisUsernameOpt(t *testing.T) {
|
|
uri, _ := url.Parse("redis://redis:password@myredis/0")
|
|
opts := getRedisOptions(uri)
|
|
|
|
if opts.Username != "redis" {
|
|
t.Fail()
|
|
}
|
|
}
|
|
|
|
func TestRedisPasswordOpt(t *testing.T) {
|
|
uri, _ := url.Parse("redis://redis:password@myredis/0")
|
|
opts := getRedisOptions(uri)
|
|
|
|
if opts.Password != "password" {
|
|
t.Fail()
|
|
}
|
|
}
|
|
|
|
func TestSkipVerifyOpt(t *testing.T) {
|
|
uri, _ := url.Parse("rediss://myredis/0?skipverify=true")
|
|
tlsConfig := getRedisTLSOptions(uri)
|
|
|
|
if !tlsConfig.InsecureSkipVerify {
|
|
t.Fail()
|
|
}
|
|
}
|
|
|
|
func TestInsecureSkipVerifyOpt(t *testing.T) {
|
|
uri, _ := url.Parse("rediss://myredis/0?insecureskipverify=true")
|
|
tlsConfig := getRedisTLSOptions(uri)
|
|
|
|
if !tlsConfig.InsecureSkipVerify {
|
|
t.Fail()
|
|
}
|
|
}
|
|
|
|
func TestRedisSentinelUsernameOpt(t *testing.T) {
|
|
uri, _ := url.Parse("redis+sentinel://redis:password@myredis/0?sentinelusername=suser&sentinelpassword=spass")
|
|
opts := getRedisOptions(uri).Failover()
|
|
|
|
if opts.SentinelUsername != "suser" {
|
|
t.Fail()
|
|
}
|
|
}
|
|
|
|
func TestRedisSentinelPasswordOpt(t *testing.T) {
|
|
uri, _ := url.Parse("redis+sentinel://redis:password@myredis/0?sentinelusername=suser&sentinelpassword=spass")
|
|
opts := getRedisOptions(uri).Failover()
|
|
|
|
if opts.SentinelPassword != "spass" {
|
|
t.Fail()
|
|
}
|
|
}
|
|
|
|
func TestRedisDatabaseIndexTcp(t *testing.T) {
|
|
uri, _ := url.Parse("redis://redis:password@myredis/12")
|
|
opts := getRedisOptions(uri)
|
|
|
|
if opts.DB != 12 {
|
|
t.Fail()
|
|
}
|
|
}
|
|
|
|
func TestRedisDatabaseIndexUnix(t *testing.T) {
|
|
uri, _ := url.Parse("redis+socket:///var/run/redis.sock?database=12")
|
|
opts := getRedisOptions(uri)
|
|
|
|
if opts.DB != 12 {
|
|
t.Fail()
|
|
}
|
|
}
|