mirror of
https://codeberg.org/forgejo/forgejo
synced 2024-11-30 22:06:11 +01:00
138942c09e
- Go's deadcode eliminator is quite simple, if you put a public function in a package `aa/bb` that is used only by tests, it would still be built if package `aa/bb` was imported. This means that if such functions use libraries relevant only to tests that those libraries would still be be built and increase the binary size of a Go binary. - This is also the case with Forgejo, `models/migrations/base/tests.go` contained functions exclusively used by tests which (skipping some steps here) imports https://github.com/ClickHouse/clickhouse-go, which is 2MiB. The `code.gitea.io/gitea/models/migrations/base` package is imported by `cmd/doctor` and thus the code of the clickhouse library is also built and included in the Forgejo binary, although entirely unused and not reachable. - This patch moves the test-related functions to their own package, so Go's deadcode eliminator knows not to build the test-related functions and thus reduces the size of the Forgejo binary. - It is not possible to move this to a `_test.go` file because Go does not allow importing functions from such files, so any test helper function must be in a non-test package and file. - Reduction of size (built with `TAGS="sqlite sqlite_unlock_notify" make build`): - Before: 95912040 bytes (92M) - After: 92306888 bytes (89M)
89 lines
2.2 KiB
Go
89 lines
2.2 KiB
Go
// Copyright 2021 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package v1_14 //nolint
|
|
|
|
import (
|
|
"testing"
|
|
|
|
migration_tests "code.gitea.io/gitea/models/migrations/test"
|
|
"code.gitea.io/gitea/modules/timeutil"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func Test_DeleteOrphanedIssueLabels(t *testing.T) {
|
|
// Create the models used in the migration
|
|
type IssueLabel struct {
|
|
ID int64 `xorm:"pk autoincr"`
|
|
IssueID int64 `xorm:"UNIQUE(s)"`
|
|
LabelID int64 `xorm:"UNIQUE(s)"`
|
|
}
|
|
|
|
type Label struct {
|
|
ID int64 `xorm:"pk autoincr"`
|
|
RepoID int64 `xorm:"INDEX"`
|
|
OrgID int64 `xorm:"INDEX"`
|
|
Name string
|
|
Description string
|
|
Color string `xorm:"VARCHAR(7)"`
|
|
NumIssues int
|
|
NumClosedIssues int
|
|
CreatedUnix timeutil.TimeStamp `xorm:"INDEX created"`
|
|
UpdatedUnix timeutil.TimeStamp `xorm:"INDEX updated"`
|
|
}
|
|
|
|
// Prepare and load the testing database
|
|
x, deferable := migration_tests.PrepareTestEnv(t, 0, new(IssueLabel), new(Label))
|
|
if x == nil || t.Failed() {
|
|
defer deferable()
|
|
return
|
|
}
|
|
defer deferable()
|
|
|
|
var issueLabels []*IssueLabel
|
|
preMigration := map[int64]*IssueLabel{}
|
|
postMigration := map[int64]*IssueLabel{}
|
|
|
|
// Load issue labels that exist in the database pre-migration
|
|
if err := x.Find(&issueLabels); err != nil {
|
|
assert.NoError(t, err)
|
|
return
|
|
}
|
|
for _, issueLabel := range issueLabels {
|
|
preMigration[issueLabel.ID] = issueLabel
|
|
}
|
|
|
|
// Run the migration
|
|
if err := DeleteOrphanedIssueLabels(x); err != nil {
|
|
assert.NoError(t, err)
|
|
return
|
|
}
|
|
|
|
// Load the remaining issue-labels
|
|
issueLabels = issueLabels[:0]
|
|
if err := x.Find(&issueLabels); err != nil {
|
|
assert.NoError(t, err)
|
|
return
|
|
}
|
|
for _, issueLabel := range issueLabels {
|
|
postMigration[issueLabel.ID] = issueLabel
|
|
}
|
|
|
|
// Now test what is left
|
|
if _, ok := postMigration[2]; ok {
|
|
t.Errorf("Orphaned Label[2] survived the migration")
|
|
return
|
|
}
|
|
|
|
if _, ok := postMigration[5]; ok {
|
|
t.Errorf("Orphaned Label[5] survived the migration")
|
|
return
|
|
}
|
|
|
|
for id, post := range postMigration {
|
|
pre := preMigration[id]
|
|
assert.Equal(t, pre, post, "migration changed issueLabel %d", id)
|
|
}
|
|
}
|