mirror of
https://codeberg.org/forgejo/forgejo
synced 2024-11-28 04:36:11 +01:00
0d029ebe6d
When a logged in user with no repositories visits their dashboard, it will display a search box that lists their own repositories. This is served by the `repo.SearchRepos` handler, which in turn calls `commitstatus_service.FindReposLastestCommitStatuses()` with an empty repo list. That, in turn, will call `git_model.FindBranchesByRepoAndBranchName()`, with an empty map. With no map, `FindBranchesByRepoAndBranchName()` ends up querying the entire `branch` table, because no conditions were set up. Armed with a gazillion repo & commit shas, we return to `FindReposLastestCommitStatuses`, and promptly call `git_model.GetLatestCommitStatusForPairs`, which constructs a monstrous query with so many placeholders that the database tells us to go somewhere else, and flips us off. At least on instances the size of Codeberg. On smaller instances, it will eventually return, and throw away all the data, and return an empty set, having performed all this for naught. We fix this by short-circuiting `FindBranchesByRepoAndBranchName`, and returning fast if our inputs are empty. A test case is included. Fixes #3521. Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>
137 lines
3.6 KiB
Go
137 lines
3.6 KiB
Go
// Copyright 2023 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package git
|
|
|
|
import (
|
|
"context"
|
|
|
|
"code.gitea.io/gitea/models/db"
|
|
user_model "code.gitea.io/gitea/models/user"
|
|
"code.gitea.io/gitea/modules/container"
|
|
"code.gitea.io/gitea/modules/optional"
|
|
|
|
"xorm.io/builder"
|
|
)
|
|
|
|
type BranchList []*Branch
|
|
|
|
func (branches BranchList) LoadDeletedBy(ctx context.Context) error {
|
|
ids := container.FilterSlice(branches, func(branch *Branch) (int64, bool) {
|
|
return branch.DeletedByID, branch.IsDeleted
|
|
})
|
|
|
|
usersMap := make(map[int64]*user_model.User, len(ids))
|
|
if err := db.GetEngine(ctx).In("id", ids).Find(&usersMap); err != nil {
|
|
return err
|
|
}
|
|
for _, branch := range branches {
|
|
if !branch.IsDeleted {
|
|
continue
|
|
}
|
|
branch.DeletedBy = usersMap[branch.DeletedByID]
|
|
if branch.DeletedBy == nil {
|
|
branch.DeletedBy = user_model.NewGhostUser()
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (branches BranchList) LoadPusher(ctx context.Context) error {
|
|
ids := container.FilterSlice(branches, func(branch *Branch) (int64, bool) {
|
|
// pusher_id maybe zero because some branches are sync by backend with no pusher
|
|
return branch.PusherID, branch.PusherID > 0
|
|
})
|
|
|
|
usersMap := make(map[int64]*user_model.User, len(ids))
|
|
if err := db.GetEngine(ctx).In("id", ids).Find(&usersMap); err != nil {
|
|
return err
|
|
}
|
|
for _, branch := range branches {
|
|
if branch.PusherID <= 0 {
|
|
continue
|
|
}
|
|
branch.Pusher = usersMap[branch.PusherID]
|
|
if branch.Pusher == nil {
|
|
branch.Pusher = user_model.NewGhostUser()
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
type FindBranchOptions struct {
|
|
db.ListOptions
|
|
RepoID int64
|
|
ExcludeBranchNames []string
|
|
IsDeletedBranch optional.Option[bool]
|
|
OrderBy string
|
|
Keyword string
|
|
}
|
|
|
|
func (opts FindBranchOptions) ToConds() builder.Cond {
|
|
cond := builder.NewCond()
|
|
if opts.RepoID > 0 {
|
|
cond = cond.And(builder.Eq{"repo_id": opts.RepoID})
|
|
}
|
|
|
|
if len(opts.ExcludeBranchNames) > 0 {
|
|
cond = cond.And(builder.NotIn("name", opts.ExcludeBranchNames))
|
|
}
|
|
if opts.IsDeletedBranch.Has() {
|
|
cond = cond.And(builder.Eq{"is_deleted": opts.IsDeletedBranch.Value()})
|
|
}
|
|
if opts.Keyword != "" {
|
|
cond = cond.And(builder.Like{"name", opts.Keyword})
|
|
}
|
|
return cond
|
|
}
|
|
|
|
func (opts FindBranchOptions) ToOrders() string {
|
|
orderBy := opts.OrderBy
|
|
if opts.IsDeletedBranch.ValueOrDefault(true) { // if deleted branch included, put them at the end
|
|
if orderBy != "" {
|
|
orderBy += ", "
|
|
}
|
|
orderBy += "is_deleted ASC"
|
|
}
|
|
if orderBy == "" {
|
|
// the commit_time might be the same, so add the "name" to make sure the order is stable
|
|
return "commit_time DESC, name ASC"
|
|
}
|
|
|
|
return orderBy
|
|
}
|
|
|
|
func FindBranchNames(ctx context.Context, opts FindBranchOptions) ([]string, error) {
|
|
sess := db.GetEngine(ctx).Select("name").Where(opts.ToConds())
|
|
if opts.PageSize > 0 && !opts.IsListAll() {
|
|
sess = db.SetSessionPagination(sess, &opts.ListOptions)
|
|
}
|
|
|
|
var branches []string
|
|
if err := sess.Table("branch").OrderBy(opts.ToOrders()).Find(&branches); err != nil {
|
|
return nil, err
|
|
}
|
|
return branches, nil
|
|
}
|
|
|
|
func FindBranchesByRepoAndBranchName(ctx context.Context, repoBranches map[int64]string) (map[int64]string, error) {
|
|
if len(repoBranches) == 0 {
|
|
return nil, nil
|
|
}
|
|
cond := builder.NewCond()
|
|
for repoID, branchName := range repoBranches {
|
|
cond = cond.Or(builder.And(builder.Eq{"repo_id": repoID}, builder.Eq{"name": branchName}))
|
|
}
|
|
var branches []*Branch
|
|
if err := db.GetEngine(ctx).
|
|
Where(cond).Find(&branches); err != nil {
|
|
return nil, err
|
|
}
|
|
branchMap := make(map[int64]string, len(branches))
|
|
for _, branch := range branches {
|
|
branchMap[branch.RepoID] = branch.CommitID
|
|
}
|
|
return branchMap, nil
|
|
}
|