mirror of
https://codeberg.org/forgejo/forgejo
synced 2024-11-30 05:46:09 +01:00
86ace4b5c2
Fixes #22178 After this change upload versions with different semver metadata are treated as the same version and trigger a duplicated version error. Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
176 lines
5.4 KiB
Go
176 lines
5.4 KiB
Go
// Copyright 2021 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package nuget
|
|
|
|
import (
|
|
"archive/zip"
|
|
"bytes"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
const (
|
|
id = "System.Gitea"
|
|
semver = "1.0.1"
|
|
authors = "Gitea Authors"
|
|
projectURL = "https://gitea.io"
|
|
description = "Package Description"
|
|
releaseNotes = "Package Release Notes"
|
|
repositoryURL = "https://gitea.io/gitea/gitea"
|
|
targetFramework = ".NETStandard2.1"
|
|
dependencyID = "System.Text.Json"
|
|
dependencyVersion = "5.0.0"
|
|
)
|
|
|
|
const nuspecContent = `<?xml version="1.0" encoding="utf-8"?>
|
|
<package xmlns="http://schemas.microsoft.com/packaging/2013/05/nuspec.xsd">
|
|
<metadata>
|
|
<id>` + id + `</id>
|
|
<version>` + semver + `</version>
|
|
<authors>` + authors + `</authors>
|
|
<requireLicenseAcceptance>true</requireLicenseAcceptance>
|
|
<projectUrl>` + projectURL + `</projectUrl>
|
|
<description>` + description + `</description>
|
|
<releaseNotes>` + releaseNotes + `</releaseNotes>
|
|
<repository url="` + repositoryURL + `" />
|
|
<dependencies>
|
|
<group targetFramework="` + targetFramework + `">
|
|
<dependency id="` + dependencyID + `" version="` + dependencyVersion + `" exclude="Build,Analyzers" />
|
|
</group>
|
|
</dependencies>
|
|
</metadata>
|
|
</package>`
|
|
|
|
const symbolsNuspecContent = `<?xml version="1.0" encoding="utf-8"?>
|
|
<package xmlns="http://schemas.microsoft.com/packaging/2013/05/nuspec.xsd">
|
|
<metadata>
|
|
<id>` + id + `</id>
|
|
<version>` + semver + `</version>
|
|
<description>` + description + `</description>
|
|
<packageTypes>
|
|
<packageType name="SymbolsPackage" />
|
|
</packageTypes>
|
|
<dependencies>
|
|
<group targetFramework="` + targetFramework + `" />
|
|
</dependencies>
|
|
</metadata>
|
|
</package>`
|
|
|
|
func TestParsePackageMetaData(t *testing.T) {
|
|
createArchive := func(name, content string) []byte {
|
|
var buf bytes.Buffer
|
|
archive := zip.NewWriter(&buf)
|
|
w, _ := archive.Create(name)
|
|
w.Write([]byte(content))
|
|
archive.Close()
|
|
return buf.Bytes()
|
|
}
|
|
|
|
t.Run("MissingNuspecFile", func(t *testing.T) {
|
|
data := createArchive("dummy.txt", "")
|
|
|
|
np, err := ParsePackageMetaData(bytes.NewReader(data), int64(len(data)))
|
|
assert.Nil(t, np)
|
|
assert.ErrorIs(t, err, ErrMissingNuspecFile)
|
|
})
|
|
|
|
t.Run("MissingNuspecFileInRoot", func(t *testing.T) {
|
|
data := createArchive("sub/package.nuspec", "")
|
|
|
|
np, err := ParsePackageMetaData(bytes.NewReader(data), int64(len(data)))
|
|
assert.Nil(t, np)
|
|
assert.ErrorIs(t, err, ErrMissingNuspecFile)
|
|
})
|
|
|
|
t.Run("InvalidNuspecFile", func(t *testing.T) {
|
|
data := createArchive("package.nuspec", "")
|
|
|
|
np, err := ParsePackageMetaData(bytes.NewReader(data), int64(len(data)))
|
|
assert.Nil(t, np)
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("InvalidPackageId", func(t *testing.T) {
|
|
data := createArchive("package.nuspec", `<?xml version="1.0" encoding="utf-8"?>
|
|
<package xmlns="http://schemas.microsoft.com/packaging/2013/05/nuspec.xsd">
|
|
<metadata></metadata>
|
|
</package>`)
|
|
|
|
np, err := ParsePackageMetaData(bytes.NewReader(data), int64(len(data)))
|
|
assert.Nil(t, np)
|
|
assert.ErrorIs(t, err, ErrNuspecInvalidID)
|
|
})
|
|
|
|
t.Run("InvalidPackageVersion", func(t *testing.T) {
|
|
data := createArchive("package.nuspec", `<?xml version="1.0" encoding="utf-8"?>
|
|
<package xmlns="http://schemas.microsoft.com/packaging/2013/05/nuspec.xsd">
|
|
<metadata>
|
|
<id>`+id+`</id>
|
|
</metadata>
|
|
</package>`)
|
|
|
|
np, err := ParsePackageMetaData(bytes.NewReader(data), int64(len(data)))
|
|
assert.Nil(t, np)
|
|
assert.ErrorIs(t, err, ErrNuspecInvalidVersion)
|
|
})
|
|
|
|
t.Run("Valid", func(t *testing.T) {
|
|
data := createArchive("package.nuspec", nuspecContent)
|
|
|
|
np, err := ParsePackageMetaData(bytes.NewReader(data), int64(len(data)))
|
|
assert.NoError(t, err)
|
|
assert.NotNil(t, np)
|
|
})
|
|
}
|
|
|
|
func TestParseNuspecMetaData(t *testing.T) {
|
|
t.Run("Dependency Package", func(t *testing.T) {
|
|
np, err := ParseNuspecMetaData(strings.NewReader(nuspecContent))
|
|
assert.NoError(t, err)
|
|
assert.NotNil(t, np)
|
|
assert.Equal(t, DependencyPackage, np.PackageType)
|
|
|
|
assert.Equal(t, id, np.ID)
|
|
assert.Equal(t, semver, np.Version)
|
|
assert.Equal(t, authors, np.Metadata.Authors)
|
|
assert.Equal(t, projectURL, np.Metadata.ProjectURL)
|
|
assert.Equal(t, description, np.Metadata.Description)
|
|
assert.Equal(t, releaseNotes, np.Metadata.ReleaseNotes)
|
|
assert.Equal(t, repositoryURL, np.Metadata.RepositoryURL)
|
|
assert.Len(t, np.Metadata.Dependencies, 1)
|
|
assert.Contains(t, np.Metadata.Dependencies, targetFramework)
|
|
deps := np.Metadata.Dependencies[targetFramework]
|
|
assert.Len(t, deps, 1)
|
|
assert.Equal(t, dependencyID, deps[0].ID)
|
|
assert.Equal(t, dependencyVersion, deps[0].Version)
|
|
|
|
t.Run("NormalizedVersion", func(t *testing.T) {
|
|
np, err := ParseNuspecMetaData(strings.NewReader(`<?xml version="1.0" encoding="utf-8"?>
|
|
<package xmlns="http://schemas.microsoft.com/packaging/2013/05/nuspec.xsd">
|
|
<metadata>
|
|
<id>test</id>
|
|
<version>1.04.5.2.5-rc.1+metadata</version>
|
|
</metadata>
|
|
</package>`))
|
|
assert.NoError(t, err)
|
|
assert.NotNil(t, np)
|
|
assert.Equal(t, "1.4.5.2-rc.1", np.Version)
|
|
})
|
|
})
|
|
|
|
t.Run("Symbols Package", func(t *testing.T) {
|
|
np, err := ParseNuspecMetaData(strings.NewReader(symbolsNuspecContent))
|
|
assert.NoError(t, err)
|
|
assert.NotNil(t, np)
|
|
assert.Equal(t, SymbolsPackage, np.PackageType)
|
|
|
|
assert.Equal(t, id, np.ID)
|
|
assert.Equal(t, semver, np.Version)
|
|
assert.Equal(t, description, np.Metadata.Description)
|
|
assert.Empty(t, np.Metadata.Dependencies)
|
|
})
|
|
}
|