Template
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo synced 2024-12-05 02:54:46 +01:00
forgejo/templates/repo
zeripath 72524adf3f
Ensure that plain files are rendered correctly even when containing ambiguous characters (#22017) (#22160)
Backport #22017

As recognised in #21841 the rendering of plain text files is somewhat
incorrect when there are ambiguous characters as the html code is double
escaped. In fact there are several more problems here.

We have a residual isRenderedHTML which is actually simply escaping the
file - not rendering it. This is badly named and gives the wrong
impression.

There is also unusual behaviour whether the file is called a Readme or
not and there is no way to get to the source code if the file is called
README.

In reality what should happen is different depending on whether the file
is being rendered a README at the bottom of the directory view or not.

1. If it is rendered as a README on a directory - it should simply be
escaped and rendered as `<pre>` text.
2. If it is rendered as a file then it should be rendered as source
code.

This PR therefore does:
1. Rename IsRenderedHTML to IsPlainText
2. Readme files rendered at the bottom of the directory are rendered
without line numbers
3. Otherwise plain text files are rendered as source code.

Replace #21841

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2022-12-19 23:51:21 +08:00
..
branch Fix button in branch list, avoid unexpected page jump before restore branch actually done (#21562) (#21928) 2022-11-25 00:02:33 +08:00
diff Color and Style enhancements (#21784, #21799) (#21868) 2022-11-20 10:47:02 +00:00
editor Make sure fmt catches all templates (#20979) 2022-08-31 23:58:54 +08:00
find Refactor i18n to locale (#20153) 2022-06-27 15:58:46 -05:00
graph Make sure fmt catches all templates (#20979) 2022-08-31 23:58:54 +08:00
issue Color and Style enhancements (#21784, #21799) (#21868) 2022-11-20 10:47:02 +00:00
migrate Make sure fmt catches all templates (#20979) 2022-08-31 23:58:54 +08:00
projects Make sure fmt catches all templates (#20979) 2022-08-31 23:58:54 +08:00
pulls Revert increased width on pull pages (#21470) 2022-10-19 15:48:29 +01:00
release Tag list should include draft releases with existing tags (#21263) 2022-10-03 20:05:53 +08:00
settings Ensure that plain files are rendered correctly even when containing ambiguous characters (#22017) (#22160) 2022-12-19 23:51:21 +08:00
wiki Webhook for Wiki changes (#20219) 2022-09-04 20:54:23 +01:00
activity.tmpl Respect user's locale when rendering the date range in the repo activity page (#21410) 2022-10-13 00:14:14 +03:00
blame.tmpl Switch Unicode Escaping to a VSCode-like system (#19990) 2022-08-13 19:32:34 +01:00
branch_dropdown.tmpl Fix branch dropdown shifting on page load (#21428) 2022-10-19 13:39:55 +08:00
clone_buttons.tmpl Rework repo buttons (#20602) 2022-08-08 02:15:11 +03:00
clone_script.tmpl Make the vscode clone link respect transport protocol (#20557) 2022-09-09 02:38:51 -04:00
commit_page.tmpl Revert increased width on pull pages (#21470) 2022-10-19 15:48:29 +01:00
commit_status.tmpl Change commit status icons to SVG (#20736) 2022-08-09 23:55:29 +02:00
commit_statuses.tmpl Improve commit status icons (#21124) 2022-09-09 17:03:18 -04:00
commits.tmpl Rework repo buttons (#20602) 2022-08-08 02:15:11 +03:00
commits_list.tmpl Change commits-table column width (#21564) 2022-10-25 18:00:37 +01:00
commits_list_small.tmpl Add whitespace removal inside template curly brackes (#20853) 2022-08-25 17:55:52 -04:00
commits_table.tmpl Add whitespace removal inside template curly brackes (#20853) 2022-08-25 17:55:52 -04:00
create.tmpl Remove cancel button in repo creation page (#21381) 2022-10-11 22:47:35 +08:00
empty.tmpl Add default value for clone URLs (#20600) 2022-08-02 10:52:05 +08:00
forks.tmpl Add whitespace removal inside template curly brackes (#20853) 2022-08-25 17:55:52 -04:00
graph.tmpl Add whitespace removal inside template curly brackes (#20853) 2022-08-25 17:55:52 -04:00
header.tmpl Add whitespace removal inside template curly brackes (#20853) 2022-08-25 17:55:52 -04:00
home.tmpl Expand "Go to File" button again, fix 'Add File' margin (#21543) 2022-10-24 02:23:04 +01:00
icon.tmpl Do not display org avatar near icon for internal repos (#13957) 2020-12-13 16:51:15 -05:00
packages.tmpl Add Package Registry (#16510) 2022-03-30 16:42:47 +08:00
search.tmpl Add user/organization code search (#19977) 2022-10-11 00:12:03 +01:00
shabox_badge.tmpl Refactor i18n to locale (#20153) 2022-06-27 15:58:46 -05:00
sub_menu.tmpl Fix #21406: Hide repo information from file view/blame mode (#21420) 2022-10-13 11:31:10 +03:00
unicode_escape_prompt.tmpl Switch Unicode Escaping to a VSCode-like system (#19990) 2022-08-13 19:32:34 +01:00
upload.tmpl Refactor i18n to locale (#20153) 2022-06-27 15:58:46 -05:00
user_cards.tmpl Localize all timestamps (#21440) 2022-10-17 12:08:21 +08:00
view_file.tmpl Ensure that plain files are rendered correctly even when containing ambiguous characters (#22017) (#22160) 2022-12-19 23:51:21 +08:00
view_list.tmpl Add whitespace removal inside template curly brackes (#20853) 2022-08-25 17:55:52 -04:00
watchers.tmpl Add class to page content to unify top margin (#13766) 2020-11-30 23:00:14 -05:00