mirror of
https://codeberg.org/forgejo/forgejo
synced 2024-11-30 22:06:11 +01:00
58d71cdd6f
Backport #27994 by @wxiaoguang To improve maintainability, this PR: 1. Rename `web_src/js/modules/aria` to `web_src/js/modules/fomantic` (the code there are all for aria of fomantic) 2. Move api/transition related code to `web_src/js/modules/fomantic/api.js` and `web_src/js/modules/fomantic/transition.js` No logic is changed. Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
41 lines
1.5 KiB
JavaScript
41 lines
1.5 KiB
JavaScript
import $ from 'jquery';
|
|
|
|
export function initFomanticApiPatch() {
|
|
//
|
|
// Fomantic API module has some very buggy behaviors:
|
|
//
|
|
// If encodeParameters=true, it calls `urlEncodedValue` to encode the parameter.
|
|
// However, `urlEncodedValue` just tries to "guess" whether the parameter is already encoded, by decoding the parameter and encoding it again.
|
|
//
|
|
// There are 2 problems:
|
|
// 1. It may guess wrong, and skip encoding a parameter which looks like encoded.
|
|
// 2. If the parameter can't be decoded, `decodeURIComponent` will throw an error, and the whole request will fail.
|
|
//
|
|
// This patch only fixes the second error behavior at the moment.
|
|
//
|
|
const patchKey = '_giteaFomanticApiPatch';
|
|
const oldApi = $.api;
|
|
$.api = $.fn.api = function(...args) {
|
|
const apiCall = oldApi.bind(this);
|
|
const ret = oldApi.apply(this, args);
|
|
|
|
if (typeof args[0] !== 'string') {
|
|
const internalGet = apiCall('internal', 'get');
|
|
if (!internalGet.urlEncodedValue[patchKey]) {
|
|
const oldUrlEncodedValue = internalGet.urlEncodedValue;
|
|
internalGet.urlEncodedValue = function (value) {
|
|
try {
|
|
return oldUrlEncodedValue(value);
|
|
} catch {
|
|
// if Fomantic API module's `urlEncodedValue` throws an error, we encode it by ourselves.
|
|
return encodeURIComponent(value);
|
|
}
|
|
};
|
|
internalGet.urlEncodedValue[patchKey] = true;
|
|
}
|
|
}
|
|
return ret;
|
|
};
|
|
$.api.settings = oldApi.settings;
|
|
}
|