.forgejo/workflows/testing.yml

@@ -56,13 +56,13 @@ jobs:
       image: 'code.forgejo.org/oci/node:20-bookworm'
     services:
       elasticsearch:
-        image: code.forgejo.org/oci/bitnami/elasticsearch:7
+        image: docker.io/bitnami/elasticsearch:7
         options: --tmpfs /bitnami/elasticsearch/data
         env:
           discovery.type: single-node
           ES_JAVA_OPTS: "-Xms512m -Xmx512m"
       minio:
-        image: code.forgejo.org/oci/bitnami/minio:2024.8.17
+        image: docker.io/bitnami/minio:2024.8.17
         options: >-
           --hostname gitea.minio --tmpfs /bitnami/minio/data
         env:
@@ -135,21 +135,20 @@ jobs:
     needs: [backend-checks, frontend-checks, test-unit]
     container:
       image: 'code.forgejo.org/oci/node:20-bookworm'
-    name: ${{ format('test-remote-cacher ({0})', matrix.cacher.name) }}
     strategy:
       matrix:
         cacher:
-          - name: redis
+          # redis
-            image: code.forgejo.org/oci/bitnami/redis:7.2
+          - image: docker.io/bitnami/redis:7.2
             options: --tmpfs /bitnami/redis/data
-          - name: redict
+          # redict
-            image: registry.redict.io/redict:7.3.0-scratch
+          - image: registry.redict.io/redict:7.3.0-scratch
             options: --tmpfs /data
-          - name: valkey
+          # valkey
-            image: code.forgejo.org/oci/bitnami/valkey:7.2
+          - image: docker.io/bitnami/valkey:7.2
             options: --tmpfs /bitnami/redis/data
-          - name: garnet
+          # garnet
-            image: ghcr.io/microsoft/garnet-alpine:1.0.14
+          - image: ghcr.io/microsoft/garnet-alpine:1.0.14
             options: --tmpfs /data
     services:
       cacher:
@@ -178,7 +177,7 @@ jobs:
       image: 'code.forgejo.org/oci/node:20-bookworm'
     services:
       mysql:
-        image: 'code.forgejo.org/oci/bitnami/mysql:8.4'
+        image: 'docker.io/bitnami/mysql:8.4'
         env:
           ALLOW_EMPTY_PASSWORD: yes
           MYSQL_DATABASE: testgitea
@@ -208,13 +207,13 @@ jobs:
       image: 'code.forgejo.org/oci/node:20-bookworm'
     services:
       minio:
-        image: code.forgejo.org/oci/bitnami/minio:2024.8.17
+        image: docker.io/bitnami/minio:2024.8.17
         env:
           MINIO_ROOT_USER: 123456
           MINIO_ROOT_PASSWORD: 12345678
         options: --tmpfs /bitnami/minio/data
       ldap:
-        image: code.forgejo.org/oci/test-openldap:latest
+        image: docker.io/gitea/test-openldap:latest
       pgsql:
         image: 'code.forgejo.org/oci/postgres:15'
         env:

RELEASE-NOTES.md

@@ -6,10 +6,6 @@ A [patch or minor release](https://semver.org/spec/v2.0.0.html) (e.g. upgrading
 
 The release notes of each release [are available in the corresponding milestone](https://codeberg.org/forgejo/forgejo/milestones), starting with [Forgejo 7.0.7](https://codeberg.org/forgejo/forgejo/milestone/7683) and [Forgejo 8.0.1](https://codeberg.org/forgejo/forgejo/milestone/7682).
 
-## 9.0.2
-
-The Forgejo v9.0.2 release notes are [available in the v9.0.2 milestone](https://codeberg.org/forgejo/forgejo/milestone/8610.
-
 ## 9.0.1
 
 The Forgejo v9.0.1 release notes are [available in the v9.0.1 milestone](https://codeberg.org/forgejo/forgejo/milestone/8544).
@@ -167,10 +163,6 @@ A [companion blog post](https://forgejo.org/2024-07-release-v8-0/) provides addi
   - [PR](https://codeberg.org/forgejo/forgejo/pulls/2937): <!--number 2937 --><!--number--><!--description -->31 March updates<!--description-->
 <!--end release-notes-assistant-->
 
-## 7.0.11
-
-The Forgejo v7.0.11 release notes are [available in the v7.0.11 milestone](https://codeberg.org/forgejo/forgejo/milestone/8609).
-
 ## 7.0.10
 
 The Forgejo v7.0.10 release notes are [available in the v7.0.10 milestone](https://codeberg.org/forgejo/forgejo/milestone/8286).

models/auth/auth_token.go

@@ -15,31 +15,12 @@ import (
 	"code.gitea.io/gitea/modules/util"
 )
 
-type AuthorizationPurpose string
-
-var (
-	// Used to store long term authorization tokens.
-	LongTermAuthorization AuthorizationPurpose = "long_term_authorization"
-
-	// Used to activate a user account.
-	UserActivation AuthorizationPurpose = "user_activation"
-
-	// Used to reset the password.
-	PasswordReset AuthorizationPurpose = "password_reset"
-)
-
-// Used to activate the specified email address for a user.
-func EmailActivation(email string) AuthorizationPurpose {
-	return AuthorizationPurpose("email_activation:" + email)
-}
-
 // AuthorizationToken represents a authorization token to a user.
 type AuthorizationToken struct {
 	ID              int64  `xorm:"pk autoincr"`
 	UID             int64  `xorm:"INDEX"`
 	LookupKey       string `xorm:"INDEX UNIQUE"`
 	HashedValidator string
-	Purpose         AuthorizationPurpose `xorm:"NOT NULL"`
 	Expiry          timeutil.TimeStamp
 }
 
@@ -60,7 +41,7 @@ func (authToken *AuthorizationToken) IsExpired() bool {
 // GenerateAuthToken generates a new authentication token for the given user.
 // It returns the lookup key and validator values that should be passed to the
 // user via a long-term cookie.
-func GenerateAuthToken(ctx context.Context, userID int64, expiry timeutil.TimeStamp, purpose AuthorizationPurpose) (lookupKey, validator string, err error) {
+func GenerateAuthToken(ctx context.Context, userID int64, expiry timeutil.TimeStamp) (lookupKey, validator string, err error) {
 	// Request 64 random bytes. The first 32 bytes will be used for the lookupKey
 	// and the other 32 bytes will be used for the validator.
 	rBytes, err := util.CryptoRandomBytes(64)
@@ -75,15 +56,14 @@ func GenerateAuthToken(ctx context.Context, userID int64, expiry timeutil.TimeSt
 		Expiry:          expiry,
 		LookupKey:       lookupKey,
 		HashedValidator: HashValidator(rBytes[32:]),
-		Purpose:         purpose,
 	})
 	return lookupKey, validator, err
 }
 
 // FindAuthToken will find a authorization token via the lookup key.
-func FindAuthToken(ctx context.Context, lookupKey string, purpose AuthorizationPurpose) (*AuthorizationToken, error) {
+func FindAuthToken(ctx context.Context, lookupKey string) (*AuthorizationToken, error) {
 	var authToken AuthorizationToken
-	has, err := db.GetEngine(ctx).Where("lookup_key = ? AND purpose = ?", lookupKey, purpose).Get(&authToken)
+	has, err := db.GetEngine(ctx).Where("lookup_key = ?", lookupKey).Get(&authToken)
 	if err != nil {
 		return nil, err
 	} else if !has {

models/forgejo_migrations/migrate.go

@@ -84,8 +84,6 @@ var migrations = []*Migration{
 	NewMigration("Add `legacy` to `web_authn_credential` table", AddLegacyToWebAuthnCredential),
 	// v23 -> v24
 	NewMigration("Add `delete_branch_after_merge` to `auto_merge` table", AddDeleteBranchAfterMergeToAutoMerge),
-	// v24 -> v25
-	NewMigration("Add `purpose` column to `forgejo_auth_token` table", AddPurposeToForgejoAuthToken),
 }
 
 // GetCurrentDBVersion returns the current Forgejo database version.

models/forgejo_migrations/v24.go

@@ -1,19 +0,0 @@
-// Copyright 2024 The Forgejo Authors. All rights reserved.
-// SPDX-License-Identifier: MIT
-
-package forgejo_migrations //nolint:revive
-
-import "xorm.io/xorm"
-
-func AddPurposeToForgejoAuthToken(x *xorm.Engine) error {
-	type ForgejoAuthToken struct {
-		ID      int64  `xorm:"pk autoincr"`
-		Purpose string `xorm:"NOT NULL"`
-	}
-	if err := x.Sync(new(ForgejoAuthToken)); err != nil {
-		return err
-	}
-
-	_, err := x.Exec("UPDATE `forgejo_auth_token` SET purpose = 'long_term_authorization' WHERE purpose = ''")
-	return err
-}

models/repo/TestSearchRepositoryIDsByCondition/repository.yml

@@ -1,30 +0,0 @@
--
-  id: 1001
-  owner_id: 33
-  owner_name: user33
-  lower_name: repo1001
-  name: repo1001
-  default_branch: main
-  num_watches: 0
-  num_stars: 0
-  num_forks: 0
-  num_issues: 0
-  num_closed_issues: 0
-  num_pulls: 0
-  num_closed_pulls: 0
-  num_milestones: 0
-  num_closed_milestones: 0
-  num_projects: 0
-  num_closed_projects: 0
-  is_private: false
-  is_empty: false
-  is_archived: false
-  is_mirror: false
-  status: 0
-  is_fork: false
-  fork_id: 0
-  is_template: false
-  template_id: 0
-  size: 0
-  is_fsck_enabled: true
-  close_issues_via_commit_in_any_branch: false

models/repo/fork.go

@@ -7,7 +7,6 @@ import (
 	"context"
 
 	"code.gitea.io/gitea/models/db"
-	"code.gitea.io/gitea/models/unit"
 	user_model "code.gitea.io/gitea/models/user"
 
 	"xorm.io/builder"
@@ -55,9 +54,9 @@ func GetUserFork(ctx context.Context, repoID, userID int64) (*Repository, error)
 	return &forkedRepo, nil
 }
 
-// GetForks returns all the forks of the repository that are visible to the user.
+// GetForks returns all the forks of the repository
-func GetForks(ctx context.Context, repo *Repository, user *user_model.User, listOptions db.ListOptions) ([]*Repository, int64, error) {
+func GetForks(ctx context.Context, repo *Repository, listOptions db.ListOptions) ([]*Repository, error) {
-	sess := db.GetEngine(ctx).Where(AccessibleRepositoryCondition(user, unit.TypeInvalid))
+	sess := db.GetEngine(ctx)
 
 	var forks []*Repository
 	if listOptions.Page == 0 {
@@ -67,8 +66,7 @@ func GetForks(ctx context.Context, repo *Repository, user *user_model.User, list
 		sess = db.SetSessionPagination(sess, &listOptions)
 	}
 
-	count, err := sess.FindAndCount(&forks, &Repository{ForkID: repo.ID})
+	return forks, sess.Find(&forks, &Repository{ForkID: repo.ID})
-	return forks, count, err
 }
 
 // IncrementRepoForkNum increment repository fork number

models/repo/repo_list.go

@@ -641,9 +641,12 @@ func AccessibleRepositoryCondition(user *user_model.User, unitType unit.Type) bu
 		// 1. Be able to see all non-private repositories that either:
 		cond = cond.Or(builder.And(
 			builder.Eq{"`repository`.is_private": false},
-			// 2. Aren't in an private organisation/user or limited organisation/user if the doer is not logged in.
+			// 2. Aren't in an private organisation or limited organisation if we're not logged in
 			builder.NotIn("`repository`.owner_id", builder.Select("id").From("`user`").Where(
-				builder.In("visibility", orgVisibilityLimit)))))
+				builder.And(
+					builder.Eq{"type": user_model.UserTypeOrganization},
+					builder.In("visibility", orgVisibilityLimit)),
+			))))
 	}
 
 	if user != nil {

models/repo/repo_list_test.go

@@ -4,18 +4,13 @@
 package repo_test
 
 import (
-	"path/filepath"
-	"slices"
 	"strings"
 	"testing"
 
 	"code.gitea.io/gitea/models/db"
 	repo_model "code.gitea.io/gitea/models/repo"
 	"code.gitea.io/gitea/models/unittest"
-	"code.gitea.io/gitea/models/user"
 	"code.gitea.io/gitea/modules/optional"
-	"code.gitea.io/gitea/modules/setting"
-	"code.gitea.io/gitea/modules/structs"
 
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
@@ -408,43 +403,3 @@ func TestSearchRepositoryByTopicName(t *testing.T) {
 		})
 	}
 }
-
-func TestSearchRepositoryIDsByCondition(t *testing.T) {
-	defer unittest.OverrideFixtures(
-		unittest.FixturesOptions{
-			Dir:  filepath.Join(setting.AppWorkPath, "models/fixtures/"),
-			Base: setting.AppWorkPath,
-			Dirs: []string{"models/repo/TestSearchRepositoryIDsByCondition/"},
-		},
-	)()
-	require.NoError(t, unittest.PrepareTestDatabase())
-	// Sanity check of the database
-	limitedUser := unittest.AssertExistsAndLoadBean(t, &user.User{ID: 33, Visibility: structs.VisibleTypeLimited})
-	unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1001, OwnerID: limitedUser.ID})
-
-	testCases := []struct {
-		user    *user.User
-		repoIDs []int64
-	}{
-		{
-			user:    nil,
-			repoIDs: []int64{1, 4, 8, 9, 10, 11, 12, 14, 17, 18, 21, 23, 25, 27, 29, 32, 33, 34, 35, 36, 37, 42, 44, 45, 46, 47, 48, 49, 50, 51, 53, 57, 58, 60, 61, 62, 1059},
-		},
-		{
-			user:    unittest.AssertExistsAndLoadBean(t, &user.User{ID: 4}),
-			repoIDs: []int64{1, 3, 4, 8, 9, 10, 11, 12, 14, 17, 18, 21, 23, 25, 27, 29, 32, 33, 34, 35, 36, 37, 38, 40, 42, 44, 45, 46, 47, 48, 49, 50, 51, 53, 57, 58, 60, 61, 62, 1001, 1059},
-		},
-		{
-			user:    unittest.AssertExistsAndLoadBean(t, &user.User{ID: 5}),
-			repoIDs: []int64{1, 4, 8, 9, 10, 11, 12, 14, 17, 18, 21, 23, 25, 27, 29, 32, 33, 34, 35, 36, 37, 38, 40, 42, 44, 45, 46, 47, 48, 49, 50, 51, 53, 57, 58, 60, 61, 62, 1001, 1059},
-		},
-	}
-
-	for _, testCase := range testCases {
-		repoIDs, err := repo_model.FindUserCodeAccessibleRepoIDs(db.DefaultContext, testCase.user)
-		require.NoError(t, err)
-
-		slices.Sort(repoIDs)
-		assert.EqualValues(t, testCase.repoIDs, repoIDs)
-	}
-}

models/user/email_address.go

@@ -8,8 +8,10 @@ import (
 	"context"
 	"fmt"
 	"strings"
+	"time"
 
 	"code.gitea.io/gitea/models/db"
+	"code.gitea.io/gitea/modules/base"
 	"code.gitea.io/gitea/modules/log"
 	"code.gitea.io/gitea/modules/optional"
 	"code.gitea.io/gitea/modules/setting"
@@ -244,6 +246,23 @@ func updateActivation(ctx context.Context, email *EmailAddress, activate bool) e
 	return UpdateUserCols(ctx, user, "rands")
 }
 
+// VerifyActiveEmailCode verifies active email code when active account
+func VerifyActiveEmailCode(ctx context.Context, code, email string) *EmailAddress {
+	if user := GetVerifyUser(ctx, code); user != nil {
+		// time limit code
+		prefix := code[:base.TimeLimitCodeLength]
+		data := fmt.Sprintf("%d%s%s%s%s", user.ID, email, user.LowerName, user.Passwd, user.Rands)
+
+		if base.VerifyTimeLimitCode(time.Now(), data, setting.Service.ActiveCodeLives, prefix) {
+			emailAddress := &EmailAddress{UID: user.ID, Email: email}
+			if has, _ := db.GetEngine(ctx).Get(emailAddress); has {
+				return emailAddress
+			}
+		}
+	}
+	return nil
+}
+
 // SearchEmailOrderBy is used to sort the results from SearchEmails()
 type SearchEmailOrderBy string
 

models/user/user.go

@@ -7,9 +7,7 @@ package user
 
 import (
 	"context"
-	"crypto/subtle"
 	"encoding/hex"
-	"errors"
 	"fmt"
 	"net/mail"
 	"net/url"
@@ -320,14 +318,15 @@ func (u *User) OrganisationLink() string {
 	return setting.AppSubURL + "/org/" + url.PathEscape(u.Name)
 }
 
-// GenerateEmailAuthorizationCode generates an activation code based for the user for the specified purpose.
+// GenerateEmailActivateCode generates an activate code based on user information and given e-mail.
-// The standard expiry is ActiveCodeLives minutes.
+func (u *User) GenerateEmailActivateCode(email string) string {
-func (u *User) GenerateEmailAuthorizationCode(ctx context.Context, purpose auth.AuthorizationPurpose) (string, error) {
+	code := base.CreateTimeLimitCode(
-	lookup, validator, err := auth.GenerateAuthToken(ctx, u.ID, timeutil.TimeStampNow().Add(int64(setting.Service.ActiveCodeLives)*60), purpose)
+		fmt.Sprintf("%d%s%s%s%s", u.ID, email, u.LowerName, u.Passwd, u.Rands),
-	if err != nil {
+		setting.Service.ActiveCodeLives, time.Now(), nil)
-		return "", err
+
-	}
+	// Add tail hex username
-	return lookup + ":" + validator, nil
+	code += hex.EncodeToString([]byte(u.LowerName))
+	return code
 }
 
 // GetUserFollowers returns range of user's followers.
@@ -839,50 +838,35 @@ func countUsers(ctx context.Context, opts *CountUserFilter) int64 {
 	return count
 }
 
-// VerifyUserActiveCode verifies that the code is valid for the given purpose for this user.
+// GetVerifyUser get user by verify code
-// If delete is specified, the token will be deleted.
+func GetVerifyUser(ctx context.Context, code string) (user *User) {
-func VerifyUserAuthorizationToken(ctx context.Context, code string, purpose auth.AuthorizationPurpose, delete bool) (*User, error) {
+	if len(code) <= base.TimeLimitCodeLength {
-	lookupKey, validator, found := strings.Cut(code, ":")
+		return nil
-	if !found {
-		return nil, nil
 	}
 
-	authToken, err := auth.FindAuthToken(ctx, lookupKey, purpose)
+	// use tail hex username query user
-	if err != nil {
+	hexStr := code[base.TimeLimitCodeLength:]
-		if errors.Is(err, util.ErrNotExist) {
+	if b, err := hex.DecodeString(hexStr); err == nil {
-			return nil, nil
+		if user, err = GetUserByName(ctx, string(b)); user != nil {
+			return user
 		}
-		return nil, err
+		log.Error("user.getVerifyUser: %v", err)
 	}
 
-	if authToken.IsExpired() {
+	return nil
-		return nil, auth.DeleteAuthToken(ctx, authToken)
+}
-	}
 
-	rawValidator, err := hex.DecodeString(validator)
+// VerifyUserActiveCode verifies active code when active account
-	if err != nil {
+func VerifyUserActiveCode(ctx context.Context, code string) (user *User) {
-		return nil, err
+	if user = GetVerifyUser(ctx, code); user != nil {
-	}
+		// time limit code
-
+		prefix := code[:base.TimeLimitCodeLength]
-	if subtle.ConstantTimeCompare([]byte(authToken.HashedValidator), []byte(auth.HashValidator(rawValidator))) == 0 {
+		data := fmt.Sprintf("%d%s%s%s%s", user.ID, user.Email, user.LowerName, user.Passwd, user.Rands)
-		return nil, errors.New("validator doesn't match")
+		if base.VerifyTimeLimitCode(time.Now(), data, setting.Service.ActiveCodeLives, prefix) {
-	}
+			return user
-
-	u, err := GetUserByID(ctx, authToken.UID)
-	if err != nil {
-		if IsErrUserNotExist(err) {
-			return nil, nil
-		}
-		return nil, err
-	}
-
-	if delete {
-		if err := auth.DeleteAuthToken(ctx, authToken); err != nil {
-			return nil, err
 		}
 	}
-
+	return nil
-	return u, nil
 }
 
 // ValidateUser check if user is valid to insert / update into database

models/user/user_test.go

@@ -7,7 +7,6 @@ package user_test
 import (
 	"context"
 	"crypto/rand"
-	"encoding/hex"
 	"fmt"
 	"strings"
 	"testing"
@@ -22,9 +21,7 @@ import (
 	"code.gitea.io/gitea/modules/optional"
 	"code.gitea.io/gitea/modules/setting"
 	"code.gitea.io/gitea/modules/structs"
-	"code.gitea.io/gitea/modules/test"
 	"code.gitea.io/gitea/modules/timeutil"
-	"code.gitea.io/gitea/modules/util"
 	"code.gitea.io/gitea/modules/validation"
 	"code.gitea.io/gitea/tests"
 
@@ -703,66 +700,3 @@ func TestDisabledUserFeatures(t *testing.T) {
 		assert.True(t, user_model.IsFeatureDisabledWithLoginType(user, f))
 	}
 }
-
-func TestGenerateEmailAuthorizationCode(t *testing.T) {
-	defer test.MockVariableValue(&setting.Service.ActiveCodeLives, 2)()
-	require.NoError(t, unittest.PrepareTestDatabase())
-
-	user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
-
-	code, err := user.GenerateEmailAuthorizationCode(db.DefaultContext, auth.UserActivation)
-	require.NoError(t, err)
-
-	lookupKey, validator, ok := strings.Cut(code, ":")
-	assert.True(t, ok)
-
-	rawValidator, err := hex.DecodeString(validator)
-	require.NoError(t, err)
-
-	authToken, err := auth.FindAuthToken(db.DefaultContext, lookupKey, auth.UserActivation)
-	require.NoError(t, err)
-	assert.False(t, authToken.IsExpired())
-	assert.EqualValues(t, authToken.HashedValidator, auth.HashValidator(rawValidator))
-
-	authToken.Expiry = authToken.Expiry.Add(-int64(setting.Service.ActiveCodeLives) * 60)
-	assert.True(t, authToken.IsExpired())
-}
-
-func TestVerifyUserAuthorizationToken(t *testing.T) {
-	defer test.MockVariableValue(&setting.Service.ActiveCodeLives, 2)()
-	require.NoError(t, unittest.PrepareTestDatabase())
-
-	user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
-
-	code, err := user.GenerateEmailAuthorizationCode(db.DefaultContext, auth.UserActivation)
-	require.NoError(t, err)
-
-	lookupKey, _, ok := strings.Cut(code, ":")
-	assert.True(t, ok)
-
-	t.Run("Wrong purpose", func(t *testing.T) {
-		u, err := user_model.VerifyUserAuthorizationToken(db.DefaultContext, code, auth.PasswordReset, false)
-		require.NoError(t, err)
-		assert.Nil(t, u)
-	})
-
-	t.Run("No delete", func(t *testing.T) {
-		u, err := user_model.VerifyUserAuthorizationToken(db.DefaultContext, code, auth.UserActivation, false)
-		require.NoError(t, err)
-		assert.EqualValues(t, user.ID, u.ID)
-
-		authToken, err := auth.FindAuthToken(db.DefaultContext, lookupKey, auth.UserActivation)
-		require.NoError(t, err)
-		assert.NotNil(t, authToken)
-	})
-
-	t.Run("Delete", func(t *testing.T) {
-		u, err := user_model.VerifyUserAuthorizationToken(db.DefaultContext, code, auth.UserActivation, true)
-		require.NoError(t, err)
-		assert.EqualValues(t, user.ID, u.ID)
-
-		authToken, err := auth.FindAuthToken(db.DefaultContext, lookupKey, auth.UserActivation)
-		require.ErrorIs(t, err, util.ErrNotExist)
-		assert.Nil(t, authToken)
-	})
-}

modules/base/tool.go

@@ -4,20 +4,26 @@
 package base
 
 import (
+	"crypto/hmac"
+	"crypto/sha1"
 	"crypto/sha256"
+	"crypto/subtle"
 	"encoding/base64"
 	"encoding/hex"
 	"errors"
 	"fmt"
+	"hash"
 	"os"
 	"path/filepath"
 	"runtime"
 	"strconv"
 	"strings"
+	"time"
 	"unicode/utf8"
 
 	"code.gitea.io/gitea/modules/git"
 	"code.gitea.io/gitea/modules/log"
+	"code.gitea.io/gitea/modules/setting"
 
 	"github.com/dustin/go-humanize"
 )
@@ -48,6 +54,66 @@ func BasicAuthDecode(encoded string) (string, string, error) {
 	return "", "", errors.New("invalid basic authentication")
 }
 
+// VerifyTimeLimitCode verify time limit code
+func VerifyTimeLimitCode(now time.Time, data string, minutes int, code string) bool {
+	if len(code) <= 18 {
+		return false
+	}
+
+	startTimeStr := code[:12]
+	aliveTimeStr := code[12:18]
+	aliveTime, _ := strconv.Atoi(aliveTimeStr) // no need to check err, if anything wrong, the following code check will fail soon
+
+	// check code
+	retCode := CreateTimeLimitCode(data, aliveTime, startTimeStr, nil)
+	if subtle.ConstantTimeCompare([]byte(retCode), []byte(code)) != 1 {
+		retCode = CreateTimeLimitCode(data, aliveTime, startTimeStr, sha1.New()) // TODO: this is only for the support of legacy codes, remove this in/after 1.23
+		if subtle.ConstantTimeCompare([]byte(retCode), []byte(code)) != 1 {
+			return false
+		}
+	}
+
+	// check time is expired or not: startTime <= now && now < startTime + minutes
+	startTime, _ := time.ParseInLocation("200601021504", startTimeStr, time.Local)
+	return (startTime.Before(now) || startTime.Equal(now)) && now.Before(startTime.Add(time.Minute*time.Duration(minutes)))
+}
+
+// TimeLimitCodeLength default value for time limit code
+const TimeLimitCodeLength = 12 + 6 + 40
+
+// CreateTimeLimitCode create a time-limited code.
+// Format: 12 length date time string + 6 minutes string (not used) + 40 hash string, some other code depends on this fixed length
+// If h is nil, then use the default hmac hash.
+func CreateTimeLimitCode[T time.Time | string](data string, minutes int, startTimeGeneric T, h hash.Hash) string {
+	const format = "200601021504"
+
+	var start time.Time
+	var startTimeAny any = startTimeGeneric
+	if t, ok := startTimeAny.(time.Time); ok {
+		start = t
+	} else {
+		var err error
+		start, err = time.ParseInLocation(format, startTimeAny.(string), time.Local)
+		if err != nil {
+			return "" // return an invalid code because the "parse" failed
+		}
+	}
+	startStr := start.Format(format)
+	end := start.Add(time.Minute * time.Duration(minutes))
+
+	if h == nil {
+		h = hmac.New(sha1.New, setting.GetGeneralTokenSigningSecret())
+	}
+	_, _ = fmt.Fprintf(h, "%s%s%s%s%d", data, hex.EncodeToString(setting.GetGeneralTokenSigningSecret()), startStr, end.Format(format), minutes)
+	encoded := hex.EncodeToString(h.Sum(nil))
+
+	code := fmt.Sprintf("%s%06d%s", startStr, minutes, encoded)
+	if len(code) != TimeLimitCodeLength {
+		panic("there is a hard requirement for the length of time-limited code") // it shouldn't happen
+	}
+	return code
+}
+
 // FileSize calculates the file size and generate user-friendly string.
 func FileSize(s int64) string {
 	return humanize.IBytes(uint64(s))

modules/base/tool_test.go

@@ -4,7 +4,13 @@
 package base
 
 import (
+	"crypto/sha1"
+	"fmt"
 	"testing"
+	"time"
+
+	"code.gitea.io/gitea/modules/setting"
+	"code.gitea.io/gitea/modules/test"
 
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
@@ -40,6 +46,57 @@ func TestBasicAuthDecode(t *testing.T) {
 	require.Error(t, err)
 }
 
+func TestVerifyTimeLimitCode(t *testing.T) {
+	defer test.MockVariableValue(&setting.InstallLock, true)()
+	initGeneralSecret := func(secret string) {
+		setting.InstallLock = true
+		setting.CfgProvider, _ = setting.NewConfigProviderFromData(fmt.Sprintf(`
+[oauth2]
+JWT_SECRET = %s
+`, secret))
+		setting.LoadCommonSettings()
+	}
+
+	initGeneralSecret("KZb_QLUd4fYVyxetjxC4eZkrBgWM2SndOOWDNtgUUko")
+	now := time.Now()
+
+	t.Run("TestGenericParameter", func(t *testing.T) {
+		time2000 := time.Date(2000, 1, 2, 3, 4, 5, 0, time.Local)
+		assert.Equal(t, "2000010203040000026fa5221b2731b7cf80b1b506f5e39e38c115fee5", CreateTimeLimitCode("test-sha1", 2, time2000, sha1.New()))
+		assert.Equal(t, "2000010203040000026fa5221b2731b7cf80b1b506f5e39e38c115fee5", CreateTimeLimitCode("test-sha1", 2, "200001020304", sha1.New()))
+		assert.Equal(t, "2000010203040000024842227a2f87041ff82025199c0187410a9297bf", CreateTimeLimitCode("test-hmac", 2, time2000, nil))
+		assert.Equal(t, "2000010203040000024842227a2f87041ff82025199c0187410a9297bf", CreateTimeLimitCode("test-hmac", 2, "200001020304", nil))
+	})
+
+	t.Run("TestInvalidCode", func(t *testing.T) {
+		assert.False(t, VerifyTimeLimitCode(now, "data", 2, ""))
+		assert.False(t, VerifyTimeLimitCode(now, "data", 2, "invalid code"))
+	})
+
+	t.Run("TestCreateAndVerify", func(t *testing.T) {
+		code := CreateTimeLimitCode("data", 2, now, nil)
+		assert.False(t, VerifyTimeLimitCode(now.Add(-time.Minute), "data", 2, code)) // not started yet
+		assert.True(t, VerifyTimeLimitCode(now, "data", 2, code))
+		assert.True(t, VerifyTimeLimitCode(now.Add(time.Minute), "data", 2, code))
+		assert.False(t, VerifyTimeLimitCode(now.Add(time.Minute), "DATA", 2, code))   // invalid data
+		assert.False(t, VerifyTimeLimitCode(now.Add(2*time.Minute), "data", 2, code)) // expired
+	})
+
+	t.Run("TestDifferentSecret", func(t *testing.T) {
+		// use another secret to ensure the code is invalid for different secret
+		verifyDataCode := func(c string) bool {
+			return VerifyTimeLimitCode(now, "data", 2, c)
+		}
+		code1 := CreateTimeLimitCode("data", 2, now, sha1.New())
+		code2 := CreateTimeLimitCode("data", 2, now, nil)
+		assert.True(t, verifyDataCode(code1))
+		assert.True(t, verifyDataCode(code2))
+		initGeneralSecret("000_QLUd4fYVyxetjxC4eZkrBgWM2SndOOWDNtgUUko")
+		assert.False(t, verifyDataCode(code1))
+		assert.False(t, verifyDataCode(code2))
+	})
+}
+
 func TestFileSize(t *testing.T) {
 	var size int64 = 512
 	assert.Equal(t, "512 B", FileSize(size))

modules/markup/sanitizer.go

@@ -97,7 +97,7 @@ func createDefaultPolicy() *bluemonday.Policy {
 	policy.AllowAttrs("class").Matching(regexp.MustCompile(`^(ref-issue( ref-external-issue)?|mention)$`)).OnElements("a")
 
 	// Allow classes for task lists
-	policy.AllowAttrs("class").Matching(regexp.MustCompile(`^task-list-item$`)).OnElements("li")
+	policy.AllowAttrs("class").Matching(regexp.MustCompile(`task-list-item`)).OnElements("li")
 
 	// Allow classes for org mode list item status.
 	policy.AllowAttrs("class").Matching(regexp.MustCompile(`^(unchecked|checked|indeterminate)$`)).OnElements("li")
@@ -106,7 +106,7 @@ func createDefaultPolicy() *bluemonday.Policy {
 	policy.AllowAttrs("class").Matching(regexp.MustCompile(`^icon(\s+[\p{L}\p{N}_-]+)+$`)).OnElements("i")
 
 	// Allow classes for emojis
-	policy.AllowAttrs("class").Matching(regexp.MustCompile(`^emoji$`)).OnElements("img")
+	policy.AllowAttrs("class").Matching(regexp.MustCompile(`emoji`)).OnElements("img")
 
 	// Allow icons, emojis, chroma syntax and keyword markup on span
 	policy.AllowAttrs("class").Matching(regexp.MustCompile(`^((icon(\s+[\p{L}\p{N}_-]+)+)|(emoji)|(language-math display)|(language-math inline))$|^([a-z][a-z0-9]{0,2})$|^` + keywordClass + `$`)).OnElements("span")
@@ -123,13 +123,13 @@ func createDefaultPolicy() *bluemonday.Policy {
 	policy.AllowAttrs("class").Matching(regexp.MustCompile("^header$")).OnElements("div")
 	policy.AllowAttrs("data-line-number").Matching(regexp.MustCompile("^[0-9]+$")).OnElements("span")
 	policy.AllowAttrs("class").Matching(regexp.MustCompile("^text small grey$")).OnElements("span")
-	policy.AllowAttrs("class").Matching(regexp.MustCompile("^file-preview$")).OnElements("table")
+	policy.AllowAttrs("class").Matching(regexp.MustCompile("^file-preview*")).OnElements("table")
 	policy.AllowAttrs("class").Matching(regexp.MustCompile("^lines-escape$")).OnElements("td")
 	policy.AllowAttrs("class").Matching(regexp.MustCompile("^toggle-escape-button btn interact-bg$")).OnElements("button")
 	policy.AllowAttrs("title").OnElements("button")
 	policy.AllowAttrs("class").Matching(regexp.MustCompile("^ambiguous-code-point$")).OnElements("span")
 	policy.AllowAttrs("data-tooltip-content").OnElements("span")
-	policy.AllowAttrs("class").Matching(regexp.MustCompile("^muted|(text black)$")).OnElements("a")
+	policy.AllowAttrs("class").Matching(regexp.MustCompile("muted|(text black)")).OnElements("a")
 	policy.AllowAttrs("class").Matching(regexp.MustCompile("^ui warning message tw-text-left$")).OnElements("div")
 
 	// Allow generally safe attributes

release-notes/5974.md

@@ -1,8 +0,0 @@
-fix: [commit](https://codeberg.org/forgejo/forgejo/commit/1ce33aa38d1d258d14523ff2c7c2dbf339f22b74) it was possible to use a token sent via email for secondary email validation to reset the password instead.  In other words, a token sent for  a given action (registration, password reset or secondary email validation) could be used to perform a different action. It is no longer possible to use a token for an action that is different from its original purpose.
-fix: [commit](https://codeberg.org/forgejo/forgejo/commit/061abe60045212acf8c3f5c49b5cc758b4cbcde9) a fork of a public repository would show in the list of forks, even if its owner was not a public user or organization. Such a fork is now hidden from the list of forks of the public repository.
-fix: [commit](https://codeberg.org/forgejo/forgejo/commit/3e3ef76808100cb1c853378733d0f6a910324ac6) the members of an organization team with read access to a repository (e.g. to read issues) but no read access to the code could read the RSS or atom feeds which include the commit activity. Reading the RSS or atom feeds is now denied unless the team has read permissions on the code.
-fix: [commit](https://codeberg.org/forgejo/forgejo/commit/9508aa7713632ed40124a933d91d5766cf2369c2) the tokens used when [replying by email to issues or pull requests](https://forgejo.org/docs/v9.0/user/incoming/) were weaker than the [rfc2104 recommendations](https://datatracker.ietf.org/doc/html/rfc2104#section-5). The tokens are now truncated to 128 bits instead of 80 bits. It is no longer possible to reply to emails sent before the upgrade because the weaker tokens are invalid.
-fix: [commit](https://codeberg.org/forgejo/forgejo/commit/786dfc7fb81ee76d4292ca5fcb33e6ea7bdccc29) a registered user could modify the update frequency of any push mirror (e.g. every 4h instead of every 8h). They are now only able to do that if they have administrative permissions on the repository.
-fix: [commit](https://codeberg.org/forgejo/forgejo/commit/e6bbecb02d47730d3cc630d419fe27ef2fb5cb39) it was possible to use basic authorization (i.e. user:password) for requests to the API even when security keys were enrolled for a user. It is no longer possible, an application token must be used instead.
-fix: [commit](https://codeberg.org/forgejo/forgejo/commit/7067cc7da4f144cc8a2fd2ae6e5307e0465ace7f) some markup sanitation rules were not as strong as they could be (e.g. allowing `emoji somethingelse` as well as `emoji`). The rules are now stricter and do not allow for such cases.
-fix: [commit](https://codeberg.org/forgejo/forgejo/commit/b70196653f9d7d3b9d4e72d114e5cc6f472988c4) when Forgejo is configured to enable instance wide search (e.g. with [bleve](https://blevesearch.com/)), results found in the repositories of private or limited users were displayed to anonymous visitors. The results found in private or limited organizations were not displayed. The search results found in the repositories of private or limited user are no longer displayed to anonymous visitors.

routers/api/v1/repo/fork.go

@@ -56,7 +56,7 @@ func ListForks(ctx *context.APIContext) {
 	//   "404":
 	//     "$ref": "#/responses/notFound"
 
-	forks, total, err := repo_model.GetForks(ctx, ctx.Repo.Repository, ctx.Doer, utils.GetListOptions(ctx))
+	forks, err := repo_model.GetForks(ctx, ctx.Repo.Repository, utils.GetListOptions(ctx))
 	if err != nil {
 		ctx.Error(http.StatusInternalServerError, "GetForks", err)
 		return
@@ -71,7 +71,7 @@ func ListForks(ctx *context.APIContext) {
 		apiForks[i] = convert.ToRepo(ctx, fork, permission)
 	}
 
-	ctx.SetTotalCountHeader(total)
+	ctx.SetTotalCountHeader(int64(ctx.Repo.Repository.NumForks))
 	ctx.JSON(http.StatusOK, apiForks)
 }
 

routers/web/auth/auth.go

@@ -5,6 +5,8 @@
 package auth
 
 import (
+	"crypto/subtle"
+	"encoding/hex"
 	"errors"
 	"fmt"
 	"net/http"
@@ -61,11 +63,38 @@ func autoSignIn(ctx *context.Context) (bool, error) {
 		return false, nil
 	}
 
-	u, err := user_model.VerifyUserAuthorizationToken(ctx, authCookie, auth.LongTermAuthorization, false)
+	lookupKey, validator, found := strings.Cut(authCookie, ":")
-	if err != nil {
+	if !found {
-		return false, fmt.Errorf("VerifyUserAuthorizationToken: %w", err)
+		return false, nil
 	}
-	if u == nil {
+
+	authToken, err := auth.FindAuthToken(ctx, lookupKey)
+	if err != nil {
+		if errors.Is(err, util.ErrNotExist) {
+			return false, nil
+		}
+		return false, err
+	}
+
+	if authToken.IsExpired() {
+		err = auth.DeleteAuthToken(ctx, authToken)
+		return false, err
+	}
+
+	rawValidator, err := hex.DecodeString(validator)
+	if err != nil {
+		return false, err
+	}
+
+	if subtle.ConstantTimeCompare([]byte(authToken.HashedValidator), []byte(auth.HashValidator(rawValidator))) == 0 {
+		return false, nil
+	}
+
+	u, err := user_model.GetUserByID(ctx, authToken.UID)
+	if err != nil {
+		if !user_model.IsErrUserNotExist(err) {
+			return false, fmt.Errorf("GetUserByID: %w", err)
+		}
 		return false, nil
 	}
 
@@ -604,10 +633,7 @@ func handleUserCreated(ctx *context.Context, u *user_model.User, gothUser *goth.
 			return false
 		}
 
-		if err := mailer.SendActivateAccountMail(ctx, u); err != nil {
+		mailer.SendActivateAccountMail(ctx.Locale, u)
-			ctx.ServerError("SendActivateAccountMail", err)
-			return false
-		}
 
 		ctx.Data["IsSendRegisterMail"] = true
 		ctx.Data["Email"] = u.Email
@@ -648,10 +674,7 @@ func Activate(ctx *context.Context) {
 				ctx.Data["ResendLimited"] = true
 			} else {
 				ctx.Data["ActiveCodeLives"] = timeutil.MinutesToFriendly(setting.Service.ActiveCodeLives, ctx.Locale)
-				if err := mailer.SendActivateAccountMail(ctx, ctx.Doer); err != nil {
+				mailer.SendActivateAccountMail(ctx.Locale, ctx.Doer)
-					ctx.ServerError("SendActivateAccountMail", err)
-					return
-				}
 
 				if err := ctx.Cache.Put(cacheKey+ctx.Doer.LowerName, ctx.Doer.LowerName, 180); err != nil {
 					log.Error("Set cache(MailResendLimit) fail: %v", err)
@@ -664,12 +687,7 @@ func Activate(ctx *context.Context) {
 		return
 	}
 
-	user, err := user_model.VerifyUserAuthorizationToken(ctx, code, auth.UserActivation, false)
+	user := user_model.VerifyUserActiveCode(ctx, code)
-	if err != nil {
-		ctx.ServerError("VerifyUserAuthorizationToken", err)
-		return
-	}
-
 	// if code is wrong
 	if user == nil {
 		ctx.Data["IsCodeInvalid"] = true
@@ -733,12 +751,7 @@ func ActivatePost(ctx *context.Context) {
 		return
 	}
 
-	user, err := user_model.VerifyUserAuthorizationToken(ctx, code, auth.UserActivation, true)
+	user := user_model.VerifyUserActiveCode(ctx, code)
-	if err != nil {
-		ctx.ServerError("VerifyUserAuthorizationToken", err)
-		return
-	}
-
 	// if code is wrong
 	if user == nil {
 		ctx.Data["IsCodeInvalid"] = true
@@ -822,33 +835,24 @@ func ActivateEmail(ctx *context.Context) {
 	code := ctx.FormString("code")
 	emailStr := ctx.FormString("email")
 
-	u, err := user_model.VerifyUserAuthorizationToken(ctx, code, auth.EmailActivation(emailStr), true)
+	// Verify code.
-	if err != nil {
+	if email := user_model.VerifyActiveEmailCode(ctx, code, emailStr); email != nil {
-		ctx.ServerError("VerifyUserAuthorizationToken", err)
+		if err := user_model.ActivateEmail(ctx, email); err != nil {
-		return
+			ctx.ServerError("ActivateEmail", err)
-	}
+			return
-	if u == nil {
+		}
-		ctx.Redirect(setting.AppSubURL + "/user/settings/account")
-		return
-	}
 
-	email, err := user_model.GetEmailAddressOfUser(ctx, emailStr, u.ID)
+		log.Trace("Email activated: %s", email.Email)
-	if err != nil {
+		ctx.Flash.Success(ctx.Tr("settings.add_email_success"))
-		ctx.ServerError("GetEmailAddressOfUser", err)
+
-		return
+		if u, err := user_model.GetUserByID(ctx, email.UID); err != nil {
+			log.Warn("GetUserByID: %d", email.UID)
+		} else {
+			// Allow user to validate more emails
+			_ = ctx.Cache.Delete("MailResendLimit_" + u.LowerName)
+		}
 	}
 
-	if err := user_model.ActivateEmail(ctx, email); err != nil {
-		ctx.ServerError("ActivateEmail", err)
-		return
-	}
-
-	log.Trace("Email activated: %s", email.Email)
-	ctx.Flash.Success(ctx.Tr("settings.add_email_success"))
-
-	// Allow user to validate more emails
-	_ = ctx.Cache.Delete("MailResendLimit_" + u.LowerName)
-
 	// FIXME: e-mail verification does not require the user to be logged in,
 	// so this could be redirecting to the login page.
 	// Should users be logged in automatically here? (consider 2FA requirements, etc.)

routers/web/auth/password.go

@@ -86,10 +86,7 @@ func ForgotPasswdPost(ctx *context.Context) {
 		return
 	}
 
-	if err := mailer.SendResetPasswordMail(ctx, u); err != nil {
+	mailer.SendResetPasswordMail(u)
-		ctx.ServerError("SendResetPasswordMail", err)
-		return
-	}
 
 	if err = ctx.Cache.Put("MailResendLimit_"+u.LowerName, u.LowerName, 180); err != nil {
 		log.Error("Set cache(MailResendLimit) fail: %v", err)
@@ -100,7 +97,7 @@ func ForgotPasswdPost(ctx *context.Context) {
 	ctx.HTML(http.StatusOK, tplForgotPassword)
 }
 
-func commonResetPassword(ctx *context.Context, shouldDeleteToken bool) (*user_model.User, *auth.TwoFactor) {
+func commonResetPassword(ctx *context.Context) (*user_model.User, *auth.TwoFactor) {
 	code := ctx.FormString("code")
 
 	ctx.Data["Title"] = ctx.Tr("auth.reset_password")
@@ -116,12 +113,7 @@ func commonResetPassword(ctx *context.Context, shouldDeleteToken bool) (*user_mo
 	}
 
 	// Fail early, don't frustrate the user
-	u, err := user_model.VerifyUserAuthorizationToken(ctx, code, auth.PasswordReset, shouldDeleteToken)
+	u := user_model.VerifyUserActiveCode(ctx, code)
-	if err != nil {
-		ctx.ServerError("VerifyUserAuthorizationToken", err)
-		return nil, nil
-	}
-
 	if u == nil {
 		ctx.Flash.Error(ctx.Tr("auth.invalid_code_forgot_password", fmt.Sprintf("%s/user/forgot_password", setting.AppSubURL)), true)
 		return nil, nil
@@ -153,7 +145,7 @@ func commonResetPassword(ctx *context.Context, shouldDeleteToken bool) (*user_mo
 func ResetPasswd(ctx *context.Context) {
 	ctx.Data["IsResetForm"] = true
 
-	commonResetPassword(ctx, false)
+	commonResetPassword(ctx)
 	if ctx.Written() {
 		return
 	}
@@ -163,7 +155,7 @@ func ResetPasswd(ctx *context.Context) {
 
 // ResetPasswdPost response from account recovery request
 func ResetPasswdPost(ctx *context.Context) {
-	u, twofa := commonResetPassword(ctx, true)
+	u, twofa := commonResetPassword(ctx)
 	if ctx.Written() {
 		return
 	}

routers/web/repo/setting/setting.go

@@ -566,19 +566,21 @@ func SettingsPost(ctx *context.Context) {
 		// as an error on the UI for this action
 		ctx.Data["Err_RepoName"] = nil
 
-		m, err := selectPushMirrorByForm(ctx, form, repo)
-		if err != nil {
-			ctx.NotFound("", nil)
-			return
-		}
-
 		interval, err := time.ParseDuration(form.PushMirrorInterval)
 		if err != nil || (interval != 0 && interval < setting.Mirror.MinInterval) {
 			ctx.RenderWithErr(ctx.Tr("repo.mirror_interval_invalid"), tplSettingsOptions, &forms.RepoSettingForm{})
 			return
 		}
 
-		m.Interval = interval
+		id, err := strconv.ParseInt(form.PushMirrorID, 10, 64)
+		if err != nil {
+			ctx.ServerError("UpdatePushMirrorIntervalPushMirrorID", err)
+			return
+		}
+		m := &repo_model.PushMirror{
+			ID:       id,
+			Interval: interval,
+		}
 		if err := repo_model.UpdatePushMirrorInterval(ctx, m); err != nil {
 			ctx.ServerError("UpdatePushMirrorInterval", err)
 			return

routers/web/repo/view.go

@@ -1232,8 +1232,11 @@ func Forks(ctx *context.Context) {
 		page = 1
 	}
 
-	forks, total, err := repo_model.GetForks(ctx, ctx.Repo.Repository, ctx.Doer, db.ListOptions{
+	pager := context.NewPagination(ctx.Repo.Repository.NumForks, setting.MaxForksPerPage, page, 5)
-		Page:     page,
+	ctx.Data["Page"] = pager
+
+	forks, err := repo_model.GetForks(ctx, ctx.Repo.Repository, db.ListOptions{
+		Page:     pager.Paginater.Current(),
 		PageSize: setting.MaxForksPerPage,
 	})
 	if err != nil {
@@ -1241,9 +1244,6 @@ func Forks(ctx *context.Context) {
 		return
 	}
 
-	pager := context.NewPagination(int(total), setting.MaxForksPerPage, page, 5)
-	ctx.Data["Page"] = pager
-
 	for _, fork := range forks {
 		if err = fork.LoadOwner(ctx); err != nil {
 			ctx.ServerError("LoadOwner", err)

routers/web/user/setting/account.go

@@ -155,15 +155,9 @@ func EmailPost(ctx *context.Context) {
 				return
 			}
 			// Only fired when the primary email is inactive (Wrong state)
-			if err := mailer.SendActivateAccountMail(ctx, ctx.Doer); err != nil {
+			mailer.SendActivateAccountMail(ctx.Locale, ctx.Doer)
-				ctx.ServerError("SendActivateAccountMail", err)
-				return
-			}
 		} else {
-			if err := mailer.SendActivateEmailMail(ctx, ctx.Doer, email.Email); err != nil {
+			mailer.SendActivateEmailMail(ctx.Doer, email.Email)
-				ctx.ServerError("SendActivateEmailMail", err)
-				return
-			}
 		}
 		address = email.Email
 
@@ -224,10 +218,7 @@ func EmailPost(ctx *context.Context) {
 
 	// Send confirmation email
 	if setting.Service.RegisterEmailConfirm {
-		if err := mailer.SendActivateEmailMail(ctx, ctx.Doer, form.Email); err != nil {
+		mailer.SendActivateEmailMail(ctx.Doer, form.Email)
-			ctx.ServerError("SendActivateEmailMail", err)
-			return
-		}
 		if err := ctx.Cache.Put("MailResendLimit_"+ctx.Doer.LowerName, ctx.Doer.LowerName, 180); err != nil {
 			log.Error("Set cache(MailResendLimit) fail: %v", err)
 		}

routers/web/web.go

@@ -1562,10 +1562,8 @@ func registerRoutes(m *web.Route) {
 			m.Get("/cherry-pick/{sha:([a-f0-9]{4,64})$}", repo.SetEditorconfigIfExists, repo.CherryPick)
 		}, repo.MustBeNotEmpty, context.RepoRef(), reqRepoCodeReader)
 
-		m.Group("", func() {
+		m.Get("/rss/branch/*", repo.MustBeNotEmpty, context.RepoRefByType(context.RepoRefBranch), feedEnabled, feed.RenderBranchFeed("rss"))
-			m.Get("/rss/branch/*", feed.RenderBranchFeed("rss"))
+		m.Get("/atom/branch/*", repo.MustBeNotEmpty, context.RepoRefByType(context.RepoRefBranch), feedEnabled, feed.RenderBranchFeed("atom"))
-			m.Get("/atom/branch/*", feed.RenderBranchFeed("atom"))
-		}, repo.MustBeNotEmpty, context.RepoRefByType(context.RepoRefBranch), reqRepoCodeReader, feedEnabled)
 
 		m.Group("/src", func() {
 			m.Get("/branch/*", context.RepoRefByType(context.RepoRefBranch), repo.Home)

services/auth/basic.go

@@ -5,7 +5,6 @@
 package auth
 
 import (
-	"errors"
 	"net/http"
 	"strings"
 
@@ -133,16 +132,6 @@ func (b *Basic) Verify(req *http.Request, w http.ResponseWriter, store DataStore
 		return nil, err
 	}
 
-	hashWebAuthn, err := auth_model.HasWebAuthnRegistrationsByUID(req.Context(), u.ID)
-	if err != nil {
-		log.Error("HasWebAuthnRegistrationsByUID: %v", err)
-		return nil, err
-	}
-
-	if hashWebAuthn {
-		return nil, errors.New("Basic authorization is not allowed while having security keys enrolled")
-	}
-
 	if skipper, ok := source.Cfg.(LocalTwoFASkipper); !ok || !skipper.IsSkipLocalTwoFA() {
 		if err := validateTOTP(req, u); err != nil {
 			return nil, err

services/context/context_cookie.go

@@ -47,7 +47,7 @@ func (ctx *Context) GetSiteCookie(name string) string {
 // SetLTACookie will generate a LTA token and add it as an cookie.
 func (ctx *Context) SetLTACookie(u *user_model.User) error {
 	days := 86400 * setting.LogInRememberDays
-	lookup, validator, err := auth_model.GenerateAuthToken(ctx, u.ID, timeutil.TimeStampNow().Add(int64(days)), auth_model.LongTermAuthorization)
+	lookup, validator, err := auth_model.GenerateAuthToken(ctx, u.ID, timeutil.TimeStampNow().Add(int64(days)))
 	if err != nil {
 		return err
 	}

services/doctor/dbconsistency.go

@@ -243,9 +243,6 @@ func checkDBConsistency(ctx context.Context, logger log.Logger, autofix bool) er
 		// find archive download count without existing release
 		genericOrphanCheck("Archive download count without existing Release",
 			"repo_archive_download_count", "release", "repo_archive_download_count.release_id=release.id"),
-		// find authorization tokens without existing user
-		genericOrphanCheck("Authorization token without existing User",
-			"forgejo_auth_token", "user", "forgejo_auth_token.uid=user.id"),
 	)
 
 	for _, c := range consistencyChecks {

services/mailer/mail.go

@@ -70,7 +70,7 @@ func SendTestMail(email string) error {
 }
 
 // sendUserMail sends a mail to the user
-func sendUserMail(language string, u *user_model.User, tpl base.TplName, code, subject, info string) error {
+func sendUserMail(language string, u *user_model.User, tpl base.TplName, code, subject, info string) {
 	locale := translation.NewLocale(language)
 	data := map[string]any{
 		"locale":            locale,
@@ -84,66 +84,47 @@ func sendUserMail(language string, u *user_model.User, tpl base.TplName, code, s
 	var content bytes.Buffer
 
 	if err := bodyTemplates.ExecuteTemplate(&content, string(tpl), data); err != nil {
-		return err
+		log.Error("Template: %v", err)
+		return
 	}
 
 	msg := NewMessage(u.EmailTo(), subject, content.String())
 	msg.Info = fmt.Sprintf("UID: %d, %s", u.ID, info)
 
 	SendAsync(msg)
-	return nil
 }
 
 // SendActivateAccountMail sends an activation mail to the user (new user registration)
-func SendActivateAccountMail(ctx context.Context, u *user_model.User) error {
+func SendActivateAccountMail(locale translation.Locale, u *user_model.User) {
 	if setting.MailService == nil {
 		// No mail service configured
-		return nil
+		return
 	}
-
+	sendUserMail(locale.Language(), u, mailAuthActivate, u.GenerateEmailActivateCode(u.Email), locale.TrString("mail.activate_account"), "activate account")
-	locale := translation.NewLocale(u.Language)
-	code, err := u.GenerateEmailAuthorizationCode(ctx, auth_model.UserActivation)
-	if err != nil {
-		return err
-	}
-
-	return sendUserMail(locale.Language(), u, mailAuthActivate, code, locale.TrString("mail.activate_account"), "activate account")
 }
 
 // SendResetPasswordMail sends a password reset mail to the user
-func SendResetPasswordMail(ctx context.Context, u *user_model.User) error {
+func SendResetPasswordMail(u *user_model.User) {
 	if setting.MailService == nil {
 		// No mail service configured
-		return nil
+		return
 	}
-
 	locale := translation.NewLocale(u.Language)
-	code, err := u.GenerateEmailAuthorizationCode(ctx, auth_model.PasswordReset)
+	sendUserMail(u.Language, u, mailAuthResetPassword, u.GenerateEmailActivateCode(u.Email), locale.TrString("mail.reset_password"), "recover account")
-	if err != nil {
-		return err
-	}
-
-	return sendUserMail(u.Language, u, mailAuthResetPassword, code, locale.TrString("mail.reset_password"), "recover account")
 }
 
 // SendActivateEmailMail sends confirmation email to confirm new email address
-func SendActivateEmailMail(ctx context.Context, u *user_model.User, email string) error {
+func SendActivateEmailMail(u *user_model.User, email string) {
 	if setting.MailService == nil {
 		// No mail service configured
-		return nil
+		return
 	}
-
 	locale := translation.NewLocale(u.Language)
-	code, err := u.GenerateEmailAuthorizationCode(ctx, auth_model.EmailActivation(email))
-	if err != nil {
-		return err
-	}
-
 	data := map[string]any{
 		"locale":          locale,
 		"DisplayName":     u.DisplayName(),
 		"ActiveCodeLives": timeutil.MinutesToFriendly(setting.Service.ActiveCodeLives, locale),
-		"Code":            code,
+		"Code":            u.GenerateEmailActivateCode(email),
 		"Email":           email,
 		"Language":        locale.Language(),
 	}
@@ -151,14 +132,14 @@ func SendActivateEmailMail(ctx context.Context, u *user_model.User, email string
 	var content bytes.Buffer
 
 	if err := bodyTemplates.ExecuteTemplate(&content, string(mailAuthActivateEmail), data); err != nil {
-		return err
+		log.Error("Template: %v", err)
+		return
 	}
 
 	msg := NewMessage(email, locale.TrString("mail.activate_email"), content.String())
 	msg.Info = fmt.Sprintf("UID: %d, activate email", u.ID)
 
 	SendAsync(msg)
-	return nil
 }
 
 // SendRegisterNotifyMail triggers a notify e-mail by admin created a account.

services/mailer/token/token.go

@@ -22,16 +22,9 @@ import (
 //
 // The payload is verifiable by the generated HMAC using the user secret. It contains:
 // | Timestamp | Action/Handler Type | Action/Handler Data |
-//
-//
-// Version changelog
-//
-// v1 -> v2:
-// Use 128 instead of 80 bits of the HMAC-SHA256 output.
 
 const (
 	tokenVersion1        byte = 1
-	tokenVersion2        byte = 2
 	tokenLifetimeInYears int  = 1
 )
 
@@ -77,7 +70,7 @@ func CreateToken(ht HandlerType, user *user_model.User, data []byte) (string, er
 		return "", err
 	}
 
-	return encodingWithoutPadding.EncodeToString(append([]byte{tokenVersion2}, packagedData...)), nil
+	return encodingWithoutPadding.EncodeToString(append([]byte{tokenVersion1}, packagedData...)), nil
 }
 
 // ExtractToken extracts the action/user tuple from the token and verifies the content
@@ -91,7 +84,7 @@ func ExtractToken(ctx context.Context, token string) (HandlerType, *user_model.U
 		return UnknownHandlerType, nil, nil, &ErrToken{"no data"}
 	}
 
-	if data[0] != tokenVersion2 {
+	if data[0] != tokenVersion1 {
 		return UnknownHandlerType, nil, nil, &ErrToken{fmt.Sprintf("unsupported token version: %v", data[0])}
 	}
 
@@ -131,8 +124,5 @@ func generateHmac(secret, payload []byte) []byte {
 	mac.Write(payload)
 	hmac := mac.Sum(nil)
 
-	// RFC2104 section 5 recommends that if you do HMAC truncation, you should use
+	return hmac[:10] // RFC2104 recommends not using less then 80 bits
-	// the max(80, hash_len/2) of the leftmost bits.
-	// For SHA256 this works out to using 128 of the leftmost bits.
-	return hmac[:16]
 }

services/user/delete.go

@@ -96,7 +96,6 @@ func deleteUser(ctx context.Context, u *user_model.User, purge bool) (err error)
 		&user_model.BlockedUser{BlockID: u.ID},
 		&user_model.BlockedUser{UserID: u.ID},
 		&actions_model.ActionRunnerToken{OwnerID: u.ID},
-		&auth_model.AuthorizationToken{UID: u.ID},
 	); err != nil {
 		return fmt.Errorf("deleteBeans: %w", err)
 	}

tests/e2e/actions.test.e2e.ts

@@ -20,6 +20,7 @@ const workflow_trigger_notification_text = 'This workflow has a workflow_dispatc
 
 test('workflow dispatch present', async ({browser}, workerInfo) => {
   const context = await load_logged_in_context(browser, workerInfo, 'user2');
+  /** @type {import('@playwright/test').Page} */
   const page = await context.newPage();
 
   await page.goto('/user2/test_workflows/actions?workflow=test-dispatch.yml&actor=0&status=0');
@@ -39,6 +40,7 @@ test('workflow dispatch error: missing inputs', async ({browser}, workerInfo) =>
   test.skip(workerInfo.project.name === 'Mobile Safari', 'Flaky behaviour on mobile safari; see https://codeberg.org/forgejo/forgejo/pulls/3334#issuecomment-2033383');
 
   const context = await load_logged_in_context(browser, workerInfo, 'user2');
+  /** @type {import('@playwright/test').Page} */
   const page = await context.newPage();
 
   await page.goto('/user2/test_workflows/actions?workflow=test-dispatch.yml&actor=0&status=0');
@@ -60,13 +62,14 @@ test('workflow dispatch success', async ({browser}, workerInfo) => {
   test.skip(workerInfo.project.name === 'Mobile Safari', 'Flaky behaviour on mobile safari; see https://codeberg.org/forgejo/forgejo/pulls/3334#issuecomment-2033383');
 
   const context = await load_logged_in_context(browser, workerInfo, 'user2');
+  /** @type {import('@playwright/test').Page} */
   const page = await context.newPage();
 
   await page.goto('/user2/test_workflows/actions?workflow=test-dispatch.yml&actor=0&status=0');
 
   await page.locator('#workflow_dispatch_dropdown>button').click();
 
-  await page.fill('input[name="inputs[string2]"]', 'abc');
+  await page.type('input[name="inputs[string2]"]', 'abc');
   await page.locator('#workflow-dispatch-submit').click();
 
   await expect(page.getByText('Workflow run was successfully requested.')).toBeVisible();

tests/e2e/example.test.e2e.ts

@@ -21,10 +21,10 @@ test('Load Homepage', async ({page}) => {
 test('Register Form', async ({page}, workerInfo) => {
   const response = await page.goto('/user/sign_up');
   expect(response?.status()).toBe(200); // Status OK
-  await page.fill('input[name=user_name]', `e2e-test-${workerInfo.workerIndex}`);
+  await page.type('input[name=user_name]', `e2e-test-${workerInfo.workerIndex}`);
-  await page.fill('input[name=email]', `e2e-test-${workerInfo.workerIndex}@test.com`);
+  await page.type('input[name=email]', `e2e-test-${workerInfo.workerIndex}@test.com`);
-  await page.fill('input[name=password]', 'test123test123');
+  await page.type('input[name=password]', 'test123test123');
-  await page.fill('input[name=retype]', 'test123test123');
+  await page.type('input[name=retype]', 'test123test123');
   await page.click('form button.ui.primary.button:visible');
   // Make sure we routed to the home page. Else login failed.
   expect(page.url()).toBe(`${workerInfo.project.use.baseURL}/`);

tests/e2e/issue-sidebar.test.e2e.ts

@@ -4,18 +4,19 @@
 // web_src/js/features/repo-issue**
 // @watch end
 
-/* eslint playwright/expect-expect: ["error", { "assertFunctionNames": ["check_wip"] }] */
+import {expect} from '@playwright/test';
-
-import {expect, type Page} from '@playwright/test';
 import {test, login_user, login} from './utils_e2e.ts';
 
 test.beforeAll(async ({browser}, workerInfo) => {
   await login_user(browser, workerInfo, 'user2');
 });
 
+/* eslint-disable playwright/expect-expect */
+// some tests are reported to have no assertions,
+// which is not correct, because they use the global helper function
 test.describe('Pull: Toggle WIP', () => {
   const prTitle = 'pull5';
-  async function toggle_wip_to({page}, should: boolean) {
+  async function toggle_wip_to({page}, should) {
     await page.waitForLoadState('domcontentloaded');
     if (should) {
       await page.getByText('Still in progress?').click();
@@ -24,7 +25,7 @@ test.describe('Pull: Toggle WIP', () => {
     }
   }
 
-  async function check_wip({page}, is: boolean) {
+  async function check_wip({page}, is) {
     const elemTitle = 'h1';
     const stateLabel = '.issue-state-label';
     await page.waitForLoadState('domcontentloaded');
@@ -95,11 +96,12 @@ test.describe('Pull: Toggle WIP', () => {
     await expect(page.locator('h1')).toContainText(maxLenStr);
   });
 });
+/* eslint-enable playwright/expect-expect */
 
 test('Issue: Labels', async ({browser}, workerInfo) => {
   test.skip(workerInfo.project.name === 'Mobile Safari', 'Unable to get tests working on Safari Mobile, see https://codeberg.org/forgejo/forgejo/pulls/3445#issuecomment-1789636');
 
-  async function submitLabels({page}: {page: Page}) {
+  async function submitLabels({page}) {
     const submitted = page.waitForResponse('/user2/repo1/issues/labels');
     await page.locator('textarea').first().click(); // close via unrelated element
     await submitted;
@@ -197,7 +199,7 @@ test('New Issue: Assignees', async ({browser}, workerInfo) => {
 
   // Assign other user (with searchbox)
   await page.locator('.select-assignees.dropdown').click();
-  await page.fill('.select-assignees .menu .search input', 'user4');
+  await page.type('.select-assignees .menu .search input', 'user4');
   await expect(page.locator('.select-assignees .menu .item').filter({hasText: 'user2'})).toBeHidden();
   await expect(page.locator('.select-assignees .menu .item').filter({hasText: 'user4'})).toBeVisible();
   await page.locator('.select-assignees .menu .item').filter({hasText: 'user4'}).click();

tests/e2e/markdown-editor.test.e2e.ts

@@ -29,7 +29,7 @@ test('markdown indentation', async ({browser}, workerInfo) => {
 
   // Indent, then unindent first line
   await textarea.focus();
-  await textarea.evaluate((it:HTMLTextAreaElement) => it.setSelectionRange(0, 0));
+  await textarea.evaluate((it) => it.setSelectionRange(0, 0));
   await indent.click();
   await expect(textarea).toHaveValue(`${tab}* first\n* second\n* third\n* last`);
   await unindent.click();
@@ -45,7 +45,7 @@ test('markdown indentation', async ({browser}, workerInfo) => {
 
   // Subsequently, select a chunk of 2nd and 3rd line and indent both, preserving the cursor position in relation to text
   await textarea.focus();
-  await textarea.evaluate((it:HTMLTextAreaElement) => it.setSelectionRange(it.value.indexOf('cond'), it.value.indexOf('hird')));
+  await textarea.evaluate((it) => it.setSelectionRange(it.value.indexOf('cond'), it.value.indexOf('hird')));
   await indent.click();
   const lines23 = `* first\n${tab}${tab}* second\n${tab}* third\n* last`;
   await expect(textarea).toHaveValue(lines23);
@@ -60,7 +60,7 @@ test('markdown indentation', async ({browser}, workerInfo) => {
 
   // Indent and unindent with cursor at the end of the line
   await textarea.focus();
-  await textarea.evaluate((it:HTMLTextAreaElement) => it.setSelectionRange(it.value.indexOf('cond'), it.value.indexOf('cond')));
+  await textarea.evaluate((it) => it.setSelectionRange(it.value.indexOf('cond'), it.value.indexOf('cond')));
   await textarea.press('End');
   await indent.click();
   await expect(textarea).toHaveValue(`* first\n${tab}* second\n* third\n* last`);
@@ -69,7 +69,7 @@ test('markdown indentation', async ({browser}, workerInfo) => {
 
   // Check that Tab does work after input
   await textarea.focus();
-  await textarea.evaluate((it:HTMLTextAreaElement) => it.setSelectionRange(it.value.length, it.value.length));
+  await textarea.evaluate((it) => it.setSelectionRange(it.value.length, it.value.length));
   await textarea.press('Shift+Enter'); // Avoid triggering the prefix continuation feature
   await textarea.pressSequentially('* least');
   await indent.click();
@@ -78,7 +78,7 @@ test('markdown indentation', async ({browser}, workerInfo) => {
   // Check that partial indents are cleared
   await textarea.focus();
   await textarea.fill(initText);
-  await textarea.evaluate((it:HTMLTextAreaElement) => it.setSelectionRange(it.value.indexOf('* second'), it.value.indexOf('* second')));
+  await textarea.evaluate((it) => it.setSelectionRange(it.value.indexOf('* second'), it.value.indexOf('* second')));
   await textarea.pressSequentially('  ');
   await unindent.click();
   await expect(textarea).toHaveValue(initText);
@@ -99,7 +99,7 @@ test('markdown list continuation', async ({browser}, workerInfo) => {
   await textarea.fill(initText);
 
   // Test continuation of '* ' prefix
-  await textarea.evaluate((it:HTMLTextAreaElement) => it.setSelectionRange(it.value.indexOf('cond'), it.value.indexOf('cond')));
+  await textarea.evaluate((it) => it.setSelectionRange(it.value.indexOf('cond'), it.value.indexOf('cond')));
   await textarea.press('End');
   await textarea.press('Enter');
   await textarea.pressSequentially('middle');
@@ -112,7 +112,7 @@ test('markdown list continuation', async ({browser}, workerInfo) => {
   await expect(textarea).toHaveValue(`* first\n* second\n${tab}* middle\n${tab}* muddle\n* third\n* last`);
 
   // Test breaking in the middle of a line
-  await textarea.evaluate((it:HTMLTextAreaElement) => it.setSelectionRange(it.value.lastIndexOf('ddle'), it.value.lastIndexOf('ddle')));
+  await textarea.evaluate((it) => it.setSelectionRange(it.value.lastIndexOf('ddle'), it.value.lastIndexOf('ddle')));
   await textarea.pressSequentially('tate');
   await textarea.press('Enter');
   await textarea.pressSequentially('me');
@@ -120,7 +120,7 @@ test('markdown list continuation', async ({browser}, workerInfo) => {
 
   // Test not triggering when Shift held
   await textarea.fill(initText);
-  await textarea.evaluate((it:HTMLTextAreaElement) => it.setSelectionRange(it.value.length, it.value.length));
+  await textarea.evaluate((it) => it.setSelectionRange(it.value.length, it.value.length));
   await textarea.press('Shift+Enter');
   await textarea.press('Enter');
   await textarea.pressSequentially('...but not least');
@@ -128,28 +128,28 @@ test('markdown list continuation', async ({browser}, workerInfo) => {
 
   // Test continuation of ordered list
   await textarea.fill(`1. one\n2. two`);
-  await textarea.evaluate((it:HTMLTextAreaElement) => it.setSelectionRange(it.value.length, it.value.length));
+  await textarea.evaluate((it) => it.setSelectionRange(it.value.length, it.value.length));
   await textarea.press('Enter');
   await textarea.pressSequentially('three');
   await expect(textarea).toHaveValue(`1. one\n2. two\n3. three`);
 
   // Test continuation of alternative ordered list syntax
   await textarea.fill(`1) one\n2) two`);
-  await textarea.evaluate((it:HTMLTextAreaElement) => it.setSelectionRange(it.value.length, it.value.length));
+  await textarea.evaluate((it) => it.setSelectionRange(it.value.length, it.value.length));
   await textarea.press('Enter');
   await textarea.pressSequentially('three');
   await expect(textarea).toHaveValue(`1) one\n2) two\n3) three`);
 
   // Test continuation of blockquote
   await textarea.fill(`> knowledge is power`);
-  await textarea.evaluate((it:HTMLTextAreaElement) => it.setSelectionRange(it.value.length, it.value.length));
+  await textarea.evaluate((it) => it.setSelectionRange(it.value.length, it.value.length));
   await textarea.press('Enter');
   await textarea.pressSequentially('france is bacon');
   await expect(textarea).toHaveValue(`> knowledge is power\n> france is bacon`);
 
   // Test continuation of checklists
   await textarea.fill(`- [ ] have a problem\n- [x] create a solution`);
-  await textarea.evaluate((it:HTMLTextAreaElement) => it.setSelectionRange(it.value.length, it.value.length));
+  await textarea.evaluate((it) => it.setSelectionRange(it.value.length, it.value.length));
   await textarea.press('Enter');
   await textarea.pressSequentially('write a test');
   await expect(textarea).toHaveValue(`- [ ] have a problem\n- [x] create a solution\n- [ ] write a test`);
@@ -174,7 +174,7 @@ test('markdown list continuation', async ({browser}, workerInfo) => {
   ];
   for (const prefix of prefixes) {
     await textarea.fill(`${prefix}one`);
-    await textarea.evaluate((it:HTMLTextAreaElement) => it.setSelectionRange(it.value.length, it.value.length));
+    await textarea.evaluate((it) => it.setSelectionRange(it.value.length, it.value.length));
     await textarea.press('Enter');
     await textarea.pressSequentially('two');
     await expect(textarea).toHaveValue(`${prefix}one\n${prefix}two`);

tests/e2e/reaction-selectors.test.e2e.ts

@@ -3,14 +3,14 @@
 // routers/web/repo/issue.go
 // @watch end
 
-import {expect, type Locator} from '@playwright/test';
+import {expect} from '@playwright/test';
 import {test, login_user, load_logged_in_context} from './utils_e2e.ts';
 
 test.beforeAll(async ({browser}, workerInfo) => {
   await login_user(browser, workerInfo, 'user2');
 });
 
-const assertReactionCounts = (comment: Locator, counts: unknown) =>
+const assertReactionCounts = (comment, counts) =>
   expect(async () => {
     await expect(comment.locator('.reactions')).toBeVisible();
 
@@ -29,7 +29,7 @@ const assertReactionCounts = (comment: Locator, counts: unknown) =>
     return expect(reactions).toStrictEqual(counts);
   }).toPass();
 
-async function toggleReaction(menu: Locator, reaction: string) {
+async function toggleReaction(menu, reaction) {
   await menu.evaluateAll((menus) => menus[0].focus());
   await menu.locator('.add-reaction').click();
   await menu.locator(`[role=menuitem][data-reaction-content="${reaction}"]`).click();

tests/e2e/repo-code.test.e2e.ts

@@ -4,7 +4,7 @@
 // services/gitdiff/**
 // @watch end
 
-import {expect, type Page} from '@playwright/test';
+import {expect} from '@playwright/test';
 import {test, login_user, login} from './utils_e2e.ts';
 import {accessibilityCheck} from './shared/accessibility.ts';
 
@@ -12,7 +12,7 @@ test.beforeAll(async ({browser}, workerInfo) => {
   await login_user(browser, workerInfo, 'user2');
 });
 
-async function assertSelectedLines(page: Page, nums: string[]) {
+async function assertSelectedLines(page, nums) {
   const pageAssertions = async () => {
     expect(
       await Promise.all((await page.locator('tr.active [data-line-number]').all()).map((line) => line.getAttribute('data-line-number'))),

tests/e2e/shared/accessibility.ts

@@ -3,9 +3,9 @@ import {AxeBuilder} from '@axe-core/playwright';
 
 export async function accessibilityCheck({page}: {page: Page}, includes: string[], excludes: string[], disabledRules: string[]) {
   // contrast of inline links is still a global issue in Forgejo
-  disabledRules.push('link-in-text-block');
+  disabledRules += 'link-in-text-block';
 
-  let accessibilityScanner = new AxeBuilder({page})
+  let accessibilityScanner = await new AxeBuilder({page})
     .disableRules(disabledRules);
   // passing the whole array seems to be not supported,
   // iterating has the nice side-effectof skipping this if the array is empty

tests/e2e/utils_e2e.ts

@@ -33,8 +33,8 @@ export async function login_user(browser: Browser, workerInfo: TestInfo, user: s
   expect(response?.status()).toBe(200); // Status OK
 
   // Fill out form
-  await page.fill('input[name=user_name]', user);
+  await page.type('input[name=user_name]', user);
-  await page.fill('input[name=password]', LOGIN_PASSWORD);
+  await page.type('input[name=password]', LOGIN_PASSWORD);
   await page.click('form button.ui.primary.button:visible');
 
   await page.waitForLoadState();
@@ -48,13 +48,15 @@ export async function login_user(browser: Browser, workerInfo: TestInfo, user: s
 }
 
 export async function load_logged_in_context(browser: Browser, workerInfo: TestInfo, user: string) {
+  let context;
   try {
-    return await test_context(browser, {storageState: `${ARTIFACTS_PATH}/state-${user}-${workerInfo.workerIndex}.json`});
+    context = await test_context(browser, {storageState: `${ARTIFACTS_PATH}/state-${user}-${workerInfo.workerIndex}.json`});
   } catch (err) {
     if (err.code === 'ENOENT') {
       throw new Error(`Could not find state for '${user}'. Did you call login_user(browser, workerInfo, '${user}') in test.beforeAll()?`);
     }
   }
+  return context;
 }
 
 export async function login({browser}: {browser: Browser}, workerInfo: TestInfo) {

tests/e2e/utils_e2e_test.go

@@ -8,8 +8,6 @@ import (
 	"net"
 	"net/http"
 	"net/url"
-	"os"
-	"regexp"
 	"testing"
 	"time"
 
@@ -19,8 +17,6 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
-var rootPathRe = regexp.MustCompile("\\[repository\\]\nROOT\\s=\\s.*")
-
 func onForgejoRunTB(t testing.TB, callback func(testing.TB, *url.URL), prepare ...bool) {
 	if len(prepare) == 0 || prepare[0] {
 		defer tests.PrepareTestEnv(t, 1)()
@@ -41,13 +37,7 @@ func onForgejoRunTB(t testing.TB, callback func(testing.TB, *url.URL), prepare .
 	require.NoError(t, err)
 	u.Host = listener.Addr().String()
 
-	// Override repository root in config.
-	conf, err := os.ReadFile(setting.CustomConf)
-	require.NoError(t, err)
-	require.NoError(t, os.WriteFile(setting.CustomConf, rootPathRe.ReplaceAll(conf, []byte("[repository]\nROOT = "+setting.RepoRootPath)), 0o644))
-
 	defer func() {
-		require.NoError(t, os.WriteFile(setting.CustomConf, conf, 0o644))
 		ctx, cancel := context.WithTimeout(context.Background(), 2*time.Minute)
 		s.Shutdown(ctx)
 		cancel()

tests/e2e/webauthn.test.e2e.ts

@@ -30,6 +30,7 @@ test('WebAuthn register & login flow', async ({browser, request}, workerInfo) =>
       transport: 'usb',
       automaticPresenceSimulation: true,
       isUserVerified: true,
+      backupEligibility: true, // TODO: this doesn't seem to be available?!
     },
   });
 

tests/integration/api_feed_user_test.go

@@ -109,24 +109,4 @@ func TestFeed(t *testing.T) {
 			})
 		})
 	})
-
-	t.Run("View permission", func(t *testing.T) {
-		t.Run("Anomynous", func(t *testing.T) {
-			defer tests.PrintCurrentTest(t)()
-			req := NewRequest(t, "GET", "/org3/repo3/rss/branch/master")
-			MakeRequest(t, req, http.StatusNotFound)
-		})
-		t.Run("No code permission", func(t *testing.T) {
-			defer tests.PrintCurrentTest(t)()
-			session := loginUser(t, "user8")
-			req := NewRequest(t, "GET", "/org3/repo3/rss/branch/master")
-			session.MakeRequest(t, req, http.StatusNotFound)
-		})
-		t.Run("With code permission", func(t *testing.T) {
-			defer tests.PrintCurrentTest(t)()
-			session := loginUser(t, "user9")
-			req := NewRequest(t, "GET", "/org3/repo3/rss/branch/master")
-			session.MakeRequest(t, req, http.StatusOK)
-		})
-	})
 }

tests/integration/api_fork_test.go

@@ -17,8 +17,6 @@ import (
 	"code.gitea.io/gitea/modules/test"
 	"code.gitea.io/gitea/routers"
 	"code.gitea.io/gitea/tests"
-
-	"github.com/stretchr/testify/assert"
 )
 
 func TestAPIForkAsAdminIgnoringLimits(t *testing.T) {
@@ -108,44 +106,3 @@ func TestAPIDisabledForkRepo(t *testing.T) {
 		session.MakeRequest(t, req, http.StatusNotFound)
 	})
 }
-
-func TestAPIForkListPrivateRepo(t *testing.T) {
-	defer tests.PrepareTestEnv(t)()
-
-	session := loginUser(t, "user5")
-	token := getTokenForLoggedInUser(t, session,
-		auth_model.AccessTokenScopeWriteRepository,
-		auth_model.AccessTokenScopeWriteOrganization)
-	org23 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 23, Visibility: api.VisibleTypePrivate})
-
-	req := NewRequestWithJSON(t, "POST", "/api/v1/repos/user2/repo1/forks", &api.CreateForkOption{
-		Organization: &org23.Name,
-	}).AddTokenAuth(token)
-	MakeRequest(t, req, http.StatusAccepted)
-
-	t.Run("Anomynous", func(t *testing.T) {
-		defer tests.PrintCurrentTest(t)()
-
-		req := NewRequest(t, "GET", "/api/v1/repos/user2/repo1/forks")
-		resp := MakeRequest(t, req, http.StatusOK)
-
-		var forks []*api.Repository
-		DecodeJSON(t, resp, &forks)
-
-		assert.Empty(t, forks)
-		assert.EqualValues(t, "0", resp.Header().Get("X-Total-Count"))
-	})
-
-	t.Run("Logged in", func(t *testing.T) {
-		defer tests.PrintCurrentTest(t)()
-
-		req := NewRequest(t, "GET", "/api/v1/repos/user2/repo1/forks").AddTokenAuth(token)
-		resp := MakeRequest(t, req, http.StatusOK)
-
-		var forks []*api.Repository
-		DecodeJSON(t, resp, &forks)
-
-		assert.Len(t, forks, 1)
-		assert.EqualValues(t, "1", resp.Header().Get("X-Total-Count"))
-	})
-}

tests/integration/api_twofa_test.go

@@ -15,7 +15,6 @@ import (
 	"code.gitea.io/gitea/tests"
 
 	"github.com/pquerna/otp/totp"
-	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 )
 
@@ -59,24 +58,3 @@ func TestAPITwoFactor(t *testing.T) {
 	req.Header.Set("X-Forgejo-OTP", passcode)
 	MakeRequest(t, req, http.StatusOK)
 }
-
-func TestAPIWebAuthn(t *testing.T) {
-	defer tests.PrepareTestEnv(t)()
-
-	user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 32})
-	unittest.AssertExistsAndLoadBean(t, &auth_model.WebAuthnCredential{UserID: user.ID})
-
-	req := NewRequest(t, "GET", "/api/v1/user")
-	req.SetBasicAuth(user.Name, "notpassword")
-
-	resp := MakeRequest(t, req, http.StatusUnauthorized)
-
-	type userResponse struct {
-		Message string `json:"message"`
-	}
-	var userParsed userResponse
-
-	DecodeJSON(t, resp, &userParsed)
-
-	assert.EqualValues(t, "Basic authorization is not allowed while having security keys enrolled", userParsed.Message)
-}

tests/integration/api_wiki_test.go

@@ -9,7 +9,6 @@ import (
 	"encoding/base64"
 	"fmt"
 	"net/http"
-	"net/url"
 	"testing"
 
 	auth_model "code.gitea.io/gitea/models/auth"
@@ -207,11 +206,11 @@ func TestAPIListWikiPages(t *testing.T) {
 }
 
 func TestAPINewWikiPage(t *testing.T) {
-	defer tests.PrepareTestEnv(t)()
 	for _, title := range []string{
 		"New page",
 		"&&&&",
 	} {
+		defer tests.PrepareTestEnv(t)()
 		username := "user2"
 		session := loginUser(t, username)
 		token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeWriteRepository)
@@ -387,26 +386,26 @@ func TestAPIListPageRevisions(t *testing.T) {
 }
 
 func TestAPIWikiNonMasterBranch(t *testing.T) {
-	onGiteaRun(t, func(t *testing.T, _ *url.URL) {
+	defer tests.PrepareTestEnv(t)()
-		user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 1})
-		repo, _, f := tests.CreateDeclarativeRepoWithOptions(t, user, tests.DeclarativeRepoOptions{
-			WikiBranch: optional.Some("main"),
-		})
-		defer f()
 
-		uris := []string{
+	user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 1})
-			"revisions/Home",
+	repo, _, f := tests.CreateDeclarativeRepoWithOptions(t, user, tests.DeclarativeRepoOptions{
-			"pages",
+		WikiBranch: optional.Some("main"),
-			"page/Home",
-		}
-		baseURL := fmt.Sprintf("/api/v1/repos/%s/wiki", repo.FullName())
-		for _, uri := range uris {
-			t.Run(uri, func(t *testing.T) {
-				defer tests.PrintCurrentTest(t)()
-
-				req := NewRequestf(t, "GET", "%s/%s", baseURL, uri)
-				MakeRequest(t, req, http.StatusOK)
-			})
-		}
 	})
+	defer f()
+
+	uris := []string{
+		"revisions/Home",
+		"pages",
+		"page/Home",
+	}
+	baseURL := fmt.Sprintf("/api/v1/repos/%s/wiki", repo.FullName())
+	for _, uri := range uris {
+		t.Run(uri, func(t *testing.T) {
+			defer tests.PrintCurrentTest(t)()
+
+			req := NewRequestf(t, "GET", "%s/%s", baseURL, uri)
+			MakeRequest(t, req, http.StatusOK)
+		})
+	}
 }

tests/integration/auth_token_test.go

@@ -84,7 +84,7 @@ func TestLTACookie(t *testing.T) {
 	assert.True(t, found)
 	rawValidator, err := hex.DecodeString(validator)
 	require.NoError(t, err)
-	unittest.AssertExistsAndLoadBean(t, &auth.AuthorizationToken{LookupKey: lookupKey, HashedValidator: auth.HashValidator(rawValidator), UID: user.ID, Purpose: auth.LongTermAuthorization})
+	unittest.AssertExistsAndLoadBean(t, &auth.AuthorizationToken{LookupKey: lookupKey, HashedValidator: auth.HashValidator(rawValidator), UID: user.ID})
 
 	// Check if the LTA cookie it provides authentication.
 	// If LTA cookie provides authentication /user/login shouldn't return status 200.
@@ -143,7 +143,7 @@ func TestLTAExpiry(t *testing.T) {
 	assert.True(t, found)
 
 	// Ensure it's not expired.
-	lta := unittest.AssertExistsAndLoadBean(t, &auth.AuthorizationToken{UID: user.ID, LookupKey: lookupKey, Purpose: auth.LongTermAuthorization})
+	lta := unittest.AssertExistsAndLoadBean(t, &auth.AuthorizationToken{UID: user.ID, LookupKey: lookupKey})
 	assert.False(t, lta.IsExpired())
 
 	// Manually stub LTA's expiry.
@@ -151,7 +151,7 @@ func TestLTAExpiry(t *testing.T) {
 	require.NoError(t, err)
 
 	// Ensure it's expired.
-	lta = unittest.AssertExistsAndLoadBean(t, &auth.AuthorizationToken{UID: user.ID, LookupKey: lookupKey, Purpose: auth.LongTermAuthorization})
+	lta = unittest.AssertExistsAndLoadBean(t, &auth.AuthorizationToken{UID: user.ID, LookupKey: lookupKey})
 	assert.True(t, lta.IsExpired())
 
 	// Should return 200 OK, because LTA doesn't provide authorization anymore.
@@ -160,5 +160,5 @@ func TestLTAExpiry(t *testing.T) {
 	session.MakeRequest(t, req, http.StatusOK)
 
 	// Ensure it's deleted.
-	unittest.AssertNotExistsBean(t, &auth.AuthorizationToken{UID: user.ID, LookupKey: lookupKey, Purpose: auth.LongTermAuthorization})
+	unittest.AssertNotExistsBean(t, &auth.AuthorizationToken{UID: user.ID, LookupKey: lookupKey})
 }

tests/integration/easymde_test.go

@@ -6,12 +6,9 @@ package integration
 import (
 	"net/http"
 	"testing"
-
-	"code.gitea.io/gitea/tests"
 )
 
 func TestEasyMDESwitch(t *testing.T) {
-	defer tests.PrepareTestEnv(t)()
 	session := loginUser(t, "user2")
 	testEasyMDESwitch(t, session, "user2/glob/issues/1", false)
 	testEasyMDESwitch(t, session, "user2/glob/issues/new", false)

tests/integration/fixtures/TestFeed/team.yml

@@ -1,21 +0,0 @@
--
-  id: 1001
-  org_id: 3
-  lower_name: no_code
-  name: no_code
-  authorize: 1 # read
-  num_repos: 1
-  num_members: 1
-  includes_all_repositories: false
-  can_create_org_repo: false
-
--
-  id: 1002
-  org_id: 3
-  lower_name: read_code
-  name: no_code
-  authorize: 1 # read
-  num_repos: 1
-  num_members: 1
-  includes_all_repositories: false
-  can_create_org_repo: false

tests/integration/fixtures/TestFeed/team_repo.yml

@@ -1,11 +0,0 @@
--
-  id: 1001
-  org_id: 3
-  team_id: 1001
-  repo_id: 3
-
--
-  id: 1002
-  org_id: 3
-  team_id: 1002
-  repo_id: 3

tests/integration/fixtures/TestFeed/team_unit.yml

@@ -1,83 +0,0 @@
--
-  id: 1001
-  team_id: 1001
-  type: 1
-  access_mode: 0
-
--
-  id: 1002
-  team_id: 1001
-  type: 2
-  access_mode: 1
-
--
-  id: 1003
-  team_id: 1001
-  type: 3
-  access_mode: 1
-
--
-  id: 1004
-  team_id: 1001
-  type: 4
-  access_mode: 1
-
--
-  id: 1005
-  team_id: 1001
-  type: 5
-  access_mode: 1
-
--
-  id: 1006
-  team_id: 1001
-  type: 6
-  access_mode: 1
-
--
-  id: 1007
-  team_id: 1001
-  type: 7
-  access_mode: 1
-
--
-  id: 1008
-  team_id: 1002
-  type: 1
-  access_mode: 1
-
--
-  id: 1009
-  team_id: 1002
-  type: 2
-  access_mode: 1
-
--
-  id: 1010
-  team_id: 1002
-  type: 3
-  access_mode: 1
-
--
-  id: 1011
-  team_id: 1002
-  type: 4
-  access_mode: 1
-
--
-  id: 1012
-  team_id: 1002
-  type: 5
-  access_mode: 1
-
--
-  id: 1013
-  team_id: 1002
-  type: 6
-  access_mode: 1
-
--
-  id: 1014
-  team_id: 1002
-  type: 7
-  access_mode: 1

tests/integration/fixtures/TestFeed/team_user.yml

@@ -1,11 +0,0 @@
--
-  id: 1001
-  org_id: 3
-  team_id: 1001
-  uid: 8
-
--
-  id: 1002
-  org_id: 3
-  team_id: 1002
-  uid: 9

tests/integration/git_clone_wiki_test.go

@@ -13,6 +13,7 @@ import (
 
 	"code.gitea.io/gitea/modules/git"
 	"code.gitea.io/gitea/modules/util"
+	"code.gitea.io/gitea/tests"
 
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
@@ -32,6 +33,8 @@ func assertFileEqual(t *testing.T, p string, content []byte) {
 
 func TestRepoCloneWiki(t *testing.T) {
 	onGiteaRun(t, func(t *testing.T, u *url.URL) {
+		defer tests.PrepareTestEnv(t)()
+
 		dstPath := t.TempDir()
 
 		r := fmt.Sprintf("%suser2/repo1.wiki.git", u.String())

tests/integration/git_helper_for_declarative_test.go

@@ -12,7 +12,6 @@ import (
 	"os"
 	"path"
 	"path/filepath"
-	"regexp"
 	"strconv"
 	"testing"
 	"time"
@@ -60,8 +59,6 @@ func createSSHUrl(gitPath string, u *url.URL) *url.URL {
 	return &u2
 }
 
-var rootPathRe = regexp.MustCompile("\\[repository\\]\nROOT\\s=\\s.*")
-
 func onGiteaRun[T testing.TB](t T, callback func(T, *url.URL)) {
 	defer tests.PrepareTestEnv(t, 1)()
 	s := http.Server{
@@ -80,13 +77,7 @@ func onGiteaRun[T testing.TB](t T, callback func(T, *url.URL)) {
 	require.NoError(t, err)
 	u.Host = listener.Addr().String()
 
-	// Override repository root in config.
-	conf, err := os.ReadFile(setting.CustomConf)
-	require.NoError(t, err)
-	require.NoError(t, os.WriteFile(setting.CustomConf, rootPathRe.ReplaceAll(conf, []byte("[repository]\nROOT = "+setting.RepoRootPath)), 0o600))
-
 	defer func() {
-		require.NoError(t, os.WriteFile(setting.CustomConf, conf, 0o600))
 		ctx, cancel := context.WithTimeout(context.Background(), 2*time.Minute)
 		s.Shutdown(ctx)
 		cancel()

tests/integration/incoming_email_test.go

@@ -4,7 +4,6 @@
 package integration
 
 import (
-	"encoding/base32"
 	"io"
 	"net"
 	"net/smtp"
@@ -76,51 +75,6 @@ func TestIncomingEmail(t *testing.T) {
 		assert.Equal(t, payload, p)
 	})
 
-	tokenEncoding := base32.StdEncoding.WithPadding(base32.NoPadding)
-	t.Run("Deprecated token version", func(t *testing.T) {
-		defer tests.PrintCurrentTest(t)()
-
-		payload := []byte{1, 2, 3, 4, 5}
-
-		token, err := token_service.CreateToken(token_service.ReplyHandlerType, user, payload)
-		require.NoError(t, err)
-		assert.NotEmpty(t, token)
-
-		// Set the token to version 1.
-		unencodedToken, err := tokenEncoding.DecodeString(token)
-		require.NoError(t, err)
-		unencodedToken[0] = 1
-		token = tokenEncoding.EncodeToString(unencodedToken)
-
-		ht, u, p, err := token_service.ExtractToken(db.DefaultContext, token)
-		require.ErrorContains(t, err, "unsupported token version: 1")
-		assert.Equal(t, token_service.UnknownHandlerType, ht)
-		assert.Nil(t, u)
-		assert.Nil(t, p)
-	})
-
-	t.Run("MAC check", func(t *testing.T) {
-		defer tests.PrintCurrentTest(t)()
-
-		payload := []byte{1, 2, 3, 4, 5}
-
-		token, err := token_service.CreateToken(token_service.ReplyHandlerType, user, payload)
-		require.NoError(t, err)
-		assert.NotEmpty(t, token)
-
-		// Modify the MAC.
-		unencodedToken, err := tokenEncoding.DecodeString(token)
-		require.NoError(t, err)
-		unencodedToken[len(unencodedToken)-1] ^= 0x01
-		token = tokenEncoding.EncodeToString(unencodedToken)
-
-		ht, u, p, err := token_service.ExtractToken(db.DefaultContext, token)
-		require.ErrorContains(t, err, "verification failed")
-		assert.Equal(t, token_service.UnknownHandlerType, ht)
-		assert.Nil(t, u)
-		assert.Nil(t, p)
-	})
-
 	t.Run("Handler", func(t *testing.T) {
 		t.Run("Reply", func(t *testing.T) {
 			checkReply := func(t *testing.T, payload []byte, issue *issues_model.Issue, commentType issues_model.CommentType) {

tests/integration/mirror_push_test.go

@@ -323,82 +323,3 @@ func TestSSHPushMirror(t *testing.T) {
 		})
 	})
 }
-
-func TestPushMirrorSettings(t *testing.T) {
-	onGiteaRun(t, func(t *testing.T, u *url.URL) {
-		defer test.MockVariableValue(&setting.Migrations.AllowLocalNetworks, true)()
-		defer test.MockVariableValue(&setting.Mirror.Enabled, true)()
-		require.NoError(t, migrations.Init())
-
-		user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
-		srcRepo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 2})
-		srcRepo2 := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 3})
-		assert.False(t, srcRepo.HasWiki())
-		sess := loginUser(t, user.Name)
-		pushToRepo, _, f := tests.CreateDeclarativeRepoWithOptions(t, user, tests.DeclarativeRepoOptions{
-			Name:         optional.Some("push-mirror-test"),
-			AutoInit:     optional.Some(false),
-			EnabledUnits: optional.Some([]unit.Type{unit.TypeCode}),
-		})
-		defer f()
-
-		t.Run("Adding", func(t *testing.T) {
-			defer tests.PrintCurrentTest(t)()
-
-			req := NewRequestWithValues(t, "POST", fmt.Sprintf("/%s/settings", srcRepo2.FullName()), map[string]string{
-				"_csrf":                GetCSRF(t, sess, fmt.Sprintf("/%s/settings", srcRepo2.FullName())),
-				"action":               "push-mirror-add",
-				"push_mirror_address":  u.String() + pushToRepo.FullName(),
-				"push_mirror_interval": "0",
-			})
-			sess.MakeRequest(t, req, http.StatusSeeOther)
-
-			req = NewRequestWithValues(t, "POST", fmt.Sprintf("/%s/settings", srcRepo.FullName()), map[string]string{
-				"_csrf":                GetCSRF(t, sess, fmt.Sprintf("/%s/settings", srcRepo.FullName())),
-				"action":               "push-mirror-add",
-				"push_mirror_address":  u.String() + pushToRepo.FullName(),
-				"push_mirror_interval": "0",
-			})
-			sess.MakeRequest(t, req, http.StatusSeeOther)
-
-			flashCookie := sess.GetCookie(gitea_context.CookieNameFlash)
-			assert.NotNil(t, flashCookie)
-			assert.Contains(t, flashCookie.Value, "success")
-		})
-
-		mirrors, _, err := repo_model.GetPushMirrorsByRepoID(db.DefaultContext, srcRepo.ID, db.ListOptions{})
-		require.NoError(t, err)
-		assert.Len(t, mirrors, 1)
-		mirrorID := mirrors[0].ID
-
-		mirrors, _, err = repo_model.GetPushMirrorsByRepoID(db.DefaultContext, srcRepo2.ID, db.ListOptions{})
-		require.NoError(t, err)
-		assert.Len(t, mirrors, 1)
-
-		t.Run("Interval", func(t *testing.T) {
-			defer tests.PrintCurrentTest(t)()
-
-			unittest.AssertExistsAndLoadBean(t, &repo_model.PushMirror{ID: mirrorID - 1})
-
-			req := NewRequestWithValues(t, "POST", fmt.Sprintf("/%s/settings", srcRepo.FullName()), map[string]string{
-				"_csrf":                GetCSRF(t, sess, fmt.Sprintf("/%s/settings", srcRepo.FullName())),
-				"action":               "push-mirror-update",
-				"push_mirror_id":       strconv.FormatInt(mirrorID-1, 10),
-				"push_mirror_interval": "10m0s",
-			})
-			sess.MakeRequest(t, req, http.StatusNotFound)
-
-			req = NewRequestWithValues(t, "POST", fmt.Sprintf("/%s/settings", srcRepo.FullName()), map[string]string{
-				"_csrf":                GetCSRF(t, sess, fmt.Sprintf("/%s/settings", srcRepo.FullName())),
-				"action":               "push-mirror-update",
-				"push_mirror_id":       strconv.FormatInt(mirrorID, 10),
-				"push_mirror_interval": "10m0s",
-			})
-			sess.MakeRequest(t, req, http.StatusSeeOther)
-
-			flashCookie := sess.GetCookie(gitea_context.CookieNameFlash)
-			assert.NotNil(t, flashCookie)
-			assert.Contains(t, flashCookie.Value, "success")
-		})
-	})
-}

tests/integration/org_team_invite_test.go

@@ -10,7 +10,6 @@ import (
 	"strings"
 	"testing"
 
-	"code.gitea.io/gitea/models/auth"
 	"code.gitea.io/gitea/models/db"
 	"code.gitea.io/gitea/models/organization"
 	"code.gitea.io/gitea/models/unittest"
@@ -294,10 +293,8 @@ func TestOrgTeamEmailInviteRedirectsNewUserWithActivation(t *testing.T) {
 	require.NoError(t, err)
 	session.jar.SetCookies(baseURL, cr.Cookies())
 
-	code, err := user.GenerateEmailAuthorizationCode(db.DefaultContext, auth.UserActivation)
+	activateURL := fmt.Sprintf("/user/activate?code=%s", user.GenerateEmailActivateCode("doesnotexist@example.com"))
-	require.NoError(t, err)
+	req = NewRequestWithValues(t, "POST", activateURL, map[string]string{
-
-	req = NewRequestWithValues(t, "POST", "/user/activate?code="+url.QueryEscape(code), map[string]string{
 		"password": "examplePassword!1",
 	})
 

tests/integration/repo_fork_test.go

@@ -17,7 +17,6 @@ import (
 	"code.gitea.io/gitea/models/unittest"
 	user_model "code.gitea.io/gitea/models/user"
 	"code.gitea.io/gitea/modules/setting"
-	"code.gitea.io/gitea/modules/structs"
 	"code.gitea.io/gitea/modules/test"
 	"code.gitea.io/gitea/routers"
 	repo_service "code.gitea.io/gitea/services/repository"
@@ -239,34 +238,3 @@ func TestRepoForkToOrg(t *testing.T) {
 		})
 	})
 }
-
-func TestForkListPrivateRepo(t *testing.T) {
-	forkItemSelector := ".tw-flex.tw-items-center.tw-py-2"
-
-	onGiteaRun(t, func(t *testing.T, u *url.URL) {
-		session := loginUser(t, "user5")
-		org23 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 23, Visibility: structs.VisibleTypePrivate})
-
-		testRepoFork(t, session, "user2", "repo1", org23.Name, "repo1")
-
-		t.Run("Anomynous", func(t *testing.T) {
-			defer tests.PrintCurrentTest(t)()
-
-			req := NewRequest(t, "GET", "/user2/repo1/forks")
-			resp := MakeRequest(t, req, http.StatusOK)
-			htmlDoc := NewHTMLParser(t, resp.Body)
-
-			htmlDoc.AssertElement(t, forkItemSelector, false)
-		})
-
-		t.Run("Logged in", func(t *testing.T) {
-			defer tests.PrintCurrentTest(t)()
-
-			req := NewRequest(t, "GET", "/user2/repo1/forks")
-			resp := session.MakeRequest(t, req, http.StatusOK)
-			htmlDoc := NewHTMLParser(t, resp.Body)
-
-			htmlDoc.AssertElement(t, forkItemSelector, true)
-		})
-	})
-}

tests/integration/user_test.go

@@ -5,18 +5,14 @@
 package integration
 
 import (
-	"bytes"
-	"encoding/hex"
 	"fmt"
 	"net/http"
-	"net/url"
 	"strconv"
 	"strings"
 	"testing"
 	"time"
 
 	auth_model "code.gitea.io/gitea/models/auth"
-	"code.gitea.io/gitea/models/db"
 	issues_model "code.gitea.io/gitea/models/issues"
 	repo_model "code.gitea.io/gitea/models/repo"
 	unit_model "code.gitea.io/gitea/models/unit"
@@ -840,171 +836,3 @@ func TestUserRepos(t *testing.T) {
 		}
 	}
 }
-
-func TestUserActivate(t *testing.T) {
-	defer tests.PrepareTestEnv(t)()
-	defer test.MockVariableValue(&setting.Service.RegisterEmailConfirm, true)()
-
-	called := false
-	code := ""
-	defer test.MockVariableValue(&mailer.SendAsync, func(msgs ...*mailer.Message) {
-		called = true
-		assert.Len(t, msgs, 1)
-		assert.Equal(t, `"doesnotexist" <doesnotexist@example.com>`, msgs[0].To)
-		assert.EqualValues(t, translation.NewLocale("en-US").Tr("mail.activate_account"), msgs[0].Subject)
-
-		messageDoc := NewHTMLParser(t, bytes.NewBuffer([]byte(msgs[0].Body)))
-		link, ok := messageDoc.Find("a").Attr("href")
-		assert.True(t, ok)
-		u, err := url.Parse(link)
-		require.NoError(t, err)
-		code = u.Query()["code"][0]
-	})()
-
-	session := emptyTestSession(t)
-	req := NewRequestWithValues(t, "POST", "/user/sign_up", map[string]string{
-		"_csrf":     GetCSRF(t, session, "/user/sign_up"),
-		"user_name": "doesnotexist",
-		"email":     "doesnotexist@example.com",
-		"password":  "examplePassword!1",
-		"retype":    "examplePassword!1",
-	})
-	session.MakeRequest(t, req, http.StatusOK)
-	assert.True(t, called)
-
-	queryCode, err := url.QueryUnescape(code)
-	require.NoError(t, err)
-
-	lookupKey, validator, ok := strings.Cut(queryCode, ":")
-	assert.True(t, ok)
-
-	rawValidator, err := hex.DecodeString(validator)
-	require.NoError(t, err)
-
-	authToken, err := auth_model.FindAuthToken(db.DefaultContext, lookupKey, auth_model.UserActivation)
-	require.NoError(t, err)
-	assert.False(t, authToken.IsExpired())
-	assert.EqualValues(t, authToken.HashedValidator, auth_model.HashValidator(rawValidator))
-
-	req = NewRequest(t, "POST", "/user/activate?code="+code)
-	session.MakeRequest(t, req, http.StatusOK)
-
-	unittest.AssertNotExistsBean(t, &auth_model.AuthorizationToken{ID: authToken.ID})
-	unittest.AssertExistsAndLoadBean(t, &user_model.User{Name: "doesnotexist", IsActive: true})
-}
-
-func TestUserPasswordReset(t *testing.T) {
-	defer tests.PrepareTestEnv(t)()
-
-	user2 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
-
-	called := false
-	code := ""
-	defer test.MockVariableValue(&mailer.SendAsync, func(msgs ...*mailer.Message) {
-		if called {
-			return
-		}
-		called = true
-
-		assert.Len(t, msgs, 1)
-		assert.Equal(t, user2.EmailTo(), msgs[0].To)
-		assert.EqualValues(t, translation.NewLocale("en-US").Tr("mail.reset_password"), msgs[0].Subject)
-
-		messageDoc := NewHTMLParser(t, bytes.NewBuffer([]byte(msgs[0].Body)))
-		link, ok := messageDoc.Find("a").Attr("href")
-		assert.True(t, ok)
-		u, err := url.Parse(link)
-		require.NoError(t, err)
-		code = u.Query()["code"][0]
-	})()
-
-	session := emptyTestSession(t)
-	req := NewRequestWithValues(t, "POST", "/user/forgot_password", map[string]string{
-		"_csrf": GetCSRF(t, session, "/user/forgot_password"),
-		"email": user2.Email,
-	})
-	session.MakeRequest(t, req, http.StatusOK)
-	assert.True(t, called)
-
-	queryCode, err := url.QueryUnescape(code)
-	require.NoError(t, err)
-
-	lookupKey, validator, ok := strings.Cut(queryCode, ":")
-	assert.True(t, ok)
-
-	rawValidator, err := hex.DecodeString(validator)
-	require.NoError(t, err)
-
-	authToken, err := auth_model.FindAuthToken(db.DefaultContext, lookupKey, auth_model.PasswordReset)
-	require.NoError(t, err)
-	assert.False(t, authToken.IsExpired())
-	assert.EqualValues(t, authToken.HashedValidator, auth_model.HashValidator(rawValidator))
-
-	req = NewRequestWithValues(t, "POST", "/user/recover_account", map[string]string{
-		"_csrf":    GetCSRF(t, session, "/user/recover_account"),
-		"code":     code,
-		"password": "new_password",
-	})
-	session.MakeRequest(t, req, http.StatusSeeOther)
-
-	unittest.AssertNotExistsBean(t, &auth_model.AuthorizationToken{ID: authToken.ID})
-	assert.True(t, unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2}).ValidatePassword("new_password"))
-}
-
-func TestActivateEmailAddress(t *testing.T) {
-	defer tests.PrepareTestEnv(t)()
-	defer test.MockVariableValue(&setting.Service.RegisterEmailConfirm, true)()
-
-	user2 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
-
-	called := false
-	code := ""
-	defer test.MockVariableValue(&mailer.SendAsync, func(msgs ...*mailer.Message) {
-		if called {
-			return
-		}
-		called = true
-
-		assert.Len(t, msgs, 1)
-		assert.Equal(t, "newemail@example.org", msgs[0].To)
-		assert.EqualValues(t, translation.NewLocale("en-US").Tr("mail.activate_email"), msgs[0].Subject)
-
-		messageDoc := NewHTMLParser(t, bytes.NewBuffer([]byte(msgs[0].Body)))
-		link, ok := messageDoc.Find("a").Attr("href")
-		assert.True(t, ok)
-		u, err := url.Parse(link)
-		require.NoError(t, err)
-		code = u.Query()["code"][0]
-	})()
-
-	session := loginUser(t, user2.Name)
-	req := NewRequestWithValues(t, "POST", "/user/settings/account/email", map[string]string{
-		"_csrf": GetCSRF(t, session, "/user/settings"),
-		"email": "newemail@example.org",
-	})
-	session.MakeRequest(t, req, http.StatusSeeOther)
-	assert.True(t, called)
-
-	queryCode, err := url.QueryUnescape(code)
-	require.NoError(t, err)
-
-	lookupKey, validator, ok := strings.Cut(queryCode, ":")
-	assert.True(t, ok)
-
-	rawValidator, err := hex.DecodeString(validator)
-	require.NoError(t, err)
-
-	authToken, err := auth_model.FindAuthToken(db.DefaultContext, lookupKey, auth_model.EmailActivation("newemail@example.org"))
-	require.NoError(t, err)
-	assert.False(t, authToken.IsExpired())
-	assert.EqualValues(t, authToken.HashedValidator, auth_model.HashValidator(rawValidator))
-
-	req = NewRequestWithValues(t, "POST", "/user/activate_email", map[string]string{
-		"code":  code,
-		"email": "newemail@example.org",
-	})
-	session.MakeRequest(t, req, http.StatusSeeOther)
-
-	unittest.AssertNotExistsBean(t, &auth_model.AuthorizationToken{ID: authToken.ID})
-	unittest.AssertExistsAndLoadBean(t, &user_model.EmailAddress{UID: user2.ID, IsActivated: true, Email: "newemail@example.org"})
-}

tests/test_utils.go

@@ -48,8 +48,6 @@ func exitf(format string, args ...any) {
 	os.Exit(1)
 }
 
-var preparedDir string
-
 func InitTest(requireGitea bool) {
 	log.RegisterEventWriter("test", testlogger.NewTestLoggerWriter)
 
@@ -182,43 +180,6 @@ func InitTest(requireGitea bool) {
 		setting.Database.Path = ":memory:"
 	}
 
-	setting.Repository.Local.LocalCopyPath = os.TempDir()
-	dir, err := os.MkdirTemp("", "prepared-forgejo")
-	if err != nil {
-		log.Fatal("os.MkdirTemp: %v", err)
-	}
-	preparedDir = dir
-
-	setting.Repository.Local.LocalCopyPath, err = os.MkdirTemp("", "local-upload")
-	if err != nil {
-		log.Fatal("os.MkdirTemp: %v", err)
-	}
-
-	if err := unittest.CopyDir(path.Join(filepath.Dir(setting.AppPath), "tests/gitea-repositories-meta"), dir); err != nil {
-		log.Fatal("os.RemoveAll: %v", err)
-	}
-	ownerDirs, err := os.ReadDir(dir)
-	if err != nil {
-		log.Fatal("os.ReadDir: %v", err)
-	}
-
-	for _, ownerDir := range ownerDirs {
-		if !ownerDir.Type().IsDir() {
-			continue
-		}
-		repoDirs, err := os.ReadDir(filepath.Join(dir, ownerDir.Name()))
-		if err != nil {
-			log.Fatal("os.ReadDir: %v", err)
-		}
-		for _, repoDir := range repoDirs {
-			_ = os.MkdirAll(filepath.Join(dir, ownerDir.Name(), repoDir.Name(), "objects", "pack"), 0o755)
-			_ = os.MkdirAll(filepath.Join(dir, ownerDir.Name(), repoDir.Name(), "objects", "info"), 0o755)
-			_ = os.MkdirAll(filepath.Join(dir, ownerDir.Name(), repoDir.Name(), "refs", "heads"), 0o755)
-			_ = os.MkdirAll(filepath.Join(dir, ownerDir.Name(), repoDir.Name(), "refs", "tag"), 0o755)
-			_ = os.MkdirAll(filepath.Join(dir, ownerDir.Name(), repoDir.Name(), "refs", "pull"), 0o755)
-		}
-	}
-
 	routers.InitWebInstalled(graceful.GetManager().HammerContext())
 }
 
@@ -267,10 +228,28 @@ func cancelProcesses(t testing.TB, delay time.Duration) {
 }
 
 func PrepareGitRepoDirectory(t testing.TB) {
-	var err error
+	require.NoError(t, util.RemoveAll(setting.RepoRootPath))
-	setting.RepoRootPath, err = os.MkdirTemp(t.TempDir(), "forgejo-repo-rooth")
+	require.NoError(t, unittest.CopyDir(path.Join(filepath.Dir(setting.AppPath), "tests/gitea-repositories-meta"), setting.RepoRootPath))
-	require.NoError(t, err)
+	ownerDirs, err := os.ReadDir(setting.RepoRootPath)
-	require.NoError(t, unittest.CopyDir(preparedDir, setting.RepoRootPath))
+	if err != nil {
+		require.NoError(t, err, "unable to read the new repo root: %v\n", err)
+	}
+	for _, ownerDir := range ownerDirs {
+		if !ownerDir.Type().IsDir() {
+			continue
+		}
+		repoDirs, err := os.ReadDir(filepath.Join(setting.RepoRootPath, ownerDir.Name()))
+		if err != nil {
+			require.NoError(t, err, "unable to read the new repo root: %v\n", err)
+		}
+		for _, repoDir := range repoDirs {
+			_ = os.MkdirAll(filepath.Join(setting.RepoRootPath, ownerDir.Name(), repoDir.Name(), "objects", "pack"), 0o755)
+			_ = os.MkdirAll(filepath.Join(setting.RepoRootPath, ownerDir.Name(), repoDir.Name(), "objects", "info"), 0o755)
+			_ = os.MkdirAll(filepath.Join(setting.RepoRootPath, ownerDir.Name(), repoDir.Name(), "refs", "heads"), 0o755)
+			_ = os.MkdirAll(filepath.Join(setting.RepoRootPath, ownerDir.Name(), repoDir.Name(), "refs", "tag"), 0o755)
+			_ = os.MkdirAll(filepath.Join(setting.RepoRootPath, ownerDir.Name(), repoDir.Name(), "refs", "pull"), 0o755)
+		}
+	}
 }
 
 func PrepareArtifactsStorage(t testing.TB) {