1419 commits

Author	SHA1	Message	Date
wxiaoguang	48c4a7e75c	Rewrite the DiffFileTreeItem and fix misalignment (#26565) ... Fix some layout / user-interaction problems and close #25650 , the code has been simplified (+46 −108) <details>  </details> --------- Co-authored-by: delvh <dev.lh@web.de>	2023-08-18 19:55:56 +00:00
silverwind	30e5278d1b	Allow text selection in actions step header (#26588)	2023-08-18 18:38:29 +00:00
wxiaoguang	e5b3f53d36	Add minimum polyfill to support "relative-time-element" in PaleMoon (#26575) ... Close #26525	2023-08-18 17:27:11 +08:00
wxiaoguang	fe2b9274b1	Fix various line-height styles (#26553) ... Fix #26537 Use the same default line-height as "normalize.css" instead of "1". "1" is not right because it doesn't work with descent part and causes overflow problems.  --------- Co-authored-by: silverwind <me@silverwind.io>	2023-08-17 21:50:32 +00:00
silverwind	376c0e25f7	Remove fomantic transition module (#26469) ... Removes all dropdown and dimmer animations. Works everywhere as far as I can tell, but need to give this thorough testing. Removes around 70kb JS/CSS. Note, I'm not 100% sure regarding the various callbacks, those will need more investigation, but it appears to work nonetheless. Fixes: https://github.com/go-gitea/gitea/issues/15709	2023-08-16 22:12:40 +00:00
silverwind	3e044d2c9f	Use unique class for breadcrumb divider (#26524) ... Fix regression from https://github.com/go-gitea/gitea/pull/25539: https://github.com/go-gitea/gitea/pull/26519#issuecomment-1678825200. Before: <img width="429" alt="Screenshot 2023-08-15 at 15 46 12" src="https://github.com/go-gitea/gitea/assets/115237/a818f60a-77a2-48fe-8e6f-363d152ccb1e"> After: <img width="424" alt="Screenshot 2023-08-15 at 15 46 19" src="https://github.com/go-gitea/gitea/assets/115237/c90159e2-ced2-4a74-8a0f-a1b2b5d0b565"> <img width="605" alt="Screenshot 2023-08-15 at 15 56 11" src="https://github.com/go-gitea/gitea/assets/115237/3ded6f57-86f4-422a-86cb-56dd2c216dee">	2023-08-16 00:08:23 +00:00
yp05327	8703b6c954	Improve clickable area in repo action view page (#26115) ... Before:  After:  In current design, the clickable area is too small, and it is hard to find the correct clickable area as the area with background color (div with class name `job-brief-item selected`) is bigger than it. --------- Co-authored-by: Giteabot <teabot@gitea.io>	2023-08-16 00:44:43 +02:00
wxiaoguang	c7fd9ad8b4	Fix dark theme highlight for "NameNamespace" (#26519) ... The color is taken from "Name" Before:  After:  Co-authored-by: Giteabot <teabot@gitea.io>	2023-08-16 00:10:10 +02:00
silverwind	7563891cc4	Remove duplicate CSS import for chroma/base.css (#26523)	2023-08-16 05:13:56 +08:00
silverwind	27e4ac3e40	Use hidden over clip for text truncation (#26520) ... Avoid browser bugs: - Firefox not cutting off - https://github.com/go-gitea/gitea/pull/26354#issuecomment-1678456052 - Safari not showing ellipsis - https://github.com/go-gitea/gitea/pull/26354#issuecomment-1678812801	2023-08-15 13:23:51 +00:00
wxiaoguang	d317c983bc	Set "type=button" for editor's toolbar buttons (#26510) ... The editor usually is in a form, so the buttons should have "type=button", avoid conflicting with the form's submit.	2023-08-15 19:31:48 +08:00
a1012112796	19872063a3	add disable workflow feature (#26413) ... As title, that's simmilar with github.   --------- Signed-off-by: a1012112796 <1012112796@qq.com> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Jason Song <i@wolfogre.com>	2023-08-14 15:14:30 +00:00
wxiaoguang	253737eb36	Move dropzone progress bar to bottom to show filename when uploading (#26492) ... 1. Make the "filename" visible 2. Avoiding UI flicker when the uploading is completing	2023-08-14 22:36:53 +08:00
puni9869	cafce3b4b5	Allow to archive labels (#26478) ... ## Archived labels This adds the structure to allow for archived labels. Archived labels are, just like closed milestones or projects, a medium to hide information without deleting it. It is especially useful if there are outdated labels that should no longer be used without deleting the label entirely. ## Changes 1. UI and API have been equipped with the support to mark a label as archived 2. The time when a label has been archived will be stored in the DB ## Outsourced for the future There's no special handling for archived labels at the moment. This will be done in the future. ## Screenshots   Part of https://github.com/go-gitea/gitea/issues/25237 --------- Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-08-14 11:56:14 +02:00
silverwind	56b6b2b88e	Fix tooltip of commit select button (#26472) ... Previously, the tooltip for this button was only shown after opening and closing it once because it was only set after the server response, now it shows before opening it.	2023-08-14 02:16:40 +00:00
Denys Konovalov	ab78c39e41	Refactor project templates (#26448) ... This PR refactors a bunch of projects-related code, mostly the templates. The following things were done: - rename boards to columns in frontend code - use the new `ctx.Locale.Tr` method - cleanup template, remove useless newlines, classes, comments - merge org-/user and repo level project template together - move "new column" button into project toolbar - move issue card (shared by projects and pinned issues) to shared template, remove useless duplicated styles - add search function to projects (to make the layout more similar to milestones list where it is inherited from 😆) - maybe more changes I forgot I've done 😆 Closes #24893 After:    --------- Co-authored-by: silverwind <me@silverwind.io>	2023-08-12 10:30:28 +00:00
wxiaoguang	74930b1ccd	Avoiding accessing undefined mentionValues (#26461) ... The `window.config.mentionValues` might be undefined: ``` {{if or .Participants .Assignees .MentionableTeams}} mentionValues: ... {{end}} ```	2023-08-12 08:36:23 +00:00
silverwind	2fc0eb913c	Tweak actions menu (#26278) ... Ressurect lost changes from https://github.com/go-gitea/gitea/pull/24451. - Always show icons for each entry in the menu - Make all checkboxes toggle only their feature, e.g. "seconds" and "timestamps" can now be toggled on together. - Reorder the items <img width="845" alt="Screenshot 2023-08-01 at 19 19 27" src="https://github.com/go-gitea/gitea/assets/115237/8a76e9bf-7966-42a6-87c9-e88cdddaec82"> --------- Co-authored-by: Giteabot <teabot@gitea.io>	2023-08-12 08:26:53 +00:00
yp05327	918d0f033d	Fix the display of orgs listed in user profile (#26424) ... Before:  After:  In #26214, we changed each row's display into `flex` which caused this problem.   In old version:  Maybe we can add paddings here?  In old version; 	2023-08-11 03:28:36 +08:00
Maxim Slipenko	c2b6897e35	Fix text truncate (#26354) ... Fixes: https://github.com/go-gitea/gitea/issues/25597 Before:  After:  Co-authored-by: Giteabot <teabot@gitea.io>	2023-08-07 22:44:04 +02:00
Kerwin Bryant	865d2221c0	Add Retry button when creating a mirror-repo fails (#26228) ... fixed #26156 * Added a retry button in the frontend (only displayed when the status is abnormal) * After clicking Retry, the backend adds the task back to the task queue   --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-08-04 10:21:32 +08:00
wxiaoguang	539015403f	Fix the topic validation rule and suport dots (#26286) ... 1. Allow leading and trailing spaces by user input, these spaces have already been trimmed at backend 2. Allow using dots in the topic	2023-08-03 09:18:06 +00:00
Earl Warren	6ed4626ed5	Merge templates/projects/list.tmpl and templates/repo/projects/list.tmpl together (#26265) ... (cherry picked from commit 473862a1d5) Refs: https://codeberg.org/forgejo/forgejo/pulls/1126 Co-authored-by: Louis Seubert <louis.seubert.ls@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io>	2023-08-01 16:54:54 +00:00
Denys Konovalov	b9baed2c74	Introduce flex-list & flex-item elements for Gitea UI (#25790) ... This PR introduces a new UI element type for Gitea called `flex-item`. It consists of a horizontal card with a leading, main and trailing part:  The idea behind it is that in Gitea UI, we have many cases where we use this kind of layout, but it is achieved in many different ways: - grid layout - `.ui.list` with additional hacky flexbox - `.ui.key.list` - looks to me like a style set originally created for ssh/gpg key list, was used in many other places - `.issue.list` - created for issue cards, used in many other places - ... This new style is based on `.issue.list`, specifically the refactoring of it done in #25750. In this PR, the new element is introduced and lots of templates are being refactored to use that style. This allows to remove a lot of page-specific css, makes many of the elements responsive or simply provides a cleaner/better-looking way to present information. A devtest section with the new style is also available. <details> <summary>Screenshots (left: before, right: after)</summary>                    </details> --------- Co-authored-by: Giteabot <teabot@gitea.io>	2023-08-01 00:13:42 +02:00
Panagiotis "Ivory" Vasilopoulos	d58c542579	Add 'Show on a map' button to Location in profile, fix layout (#26214) ... Not too important, but I think that it'd be a pretty neat touch. Also fixes some layout bugs introduced by a previous PR. --------- Co-authored-by: Gusted <postmaster@gusted.xyz> Co-authored-by: Caesar Schinas <caesar@caesarschinas.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-07-31 08:44:45 +00:00
silverwind	7e160f8824	Reduce margins on user settings page, introduce flex-container (#26046) ... Same as https://github.com/go-gitea/gitea/pull/26026 but for the user settings page. It introduces a new `flex-container` class and shares it across both pages. Before and After: <img width="1264" alt="Screenshot 2023-07-21 at 19 35 57" src="https://github.com/go-gitea/gitea/assets/115237/1358dab4-55c0-40ce-a4d5-673099304f3d"> <img width="1269" alt="Screenshot 2023-07-21 at 19 35 42" src="https://github.com/go-gitea/gitea/assets/115237/34812f6d-dc65-4009-b977-90e03efdc6d1">	2023-07-31 07:16:03 +00:00
silverwind	aa723dea9b	Don't autosize textarea in diff view (#26233) ... Resizing the comment editor can be a very expensive operation because it triggers page reflows, which on large PRs can take upwards of seconds to complete. Disable this mechanism on the diff page only where we know that the page can get large. Fixes https://github.com/go-gitea/gitea/issues/26201 for the textarea editor. I don't think this can be fixed for EasyMDE because as far as I can tell, it exposes no option to disable this resizing. --------- Co-authored-by: Giteabot <teabot@gitea.io>	2023-07-31 00:11:15 +02:00
silverwind	72d89eb8dd	Fix attachment clipboard copy on insecure origin (#26224) ... Fixes: https://github.com/go-gitea/gitea/issues/26202 Actually later I found out the code did not use `clippie`, so I fixed it. The bug was never in the clippie module like I initially suspected. Also, I added a tooltip for feedback. <img width="139" alt="image" src="https://github.com/go-gitea/gitea/assets/115237/da501670-9c15-4412-969a-b559773c7ab9"> --------- Co-authored-by: Giteabot <teabot@gitea.io>	2023-07-30 00:56:45 +02:00
sebastian-sauer	55532061c8	Add commits dropdown in PR files view and allow commit by commit review (#25528) ... This PR adds a new dropdown to select a commit or a commit range (shift-click like github) of a Pull Request. After selection of a commit only the changes of this commit will be shown. When selecting a range of commits the diff of this range is shown. This allows to review a PR commit by commit or by viewing only commit ranges. The "Show changes since your last review" mechanism github uses is implemented, too. When reviewing a single commit or a commit range the "Viewed" functionality is disabled. ## Screenshots ### The commit dropdown  ### Selecting a commit range  ### Show changes of a single commit only  ### Show changes of a commit range  Fixes https://github.com/go-gitea/gitea/issues/20989 Fixes https://github.com/go-gitea/gitea/issues/19263 --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: KN4CK3R <admin@oldschoolhack.me> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: delvh <dev.lh@web.de>	2023-07-28 21:18:12 +02:00
puni9869	1d8d90fd37	Fixing the align of commit stats in commit_page template. (#26161) ... Fixing the align center to row and space around for commit_page template.	2023-07-28 13:12:44 -04:00
wxiaoguang	d88fed0db1	Hide branch/tag icon if branches/tags are empty (#26204) ... The branch/tag icons aren't hidden correctly if there is no branch/tag. This PR fixes it.	2023-07-28 23:05:24 +08:00
Earl Warren	eaea530d6b	Render plaintext task list items for markdown files (#26186) ... - The library that's being used for org-mode, [doesn't render the status of list items](https://github.com/niklasfasching/go-org/issues/63). - Add a modified version of the proposed CSS snippet to still display the status for the list items. The alternative was parsing HTML and transforming it, which is too complicated for this small task. - Resolves https://codeberg.org/Codeberg/Community/issues/1099 (cherry picked from commit 9753c7e4b8) Refs: https://codeberg.org/forgejo/forgejo/pulls/1071 Co-authored-by: Gusted <postmaster@gusted.xyz>	2023-07-27 14:15:31 +00:00
delvh	bd6ef71854	Show branches and tags that contain a commit (#25180) ... Now, you can see for a commit which existing branches and tags contain it. You first have to click on the `load branches and tags` button, they are not preloaded by default. All branches and tags are ordered descending by creation date. You can even see without much hassle if the given commit is already part of the default branch. Closes #25152 ## Screenshots ### Initial  ### Loaded  --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-07-27 12:47:41 +02:00
yp05327	36732005b4	Disable download action logs button when there's no logs (#26114) ... If there's no logs, you can also click the download button, then you will get `job is not started` page  https://gitea.com/yp05327/testrepo/actions/runs/38 After: If there's no steps displayed, the download button will be disabled. 	2023-07-26 20:51:26 +02:00
Jason Song	a5e09a5595	Fix UI regression of asciinema player (#26159) ... It was caused by updating `asciinema-player`, the upstream changed the CSS class prefix: `40505e479e` <details> <summary>Before:</summary> <img width="1320" alt="image" src="https://github.com/go-gitea/gitea/assets/9418365/b91a2cf5-c1da-43d6-bac2-bc278728b11e"> </details> <details> <summary>After:</summary> <img width="1311" alt="image" src="https://github.com/go-gitea/gitea/assets/9418365/c9872d25-e0bb-43d4-8b1e-d87c6b03c0a2"> </details>	2023-07-26 09:46:59 +00:00
Lunny Xiao	5dc37ef97a	Display deprecated warning in admin panel pages as well as in the log file (#26094) ... This PR includes #26007 's changes but have a UI to prompt administrator about the deprecated settings as well as the log or console warning. Then users will have enough time to notice the problem and don't have surprise like before. <img width="1293" alt="图片" src="https://github.com/go-gitea/gitea/assets/81045/c33355f0-1ea7-4fb3-ad43-cd23cd15391d"> --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-07-26 03:53:37 +00:00
silverwind	e62ea96ada	Increase table cell horizontal padding (#26140) ... Extract from https://github.com/go-gitea/gitea/pull/26043, just the padding increase. Before and After (hard to notice, but it's there): <img width="427" alt="Screenshot 2023-07-25 at 19 37 12" src="https://github.com/go-gitea/gitea/assets/115237/9543dcda-eccb-4739-b7dd-06b076108ab4"> <img width="420" alt="Screenshot 2023-07-25 at 19 37 26" src="https://github.com/go-gitea/gitea/assets/115237/0a9c3724-81a1-4c67-a13b-4b728a51fc3a"> Co-authored-by: Giteabot <teabot@gitea.io>	2023-07-25 23:54:20 +02:00
puni9869	5a56f9699c	Fix UI for release tag page / wiki page / subscription page (#25948) ... Agenda: This PR contains UI fixes for release tag page / wiki page / subscription page. Here is the list of changes made in this PR. 1. Release tag page a. In the New Release page the whole ui got change. Now it is covering in full page page with mobile view port. Description about the release the editor preview now has a min-height. and the check boxes for `Prerelease` and option are left aligned. Couple of divider are added. 2. Subscription page: a. In the subscription page the ui was distorted in mobile view. Now its fix. Couple of unused styles were removed. 3. Create Wiki page:- a. In the page the preview of markdown is now contains a fix min-height so this it will not distorted in desktop view and a divider is added before action buttons. Couple of unused styles were removed. # Before ## Release page <img width="1391" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/319dec2e-08cf-40c5-920a-d651930ee28e"> <img width="494" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/03249f40-2d36-4552-bb93-43832aac2f8b"> <img width="1390" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/bf8b2d31-4857-480b-abd9-66a3ae6e24d8"> <img width="484" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/c3a58210-a337-4c8e-89a6-edb3975986bb"> Editor <img width="958" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/3bdd299d-d12b-4774-ace9-7184b1a57b18"> Editor preview <img width="1293" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/2b61c528-c018-4800-ab86-07aae56adecd"> <img width="484" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/ff7bc5ee-9dc0-4f78-a0b1-94277ab27700"> #### After <img width="1439" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/94f7e073-5977-40bd-98ef-0711ed0815cc"> <img width="1384" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/83e3105f-c1ee-4329-b90f-8bb724dac50f"> <img width="1440" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/05f024a5-52eb-4072-8599-d6ca12f6fad1"> <img width="1387" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/c73f069b-572a-4a13-aaa9-fc5b4dd3420d"> <img width="1440" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/2f98f012-8e64-4a12-9595-5acdef18f85c"> Markdown preview change <img width="1368" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/31e583ec-48f6-4f1a-8b56-0164fcb127a5"> Wiki page Before <img width="1393" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/9c9cfdf6-3c2a-4f47-883b-76624d96f9a0"> <img width="499" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/522ad573-1ad2-4fa2-8bf7-48a3dded14e7"> Preview of mark down. <img width="488" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/998f3c25-9fca-43c8-b1ff-648aab291727"> Footer <img width="490" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/89c6cf4e-4599-4403-bac8-285efdd9361a"> After <img width="1389" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/1ee0fc72-f864-44c0-b2e4-e0e8a8470204"> <img width="498" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/b35b9a5d-8e26-4869-a6ed-6cef1f4a87a6"> <img width="499" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/b40bcbaa-fca6-42ab-9556-f950811b565d"> Preview tab block has min-height <img width="1392" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/4a53d6c2-596c-423a-91b1-533cef734f93"> Mobile view <img width="496" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/c5ffc4c9-3c21-4cad-bc32-2ea3f0644a08"> <img width="497" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/08dd560f-4333-41ec-95b9-8154910d2254"> <img width="496" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/9fba8f55-727b-4756-a4a6-2070c719b15b"> ## Subscription page ### Before <img width="1393" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/0a7d561b-f56c-4ebe-93bd-952abecd437f"> <img width="492" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/4dc44d0c-ea81-4130-8afb-8f271c029e8a"> After <img width="1394" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/a3567e30-2b5b-49d6-9ecb-2ab481ea4d36"> <img width="494" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/024da9e2-dfc4-4672-95cc-a6ac034d9712"> <img width="508" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/b748ecea-427c-4f8b-a1bf-08f82f9a42e6">	2023-07-25 17:53:16 +00:00
wxiaoguang	ad5ce59800	Improve commit graph alignment and truncating (#26112) ... Fix #26101 	2023-07-25 10:17:41 +00:00
JakobDev	6598d0291c	Allow Organisations to have a E-Mail (#25082) ... Resolves #25057 This adds a E-Mail field to Organisations. The E-Mail is just shown on the Profile when it is visited by a logged in User. The E-mail is not used for something else. **Screenshots:**   --------- Co-authored-by: Denys Konovalov <kontakt@denyskon.de> Co-authored-by: Denys Konovalov <privat@denyskon.de> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io>	2023-07-25 08:26:27 +00:00
wxiaoguang	a7e8273574	Fix the truncate and alignment problem for some admin tables (#26042) ... Some "text truncate email" code were just copied&pasted, they are not suitable for most admin tables. For the table layouts, some "max-width" helpers could be very helpful. At least, we can get rid of the confusing "email" CSS class.   	2023-07-22 10:54:48 +00:00
HesterG	2f0e79e639	Use frontend fetch for branch dropdown component (#25719) ... - Send request to get branch/tag list, use loading icon when waiting for response. - Only fetch when the first time branch/tag list shows. - For backend, removed assignment to `ctx.Data["Branches"]` and `ctx.Data["Tags"]` from `context/repo.go` and passed these data wherever needed. - Changed some `v-if` to `v-show` and used native `svg` as mentioned in https://github.com/go-gitea/gitea/pull/25719#issuecomment-1631712757 to improve perfomance when there are a lot of branches. - Places Used the dropdown component: Repo Home Page <img width="1429" alt="Screen Shot 2023-07-06 at 12 17 51" src="https://github.com/go-gitea/gitea/assets/17645053/6accc7b6-8d37-4e88-ae1a-bd2b3b927ea0"> Commits Page <img width="1431" alt="Screen Shot 2023-07-06 at 12 18 34" src="https://github.com/go-gitea/gitea/assets/17645053/2d0bf306-d1e2-45a8-a784-bc424879f537"> Specific commit -> operations -> cherry-pick <img width="758" alt="Screen Shot 2023-07-06 at 12 23 28" src="https://github.com/go-gitea/gitea/assets/17645053/1e557948-3881-4e45-a625-8ef36d45ae2d"> Release Page <img width="1433" alt="Screen Shot 2023-07-06 at 12 25 05" src="https://github.com/go-gitea/gitea/assets/17645053/3ec82af1-15a4-4162-a50b-04a9502161bb"> - Demo https://github.com/go-gitea/gitea/assets/17645053/d45d266b-3eb0-465a-82f9-57f78dc5f9f3 - Note: UI of dropdown menu could be improved in another PR as it should apply to more dropdown menus. Fix #14180 --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-07-21 11:20:04 +00:00
Yarden Shoham	dbbae67f44	Remove commit status running and warning from the dashboard repo list (#26036) ... Also added comments so the next time the dashboard repo list won't be forgotten Follows #25839 Signed-off-by: Yarden Shoham <git@yardenshoham.com>	2023-07-21 10:32:25 +00:00
yp05327	d57e55cd47	Fix escape problems in the branch selector (#25875) ... Fix #25865	2023-07-21 06:18:40 +00:00
silverwind	d021c88d29	Reduce margins on admin pages (#26026) ... Reduce margins around admin boxes and reduce sidebar size from 275px to 240px. This is the same 16px margin we use on issue pages. Before and After: <img width="1270" alt="Screenshot 2023-07-21 at 00 28 11" src="https://github.com/go-gitea/gitea/assets/115237/f9b0dcb0-8f7e-49b4-b130-54bf31c142fd"> <img width="1271" alt="Screenshot 2023-07-21 at 00 30 51" src="https://github.com/go-gitea/gitea/assets/115237/ddd75d59-9ab9-4061-8989-852e89727560">	2023-07-21 03:11:42 +00:00
FuXiaoHei	f3d293d2bb	Actions Artifacts support uploading multiple files and directories (#24874) ... current actions artifacts implementation only support single file artifact. To support multiple files uploading, it needs: - save each file to each db record with same run-id, same artifact-name and proper artifact-path - need change artifact uploading url without artifact-id, multiple files creates multiple artifact-ids - support `path` in download-artifact action. artifact should download to `{path}/{artifact-path}`. - in repo action view, it provides zip download link in artifacts list in summary page, no matter this artifact contains single or multiple files.	2023-07-21 10:42:01 +08:00
silverwind	36010243f7	Fix commit status color on dashboard repolist (#25993) ... Followup to https://github.com/go-gitea/gitea/pull/25935 which has missed to change the icon on the repolist because the logic is not shared with templates. Co-authored-by: Giteabot <teabot@gitea.io>	2023-07-20 01:04:41 +02:00
Earl Warren	e20f8f0977	Improve profile readme rendering (#25988) ... - Tell the renderer to use the `document` mode, so it's consistent with other renderers. - Use the same padding as `.file-view.markup`, so it's consistent with other containers that contain markup rendering. - Resolves https://codeberg.org/forgejo/forgejo/issues/833 Co-authored-by: Gusted <postmaster@gusted.xyz>	2023-07-19 22:22:32 +00:00
Earl Warren	8833853dd6	avoid hard-coding height in language dropdown menu (#25986) ... This commit removes the hard-coded height of 500px, using that as a max-height instead. The height of items in the dropdown menu, assuming a default font size of 16px, is 36px, so the old CSS would cause overly large dropdown menus in instances where less than 14 languages are offered. Refs: https://codeberg.org/forgejo/forgejo/pulls/1000 Co-authored-by: rome-user <rome-user@noreply.codeberg.org> Co-authored-by: Giteabot <teabot@gitea.io>	2023-07-19 23:30:57 +02:00
Jason Song	6f1f3e6c08	Show the mismatched ROOT_URL warning on the sign-in page if OAuth2 is enabled (#25947) ... Since OAuth2 will callback the root URL, if the user starts signing in from a wrong host, Gitea will return 500 because it cannot find the session. <details> <summary>How to reproduce</summary> <img width="901" alt="image" src="https://github.com/go-gitea/gitea/assets/9418365/2c2e255c-e13e-4a11-9be7-b226bee54920"> <img width="1014" alt="image" src="https://github.com/go-gitea/gitea/assets/9418365/b31cfcf6-a320-483d-9ce5-ba8562f065e1"> </details> So show the mismatched ROOT_URL warning on the sign-in page if OAuth2 is enabled. <img width="1015" alt="image" src="https://github.com/go-gitea/gitea/assets/9418365/99e80b17-c790-49a3-bbf2-2bd9396a7daa">	2023-07-18 22:14:30 +00:00
wxiaoguang	faa28b5a44	Move public asset files to the proper directory (#25907) ... Move `public/*` to `public/assets/*` Some old PRs (like #15219) introduced inconsistent directory system. For example: why the local directory "public" is accessed by `http://site/assets`? How to serve the ".well-known" files properly in the public directory? For convention rules, the "public" directory is widely used for the website's root directory. It shouldn't be an exception for Gitea. So, this PR makes the things consistent: * `http://site/assets/foo` means `{CustomPath}/public/assets/foo`. * `{CustomPath}/public/.well-known` and `{CustomPath}/public/robots.txt` can be used in the future. This PR is also a prerequisite for a clear solution for: * #21942 * #25892 * discourse.gitea.io: [.well-known path serving custom files behind proxy?](https://discourse.gitea.io/t/well-known-path-serving-custom-files-behind-proxy/5445/1) This PR is breaking for users who have custom "public" files (CSS/JS). After getting approvals, I will update the documents. ---- ## ⚠️ BREAKING ⚠️ If you have files in your "custom/public/" folder, please move them to "custom/public/assets/". --------- Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: Giteabot <teabot@gitea.io>	2023-07-18 18:06:43 +02:00
silverwind	8bb0a03eaa	Import sortablejs only once (#25936) ... Previously, `sortablejs` was imported twice, once synchronously and once asynchronously, leading to webpack creating duplicate output code (once in the index bundle, and once in a separate chunk). Fix this by always asynchronously importing it. This was one of the build warnings observed when trying to build with vite.	2023-07-17 18:06:37 +00:00
sebastian-sauer	d473de0c2d	Make add line comment buttons focusable (#25894) ... Use a real button and add an aria-label. Additionally, show the button whenever it is focused. See https://codeberg.org/forgejo/forgejo/issues/998 for explanation. Our handling of this button is now equal to that of GitHub. Nothing has changed visually.	2023-07-15 11:45:34 +02:00
sebastian-sauer	b81c013057	Don't stack PR tab menu on small screens (#25789) ... the stacking takes up screen space - display the tabs as the navigation bar. github uses the same layout. Screenshots (left before, right after):   Large screen: 	2023-07-14 01:54:20 +00:00
Denys Konovalov	eec45b43db	move issue filters to shared template (#25729) ... Issue filters are being used on repo list page and on milestone issues page, and the code is mostly duplicated. This PR does the following changes: - move issue filters into a shared template - allow filtering milestone issues by project, so no need to hide this filter on milestone issues page - remove some dead code (e. g. issue actions in milestone issues template) - fix label filter dropdown width --------- Co-authored-by: 6543 <6543@obermui.de>	2023-07-13 20:00:38 +00:00
wxiaoguang	fa0b5b14c2	Make "install page" respect environment config (#25648) ... Replace #25580 Fix #19453 The problem was: when users set "GITEA__XXX__YYY" , the "install page" doesn't respect it. So, to make the result consistent and avoid surprising end users, now the "install page" also writes the environment variables to the config file. And, to make things clear, there are enough messages on the UI to tell users what will happen. There are some necessary/related changes to `environment-to-ini.go`: * The "--clear" flag is removed and it was incorrectly written there. The "clear" operation should be done if INSTALL_LOCK=true * The "--prefix" flag is removed because it's never used, never documented and it only causes inconsistent behavior. 	2023-07-09 22:43:37 +00:00
Denys Konovalov	be23b73e85	Restructure issue list template, styles (#25750) ... This PR does various modifications on the issue list shared template: - restructure layout to achieve better responsiveness - fix various style issues - restructure styles (better result with less code :) - remove numerous `gt-*` patches and other unneeded classes -> use existing css classes <details> <summary>Before:</summary>    </details> <details> <summary>After:</summary>    </details> --------- Co-authored-by: silverwind <me@silverwind.io>	2023-07-09 19:38:01 +00:00
wxiaoguang	84c78650cc	Fix notification list bugs (#25781) ... Fix #25627 1. `ctx.Data["Link"]` should use relative URL but not AppURL 2. The `data-params` is incorrect because it doesn't contain "page". JS can simply use "window.location.search" to construct the AJAX URL 3. The `data-xxx` and `id` in notification_subscriptions.tmpl were copied&pasted, they don't have affect.	2023-07-09 18:42:31 +00:00
silverwind	38844e0869	Always pass 6-digit hex color to monaco (#25780) ... Monaco can not deal with color formats other than 6-digit hex, so we convert the colors for it via new [`tinycolor2`](https://github.com/bgrins/TinyColor) dependency (5kB minzipped). Also, with the addition of the module, we can replace the existing `hexToRGBColor` usage, I verified it is compatible with the current tests before removing the function. Fixes: https://github.com/go-gitea/gitea/issues/25770	2023-07-09 12:17:22 +02:00
silverwind	f8bb1018ae	Tweak repo topics bar (#25769) ... Minor tweaks to repo topics: - Use gap instead of margin to align "Manage Topics" when no topics present - Add margin to description instead Before: <img width="1232" alt="Screenshot 2023-07-08 at 13 08 15" src="https://github.com/go-gitea/gitea/assets/115237/a5d3586c-6cbf-4b74-8137-11d91f2cbb45"> <img width="1233" alt="Screenshot 2023-07-08 at 13 08 05" src="https://github.com/go-gitea/gitea/assets/115237/59b18d93-e4cb-4f2b-9bc2-d6aa63f93827"> After: <img width="1232" alt="Screenshot 2023-07-08 at 13 08 42" src="https://github.com/go-gitea/gitea/assets/115237/470d42ad-3f7e-40f9-b0a1-203b4af77eb9"> <img width="1231" alt="Screenshot 2023-07-08 at 13 08 32" src="https://github.com/go-gitea/gitea/assets/115237/42d18048-748c-4a3f-ab89-3403866cef34"> ---------	2023-07-08 18:12:30 +00:00
wxiaoguang	cc00fd50f3	Clarify "text-align" CSS helpers, fix clone button padding (#25763) ... Changes: * Rename gt-tl/gt-tc/gt-tr to gt-text-left/gt-text-center/gt-text-right * The gt-ab and gt-br-0 are removed because they are not needed anymore * Fix the clone dropdown button padding by ":not(.icon)" Before: <details>  </details> After: <details>  </details> Fixes #25758 Co-authored-by: Giteabot <teabot@gitea.io>	2023-07-08 11:53:56 +02:00
Denys Konovalov	753755bd4e	Fix commits table regression (#25710) ... Fixes #25693 The commits table appearance fix in #25634 was incomplete and caused a regression. This PR fixes that issue and removes some unneeded CSS classes because of the proper fix. <details> <summary>Before</summary>   </details> <details> <summary>After</summary>   </details> --------- Co-authored-by: silverwind <me@silverwind.io>	2023-07-06 23:07:57 +02:00
puni9869	2af30f715e	Fix inconsistent user profile layout across tabs (#25625) ... Fix ::User Profile Page Project Tab Have Inconsistent Layout and Style Added the big_avator for consistency in the all header_items tabs. Fixes: #24871 > ### Description > in the user profile page the `Packages` and `Projects` tab have small icons for user but other tabs have bigger profile picture with user info: > > ### Screenshots > ### **For Packages And Projects:** >  > > ### **For Other Tabs:** >  > ## Before  ## After changes Project View <img width="1394" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/95d181d7-8e61-496d-9899-7b825c91ad56"> Packages View <img width="1378" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/7f5fd60f-6b18-4fa8-8c56-7b0d45d1a610"> ## Org view for projects page <img width="1385" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/6400dc89-a5ae-4f0a-831b-5b6efa020d89"> ## Org view for packages page <img width="1387" alt="image" src="https://github.com/go-gitea/gitea/assets/80308335/4e1e9ffe-1e4b-4334-8657-de11b5fd31d0"> --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io> Co-authored-by: silverwind <me@silverwind.io>	2023-07-06 18:59:24 +00:00
silverwind	e7495735d5	Fix position of org follow button (#25688) ... This has recently regressed it seems. Put it back into same position as https://github.com/go-gitea/gitea/pull/24345.	2023-07-04 23:41:46 -04:00
Denys Konovalov	00dbba7f42	Several fixes for mobile UI (#25634) ... Resolves #25622 <details> <summary>Screenshots</summary>        </details> --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: silverwind <me@silverwind.io>	2023-07-04 17:45:45 +00:00
delvh	f4c1f43644	Prevent duplicate image loading (#25675) ... Regression of #25672.	2023-07-04 14:43:02 +00:00
silverwind	0006169f38	Actions list enhancements (#25601) ... Various small enhancements to the actions list. Before and after: <img width="1264" alt="Screenshot 2023-06-30 at 00 11 40" src="https://github.com/go-gitea/gitea/assets/115237/bb4162ee-cdcf-4a73-b05e-f9521562edbb"> <img width="1264" alt="Screenshot 2023-06-30 at 00 09 51" src="https://github.com/go-gitea/gitea/assets/115237/52a70ea9-4bb3-406e-904b-0fdaafde9582"> --------- Co-authored-by: Giteabot <teabot@gitea.io>	2023-07-04 09:59:47 +00:00
HesterG	dae022ab2a	Fix show more for image on diff page (#25672) ... Right now when clicking on loadmore on files change page, if the loaded content is image, it will be always in load status: https://github.com/go-gitea/gitea/assets/17645053/39e449b6-067a-474c-9443-9dd98d5bbfe2 This PR fixes this by adding `initImageDiff ` to `onShowMoreFiles ` After: https://github.com/go-gitea/gitea/assets/17645053/87bbb13e-0064-4a6e-a7ad-0f0060eb8bff	2023-07-04 10:36:27 +02:00
silverwind	1195d66c15	Prevent SVG shrinking (#25652) ... This will prevent the most common cases of SVG shrinking because lack of space. I evaluated multiple options and this seems to be the one with the least impact in size and processing cost, so I went with it. Unfortunately, CSS can not dynamically convert `16` obtained from `attr()` to `16px`, or else a generic solution for all sizes would have been possible. But a solution is [in sight](https://developer.mozilla.org/en-US/docs/Web/CSS/attr#type-or-unit) with `attr(width px)` but no browser supports it currently.	2023-07-04 02:15:06 +00:00
wxiaoguang	eea58a5d55	Fix UI misalignment on user setting page (#25629) ... Fix #25628 Diff with ignoring space: https://github.com/go-gitea/gitea/pull/25629/files?diff=unified&w=1 The "modal" shouldn't appear between "ui attached segment", otherwise these segments lose margin-top. After the fix: <details>     </details>	2023-07-03 20:38:06 +00:00
wxiaoguang	45bc180a15	Make "cancel" buttons have proper type in modal forms (#25618) ... Replace #25446, fix #25438 All "cancel" buttons which do not have "type" should not submit the form, should not be triggered by "Enter". This is a complete fix for all modal dialogs. The major change is "modules/aria/modal.js", "devtest" related code is for demo/test purpose.	2023-07-03 14:04:50 +08:00
HesterG	640a88fa09	Add log line anchor for action logs (#25532) ... Close #24593 Some behavior: - If log step line in hash exists, expand the step and scroll to the log line. - If step exists but line not exists, the step will be expanded. - If step not exists, stays on the job's page. Some Notes: - Changed mounted to async because need to await for first `loadJob` so `currentJobStepsStates` can be initialized and used in `hashChangeListener `. --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-07-03 01:08:49 +00:00
isla w	e882398c5a	Update emoji set to Unicode 15 (#25595) ... Update emoji set to Unicode 15 which was added upstream here: cb5c514d47 <img width="854" alt="Screenshot 2023-06-29 at 11 02 56 AM" src="https://github.com/go-gitea/gitea/assets/1669571/7bfb663d-0804-4d23-a62d-f585a6783ca6"> --------- Co-authored-by: silverwind <me@silverwind.io>	2023-06-29 16:29:48 +00:00
silverwind	64f2d70262	Replace fomantic divider module with our own (#25539) ... Should look exactly like before for normal dividers. "Horizontal" ones look better because they no longer use image backgrounds. <img width="917" alt="Screenshot 2023-06-27 at 19 07 56" src="https://github.com/go-gitea/gitea/assets/115237/d97d8dec-6859-44a8-85ba-e4549b4dd9df"> <img width="914" alt="Screenshot 2023-06-27 at 19 05 58" src="https://github.com/go-gitea/gitea/assets/115237/8bf98544-2d82-4ebf-ac68-d6dc237bd6b2"> <img width="1246" alt="Screenshot 2023-06-27 at 19 00 42" src="https://github.com/go-gitea/gitea/assets/115237/36a6bb21-6029-4f53-8bee-535f55c66fed"> <img width="344" alt="Screenshot 2023-06-27 at 18 58 15" src="https://github.com/go-gitea/gitea/assets/115237/a9e70aee-8e6b-4ea1-9e93-19c9f96aec6e"> <img width="823" alt="Screenshot 2023-06-27 at 18 56 22" src="https://github.com/go-gitea/gitea/assets/115237/e7a497cd-f262-4683-8872-23c3c8cce32f"> <img width="330" alt="Screenshot 2023-06-27 at 19 21 11" src="https://github.com/go-gitea/gitea/assets/115237/42f24149-a655-4c7e-bd26-8ab52db6446b">	2023-06-29 20:24:22 +08:00
silverwind	c76b221cca	Reduce table padding globally (#25568) ... Fomantic's tables have too much padding. Reduce it so we have more information density in them. Especially the admin tables need this because they are bursting already because of column count. ## Admin repolist before and after <img width="909" alt="Screenshot 2023-06-28 at 20 27 55" src="https://github.com/go-gitea/gitea/assets/115237/954c925c-8db5-47ce-ae51-a2168b857014"> <img width="897" alt="Screenshot 2023-06-28 at 20 36 03" src="https://github.com/go-gitea/gitea/assets/115237/0bddc09a-9117-48b3-a17e-3d34c58d8d3d"> ## Other tables <img width="1230" alt="Screenshot 2023-06-28 at 20 36 22" src="https://github.com/go-gitea/gitea/assets/115237/38f555b6-a7ce-416a-9f1f-706eaf18863b"> <img width="1236" alt="Screenshot 2023-06-28 at 20 26 37" src="https://github.com/go-gitea/gitea/assets/115237/82b2878e-358c-4dc2-a6b4-c66e43cd2dfb"> <img width="1231" alt="Screenshot 2023-06-28 at 20 59 30" src="https://github.com/go-gitea/gitea/assets/115237/c6a92e55-a3a3-4c80-9a0d-50aebb49886c"> Files table is unaffected because it has custom padding already. --------- Co-authored-by: Giteabot <teabot@gitea.io>	2023-06-29 04:40:03 +00:00
HesterG	c6f1fb1c6d	Use fetch form action for lock/unlock/pin/unpin on sidebar (#25380) ... Before: <img width="364" alt="Screen Shot 2023-06-20 at 11 59 11" src="https://github.com/go-gitea/gitea/assets/17645053/ad284b7e-8d21-43be-b178-bbcfd37cb5bd"> Might trigger many posts when keep clicking the buttons above. <img width="448" alt="Screen Shot 2023-06-20 at 11 52 28" src="https://github.com/go-gitea/gitea/assets/17645053/a60aa6ac-af74-45e4-b13a-512b436b81b0"> <img width="678" alt="Screen Shot 2023-06-20 at 11 52 37" src="https://github.com/go-gitea/gitea/assets/17645053/d6662700-3643-4cc7-a2ec-64e1c0f5fbdb"> After (PR sidebar, Same for issue): https://github.com/go-gitea/gitea/assets/17645053/9df3ad1f-e29c-439b-8bde-e6b917d63cc6 For delete, it is using `base/modal_actions_confirm` subtemplate, and we might need another general solution for this (maybe add another attribute to the subtemplate or something) --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Giteabot <teabot@gitea.io> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-06-29 04:16:04 +00:00
Vitaliy Filippov	f0b773e0ce	Support downloading raw task logs (#24451) ... Hi! This pull request adds support for downloading raw task logs for Gitea Actions, similar to Github Actions It looks like the following: 	2023-06-29 10:58:56 +08:00
wxiaoguang	b6693a2c9a	Align language menu icon and fit the footer area (#25556) ... Close #25551	2023-06-28 14:57:50 +00:00
silverwind	fdab4e3d84	Add custom ansi colors and CSS variables for them (#25546) ... Use our existing color palette to map to the 16 basic ansi colors. This is backwards-compatible because it aliases the existing color names. Side note: I think the colors in `console.css` for console file rendering are incomplete, but fixing those is out of scope here imo. Before and after: <img width="542" alt="Screenshot 2023-06-28 at 00 26 12" src="https://github.com/go-gitea/gitea/assets/115237/86d41884-bc47-4e85-8aec-621eb7320f0b"> <img width="546" alt="Screenshot 2023-06-28 at 00 28 24" src="https://github.com/go-gitea/gitea/assets/115237/39fa3b37-d49e-49b1-b6bc-390ac8ca24b2"> --------- Co-authored-by: Giteabot <teabot@gitea.io>	2023-06-28 15:38:55 +02:00
silverwind	b943318617	Update JS dependencies and misc tweaks (#25540) ... - Update all JS dependencies - Enable `declaration-property-unit-disallowed-list` to forbid `em` on `line-height` - Rename dependency update targets to `update-js` and `update-py` and document them - Remove margin on Asciicast viewer - Tested Swagger, Katex, Asciicast <img width="1243" alt="Screenshot 2023-06-27 at 19 51 05" src="https://github.com/go-gitea/gitea/assets/115237/2d2722a0-2aa7-4f4c-b8bd-17e1f3637b78">	2023-06-27 21:44:17 +02:00
HesterG	00b98bc8e0	Fix rerun icon on action view component (#25531) ... Right now rerun icon on action view component will not be seen when duration text length is long, because the wrapper `job-brief-info` has a fixed width, and the svg is squeezed. The way to fix this in this PR is to change width to `fit-content` and exchange position of duration text and rerun svg. Before (rerun svg not shown on hover): <img width="1401" alt="Screen Shot 2023-06-27 at 12 53 41" src="https://github.com/go-gitea/gitea/assets/17645053/bb3f62ec-8c56-4dbc-96f1-718b50426d91"> After: <img width="1409" alt="Screen Shot 2023-06-27 at 12 50 59" src="https://github.com/go-gitea/gitea/assets/17645053/620aa02c-2326-408d-a763-453f48f42c40">	2023-06-27 16:34:33 +02:00
wxiaoguang	6dbcf6fbc5	Fix admin-dl-horizontal (#25512) ...   --------- Co-authored-by: HesterG <hestergong@gmail.com> Co-authored-by: silverwind <me@silverwind.io>	2023-06-27 09:14:45 +00:00
hiifong	1069472c0c	Fix input line-height cutting off g (#25334) ... Fix the incomplete display of input text Before:   After:   --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Giteabot <teabot@gitea.io>	2023-06-27 08:45:43 +00:00
silverwind	c71e8abbc3	Add toasts to UI (#25449) ... Fixes https://github.com/go-gitea/gitea/issues/24353 In some case like async success/error, it is useful to show toasts in UI.	2023-06-27 02:45:24 +00:00
silverwind	da6df0d063	Fix migrate page layout on mobile (#25507) ... Fixes: https://github.com/go-gitea/gitea/issues/25462 On supporting browsers, text in description is [wrapped equally](https://caniuse.com/css-text-wrap-balance). <img width="488" alt="Screenshot 2023-06-26 at 00 17 21" src="https://github.com/go-gitea/gitea/assets/115237/cb8e3a50-6225-4a8c-a6c0-f35a17d2af76"> <img width="1254" alt="Screenshot 2023-06-26 at 00 14 51" src="https://github.com/go-gitea/gitea/assets/115237/0885404e-973e-45ce-b41e-5cb265a4cd1e">	2023-06-26 09:57:36 +00:00
HesterG	457946d595	Allow change line of admin-dl-horizontal dt (#25508) ... Close #25389 After: <img width="915" alt="Screen Shot 2023-06-26 at 11 00 12" src="https://github.com/go-gitea/gitea/assets/17645053/45026447-cf50-4603-ade3-7b80a9023c20"> admin/dashboard: <img width="957" alt="Screen Shot 2023-06-26 at 10 59 51" src="https://github.com/go-gitea/gitea/assets/17645053/f4f95bbe-f747-46f1-8fbd-5778a19ebef7">	2023-06-26 11:49:14 +08:00
wxiaoguang	323c6cba20	Fine tune "dropdown button" icon (#25442) ...  ---- 	2023-06-25 02:40:41 +00:00
wxiaoguang	b8253607fe	Revert "Make buttons in a modal form have proper type. (#25446)" (#25485) ... There is a side effect because some modal doesn't have a proper "ok" button. This reverts commit a954c93a68.	2023-06-25 10:03:09 +08:00
sebastian-sauer	77e449f0be	Highlight viewed files differently in the PR filetree (#24956) ...  fixes #24566 --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-06-25 08:46:30 +08:00
hiifong	8e6a114317	fix tags line no margin see #25255 (#25280) ... This is my first pr, there are many things I don't understand very well, I am very sorry, I rearranged the code and opened this new pr. Now： 	2023-06-24 20:30:46 +08:00
silverwind	be47015229	Navbar fixes (#25402) ... Fixes: https://github.com/go-gitea/gitea/issues/25444 Followup for some regressions from https://github.com/go-gitea/gitea/pull/25343. Before and after: <img width="219" alt="Screenshot 2023-06-21 at 00 25 20" src="https://github.com/go-gitea/gitea/assets/115237/08fe8e01-0a16-4cdf-ad4d-0a9048408e9e"> <img width="220" alt="Screenshot 2023-06-21 at 00 25 32" src="https://github.com/go-gitea/gitea/assets/115237/be25ae69-6ed0-4af5-8eeb-d7b210e7c124"> Fixes mobile button background and margins: <img width="836" alt="Screenshot 2023-06-21 at 00 39 58" src="https://github.com/go-gitea/gitea/assets/115237/d76ac1e9-747f-477c-9a42-b73e129b72ee">	2023-06-24 04:31:39 +00:00
wxiaoguang	62ab55bacc	Improve wiki sidebar and TOC (#25460) ... Close #20976 Close #20975 1. Fix the bug: the TOC in footer was incorrectly rendered as main content's TOC 2. Fix the layout: on mobile, the TOC is put above the main content, while the sidebar is put below the main content 3. Auto collapse the TOC on mobile ps: many styles of "wiki.css" are moved from old css files, so leave nits to following PRs.	2023-06-23 15:51:43 -04:00
wxiaoguang	a954c93a68	Make buttons in a modal form have proper type. (#25446) ... Fix #25438 All non-"ok" buttons which do not have "type" should not submit the form, should not be triggered by "Enter". Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Giteabot <teabot@gitea.io>	2023-06-23 12:57:01 +02:00
silverwind	d2142ba3c3	Update octicons and use octicon-file-directory-symlink (#25453) ... Make use of the [new octicon](https://github.com/primer/octicons/issues/945) that indicates a symlink to a directory: <img width="189" alt="Screenshot 2023-06-22 at 22 50 57" src="https://github.com/go-gitea/gitea/assets/115237/a70690ea-ebfc-48fe-af23-cdc33bcb2098">	2023-06-22 22:05:52 +00:00
silverwind	7fb539677b	Diff page enhancements (#25398) ... Two small tweaks: 1. Vertically center arrow here when editing a PR: <img width="405" alt="Screenshot 2023-06-20 at 19 48 49" src="https://github.com/go-gitea/gitea/assets/115237/1d63764d-9fd9-467e-8a8e-9258c06475eb"> 2. Use 2-row layout on diff viewed status and show it again on mobile: <img width="142" alt="Screenshot 2023-06-20 at 19 51 21" src="https://github.com/go-gitea/gitea/assets/115237/3046e782-163c-4f87-910c-a22066de8f1b"> Mobile view: <img width="370" alt="Screenshot 2023-06-20 at 19 44 40" src="https://github.com/go-gitea/gitea/assets/115237/9cf56347-7323-4d05-99a5-17ad215ee44d">	2023-06-22 11:05:22 +00:00
silverwind	af094fbb6c	Introduce shared template for search inputs (#25338) ... - Set [type=search](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/search) - Disable spellcheck - Set maxLength 255 that I found in `templates/repo/issue/search.tmpl` - Remove unnecessary `max-width`, it does nothing --------- Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: Giteabot <teabot@gitea.io>	2023-06-22 10:27:35 +00:00
silverwind	93cd579269	Switch to ansi_up for ansi rendering in actions (#25401) ... Fixes: https://github.com/go-gitea/gitea/issues/24777	2023-06-22 02:15:19 +00:00
silverwind	656d3cc719	Various UI fixes (#25264) ... Numerous small UI fixes: - Fix double border in collaborator list - Fix system notice table background - Mute links in repo and org lists - Downsize projects edit buttons - Improve milestones and project list rendering - Condense milestone list entry to a single line of "metas" - Mute ".." button in repo files list	2023-06-21 21:59:49 -04:00
sebastian-sauer	25455bc670	Show outdated comments in files changed tab (#24936) ... If enabled show a clickable label in the comment. A click on the label opens the Conversation tab with the comment focussed - there you're able to view the old diff (or original diff the comment was created on). **Screenshots**   When resolved and outdated:  Option to enable/disable this (stored in user settings - default is disabled):   fixes #24913 --------- Co-authored-by: silverwind <me@silverwind.io>	2023-06-21 16:08:12 +00:00
HesterG	dfd19fa38c	Fine tune project board label colors and modal content background (#25419) ... - The label text color on project board is not contrasting enough, changed to colors that are same as places that also used `useLightTextOnBackground` function ([util_render.go](2cdf260f42/modules/templates/util_render.go (L136-L141)), [Context Popup](2cdf260f42/web_src/js/components/ContextPopup.vue (L81-L84))) - background of modal `content` is `#ffffff` (from fomantic) right now, which does not look good on dark mode, so changed to `var(--color-body)` Before: <img width="1378" alt="Screen Shot 2023-06-21 at 14 24 13" src="https://github.com/go-gitea/gitea/assets/17645053/1527ca28-c884-4ca9-a4be-7a72ad1a093a"> <img width="900" alt="Screen Shot 2023-06-21 at 14 25 52" src="https://github.com/go-gitea/gitea/assets/17645053/fab82116-7376-4027-a0a4-9eedf9fb0a30"> After: <img width="1383" alt="Screen Shot 2023-06-21 at 14 19 33" src="https://github.com/go-gitea/gitea/assets/17645053/fe0997e7-fee6-4522-bc4e-545088ec1cc8"> <img width="797" alt="Screen Shot 2023-06-21 at 14 32 42" src="https://github.com/go-gitea/gitea/assets/17645053/b0591af0-950c-4448-9430-34d6c7215971">	2023-06-21 18:15:51 +08:00
HesterG	1454f9dafc	Add actor and status dropdowns to run list (#25118) ... Part of #25042 1. Added actor and status dropdowns first in case something is offtrack and PR is too large. 2. Also added "No results matched." and "The workflow has no runs yet.", and "No results matched." will show if there is no filter results and there is no workflows (with [reference to github action](https://github.com/go-gitea/gitea/actions/workflows/files-changed.yml?query=actor%3AGiteaBot)) Demo: https://github.com/go-gitea/gitea/assets/17645053/6e76292c-4c1f-450d-8b48-99944cfc920c TODOs: - [x] Get available status (same as those in `aggregateJobStatus`) instead of getting from database - [x] Use `JOIN` to get actors, actors order by name - [x] Make self on top	2023-06-21 04:25:14 +00:00
wxiaoguang	831db53c21	Fix dropdown icon layout on diff page (#25397) ... Address https://github.com/go-gitea/gitea/pull/25163#issuecomment-1599207916 Remove the unused "icon-button". And fix the layout: Without the dropdown icon: ``` {{svg "gitea-whitespace"}} ```  With the dropdown icon: ``` {{svg "gitea-whitespace" 16 "gt-mr-3"}} {{svg "octicon-triangle-down" 14 "dropdown icon"}} ``` 	2023-06-20 23:22:48 +00:00
sillyguodong	35a653d7ed	Support configuration variables on Gitea Actions (#24724) ... Co-Author: @silverwind @wxiaoguang Replace: #24404 See: - [defining configuration variables for multiple workflows](https://docs.github.com/en/actions/learn-github-actions/variables#defining-configuration-variables-for-multiple-workflows) - [vars context](https://docs.github.com/en/actions/learn-github-actions/contexts#vars-context) Related to: - [x] protocol: https://gitea.com/gitea/actions-proto-def/pulls/7 - [x] act_runner: https://gitea.com/gitea/act_runner/pulls/157 - [x] act: https://gitea.com/gitea/act/pulls/43 #### Screenshoot Create Variable:   Workflow: ```yaml test_vars: runs-on: ubuntu-latest steps: - name: Print Custom Variables run: echo "${{ vars.test_key }}" - name: Try to print a non-exist var run: echo "${{ vars.NON_EXIST_VAR }}" ``` Actions Log:  --- This PR just implement the org / user (depends on the owner of the current repository) and repo level variables, The Environment level variables have not been implemented. Because [Environment](https://docs.github.com/en/actions/deployment/targeting-different-environments/using-environments-for-deployment#about-environments) is a module separate from `Actions`. Maybe it would be better to create a new PR to do it. --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io>	2023-06-20 22:54:15 +00:00
silverwind	e50c3e8431	Navbar styling rework (#25343) ... - Extract navbar CSS to own file - Reduce height from 52px to 50px - Give every item a hover effect of of 36px, including the logo and on mobile - Consistent horizontal padding of 10px left and right <img width="549" alt="Screenshot 2023-06-18 at 13 41 16" src="https://github.com/go-gitea/gitea/assets/115237/0b00d101-253e-4b1f-9ee2-322d60fb2e26"> <img width="98" alt="Screenshot 2023-06-18 at 14 03 43" src="https://github.com/go-gitea/gitea/assets/115237/4ef5d98b-4d1e-45de-822e-c2c844e19876"> <img width="234" alt="Screenshot 2023-06-18 at 14 03 18" src="https://github.com/go-gitea/gitea/assets/115237/a4d9b04b-83de-42aa-a9ce-f010a9690688"> <img width="873" alt="Screenshot 2023-06-18 at 13 58 28" src="https://github.com/go-gitea/gitea/assets/115237/8cb8e31e-2adf-40c8-ae3f-d00d011b4d1b"> --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io>	2023-06-20 20:35:25 +00:00
silverwind	ef6f5f0124	rename tributeValues to mentionValues (#25375) ... Very simple change, just rename this variable so it does not feature the name of the module.	2023-06-20 03:32:49 +00:00
HesterG	49a77e37ba	Fix sidebar label dropdown divider (#25359) ... Follow #25312 Also fix the label dropdown on sidebar Before: <img width="1345" alt="Screen Shot 2023-06-19 at 08 55 05" src="https://github.com/go-gitea/gitea/assets/17645053/3a98e871-b482-4ecb-8ce2-74df67fb65a7"> After: <img width="1408" alt="Screen Shot 2023-06-19 at 08 57 17" src="https://github.com/go-gitea/gitea/assets/17645053/09af15cc-1250-49b3-98b6-5b1a2b9021cb">	2023-06-19 17:49:50 +00:00
Denys Konovalov	7f38cf71fe	Fix issue filters on mobile view (#25368) ... Fix #24846 applying the solution proposed by @silverwind <details> <summary>Screenshots</summary>       </details> Replaces #25335	2023-06-19 17:12:15 +00:00
silverwind	c09d0b4952	Fix loading state regression in markup content (#25349) ... Fix regressions from https://github.com/go-gitea/gitea/pull/25219: Math before and after: <img width="630" alt="Screenshot 2023-06-18 at 16 00 52" src="https://github.com/go-gitea/gitea/assets/115237/f2a01e4b-31ca-407c-8fc3-f0aec569b48e"> <img width="680" alt="Screenshot 2023-06-18 at 16 03 44" src="https://github.com/go-gitea/gitea/assets/115237/faab8e39-f088-45ab-b460-15fc3654c99d"> Mermain before and after: <img width="810" alt="Screenshot 2023-06-18 at 15 58 56" src="https://github.com/go-gitea/gitea/assets/115237/d8c24e81-4702-4e17-b791-7dffe090c068"> <img width="786" alt="Screenshot 2023-06-18 at 15 58 37" src="https://github.com/go-gitea/gitea/assets/115237/3a268e10-c071-410d-a66e-8c4427d1d61c">	2023-06-19 08:00:18 +00:00
wxiaoguang	a1c5057fe8	Batch delete issue and improve tippy opts (#25253) ... 1. Add "batch delete" button for selected issues, close #22273 2. Address the review in https://github.com/go-gitea/gitea/pull/25219#discussion_r1229266083	2023-06-19 15:46:50 +08:00
wxiaoguang	bfab129fb9	Fix label list divider (#25312) ... We only needs 2 lines to hide the dividers. ``` $dropdownLabelFilter.dropdown('setting', {'hideDividers': 'empty'}); $dropdownLabelFilter.dropdown('refreshItems'); ``` Other code blocks are refactored by the way.  	2023-06-18 17:33:12 +00:00
wxiaoguang	695f5d170b	Fix incorrect link-action event target (#25306) ... A regression of #25210 The `e.target` is not "this", eg: `<button link-action><svg></button>`, then `this` should be `button` but `e.target` is `svg`. I will propose a clearer and complete solution for these "link-action" "show-modal" elements after #24724 Co-authored-by: Giteabot <teabot@gitea.io>	2023-06-18 17:23:18 +02:00
Denys Konovalov	9e74063498	Fix UI on mobile view (#25315) ... Various fixes to pages or elements which were looking ugly on mobile. <details> <summary>Screenshots</summary>          </details> Co-authored by @silverwind --------- Co-authored-by: silverwind <me@silverwind.io>	2023-06-18 10:31:42 +00:00
silverwind	f47744c3f1	Update JS dependencies, remove space after emoji completion (#25266) ... - Update all JS dependencies - Enable stylint [`media-feature-name-value-no-unknown`](https://stylelint.io/user-guide/rules/media-feature-name-value-no-unknown) - Make use of new features in webpack and text-expander-element - Tested Swagger and Mermaid To explain the `text-expander-element` change: Before this version, the element added a unavoidable space after emoji completion. Now that https://github.com/github/text-expander-element/pull/36 is in, we gain control over this space and I opted to remove it for emoji completion and retain it for `@` mentions. --------- Co-authored-by: Giteabot <teabot@gitea.io>	2023-06-18 08:38:47 +00:00
silverwind	61e0827f42	Add stylelint-declaration-block-no-ignored-properties (#25284) ... Add [stylelint-declaration-block-no-ignored-properties](https://github.com/kristerkari/stylelint-declaration-block-no-ignored-properties) and fix discovered issue. There is no visual difference in these markup code blocks.	2023-06-18 04:22:09 +00:00
silverwind	95ab485490	Remove EasyMDE focus outline on text (#25328) ... EasyMDE in Firefox currently shows an ugly outline in the fake textarea the CodeMirror uses. Hide it.	2023-06-18 04:10:07 +00:00
silverwind	3ee8970419	add stylelint-stylistic (#25285) ... Add [stylelint-stylistic](https://github.com/elirasza/stylelint-stylistic), autofix all issues with two manual tweaks. This restores all the stylistic rules removed in Stylelint 15.	2023-06-17 13:20:32 +00:00
silverwind	69b1e2f103	Remove more unused Fomantic variants (#25292) ... Save another 50KB of CSS by removing unused and useless Fomantic variants. Removed the last instance if a `tertiary` button and fixed a TODO: <img width="509" alt="Screenshot 2023-06-15 at 22 34 36" src="https://github.com/go-gitea/gitea/assets/115237/8a16ae7b-2b17-439b-a096-60a52724e3d6">	2023-06-17 08:15:33 +00:00
wxiaoguang	b71cb7acdc	Use fetch to send requests to create issues/comments (#25258) ... Follow #23290 Network error won't make content lost. And this is a much better approach than "loading-button". The UI is not perfect and there are still some TODOs, they can be done in following PRs, not a must in this PR's scope. <details>  </details>	2023-06-16 06:32:43 +00:00
wxiaoguang	6db66d8ca4	Fix some UI alignments (#25277) ... Fixes: https://github.com/go-gitea/gitea/issues/25282 Fix the problems: 1. The `repo-button-row` had various patches before, this PR makes it consistent 2. The "Add File" has wrong CSS class "icon", remove it 3. The "Add File" padding was overridden by "!important", fix it by `.repo-button-row .button.dropdown` with comment 4. The selector `.ui.segments ~ .ui.top.attached.header` is incorrect, it should use `+`	2023-06-15 15:12:08 +00:00
silverwind	14b802e7ad	Remove fomantic inverted variations (#25286) ... Remove all Fomantic `inverted` variations, we are no using any of them. This reduces the index CSS bundle by 98kB.	2023-06-15 10:40:34 -04:00
wxiaoguang	8e0316c321	Fix issue and commit status popup padding (#25254) ... Close #25249 Use "dialog" for the role  --------- Co-authored-by: silverwind <me@silverwind.io>	2023-06-15 10:09:16 +02:00
wxiaoguang	73ae71824d	Show OAuth2 errors to end users (#25261) ... Partially fix #23936   	2023-06-15 01:12:50 +00:00
wxiaoguang	46c17c8029	Use flex to align SVG and text (#25163) ... The code can be as simple as: ```html <div class="flex-text-block">{{svg "octicon-alert"}} {{svg "octicon-x"}} text (block)</div> <div><div class="flex-text-inline">{{svg "octicon-alert"}} {{svg "octicon-x"}} text</div> (inline)</div> <div><button class="ui red button">{{svg "octicon-alert" 24}} {{svg "octicon-x" 24}} text</button></div> ```  --------- Co-authored-by: Giteabot <teabot@gitea.io>	2023-06-14 16:40:15 +00:00
HesterG	a43ea22479	Change form actions to fetch for submit review box (#25219) ... Co-author: @wxiaoguang Close #25096 The way to fix it in this PR is to change form submit to fetch using formData, and add flags to avoid post repeatedly. Should be able to apply to more forms that have the same issue after this PR. In the demo below, 'approve' is clicked several times, and then 'comment' is clicked several time after 'request changes' clicked. After: https://github.com/go-gitea/gitea/assets/17645053/beabeb1d-fe66-4b76-b048-4f022b4e83a0 Update: screenshots from /devtest >  > >  > >  --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-06-14 16:01:37 +08:00
wxiaoguang	4f3253feb9	Revert overflow: overlay (revert #21850) (#25231) ... It causes not only one issue like #25221 (the footer width was also affected by that change and was fixed some time ago) The problem of "overflow: overlay" (#21850) is: * It's not widely supported and is non-standard https://caniuse.com/css-overflow-overlay * It's not widely tested in Gitea (some standard layout like `ui container + ui grid` may break it). * The benefit seems smaller than the problems it brings. So, I think it is good to revert it. ---- Let's leave enough time for testing and reviewing. --------- Co-authored-by: Giteabot <teabot@gitea.io> Co-authored-by: silverwind <me@silverwind.io>	2023-06-13 21:17:14 +02:00
wxiaoguang	6bbccdd177	Improve AJAX link and modal confirm dialog (#25210) ... Clarify the "link-action" behavior: > // A "link-action" can post AJAX request to its "data-url" > // Then the browser is redirect to: the "redirect" in response, or "data-redirect" attribute, or current URL by reloading. And enhance the "link-action" to support showing a modal dialog for confirm. A similar general approach could also help PRs like https://github.com/go-gitea/gitea/pull/22344#discussion_r1062883436 > // If the "link-action" has "data-modal-confirm(-html)" attribute, a confirm modal dialog will be shown before taking action. And a lot of duplicate code can be removed now. A good framework design can help to avoid code copying&pasting. --------- Co-authored-by: silverwind <me@silverwind.io>	2023-06-13 12:10:10 +00:00
silverwind	a51b115b0a	Use inline SVG for built-in OAuth providers (#25171) ... The plan is that all built-in auth providers use inline SVG for more flexibility in styling and to get the GitHub icon to follow `currentcolor`. This only removes the `public/img/auth` directory and adds the missing svgs to our svg build. It should map the built-in providers to these SVGs and render them. If the user has set a Icon URL, it should render that as an `img` tag instead. ``` gitea-azure-ad gitea-bitbucket gitea-discord gitea-dropbox gitea-facebook gitea-gitea gitea-gitlab gitea-google gitea-mastodon gitea-microsoftonline gitea-nextcloud gitea-twitter gitea-yandex octicon-mark-github ``` GitHub logo is now white again on dark theme: <img width="431" alt="Screenshot 2023-06-12 at 21 45 34" src="https://github.com/go-gitea/gitea/assets/115237/27a43504-d60a-4132-a502-336b25883e4d"> --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-06-13 10:51:02 +00:00
Punit Inani	2ad2d5a6ce	Disable Create column button while the column name is empty (#25192) ...  Fixes #25116	2023-06-13 09:57:03 +00:00
Jonathan Tran	a583c56306	Change access token UI to select dropdowns (#25109) ... The current UI to create API access tokens uses checkboxes that have a complicated relationship where some need to be checked and/or disabled in certain states. It also requires that a user interact with it to understand what their options really are. This branch changes to use `<select>`s. It better fits the available options, and it's closer to [GitHub's UI](https://github.com/settings/personal-access-tokens/new), which is good, in my opinion. It's more mobile friendly since the tap-areas are larger. If we ever add more permissions, like Maintainer, there's a natural place that doesn't take up more screen real-estate. This branch also fixes a few minor issues: - Hide the error about selecting at least one permission after second submission - Fix help description to call it "authorization" since that's what permissions are about (not authentication) Related: #24767. <img width="883" alt="Screenshot 2023-06-07 at 5 07 34 PM" src="https://github.com/go-gitea/gitea/assets/10803/6b63d807-c9be-4a4b-8e53-ecab6cbb8f76"> --- When it's open: <img width="881" alt="Screenshot 2023-06-07 at 5 07 59 PM" src="https://github.com/go-gitea/gitea/assets/10803/2432c6d0-39c2-4ca4-820e-c878ffdbfb69">	2023-06-13 15:55:48 +08:00
Jonathan Tran	f62cd2f473	Fix task list checkbox toggle to work with YAML front matter (#25184) ... Fixes #25160. `data-source-position` of checkboxes in a task list was incorrect whenever there was YAML front matter. This would result in issue content or PR descriptions getting corrupted with random `x` or space characters when a user checked or unchecked a task.	2023-06-13 14:44:47 +08:00
wxiaoguang	d8e45608d6	Remove hacky patch for "safari emoji glitch fix" (#25208) ... According to my test, the UI (emoji) is fine in Safari And actually the code is just dead code, because the "resize" event is never fired on page loading. So for most cases users just view the pages without this hacky patch, nobody ever complains.	2023-06-12 15:44:53 +00:00
HesterG	3318001880	Fix fullscreen for action (#25200) ... An error occurs when clicking on `show full screen` on action page. <img width="1440" alt="Screen Shot 2023-06-12 at 13 06 52" src="https://github.com/go-gitea/gitea/assets/17645053/1d4ded3c-fb77-4dd8-9201-24d0696f96eb"> class name has changed in #25134, so the selector is not working. Enhance the selectors to fix this.	2023-06-12 10:18:01 +00:00
silverwind	96f9c11821	Minor arc-green color tweaks (#25175) ... Some minor color tweaks <img width="1271" alt="Screenshot 2023-06-09 at 13 29 25" src="https://github.com/go-gitea/gitea/assets/115237/b7b34995-5d34-461f-8d19-4f5755a98109"> <img width="1272" alt="Screenshot 2023-06-09 at 13 31 20" src="https://github.com/go-gitea/gitea/assets/115237/63c866b4-797e-46ed-ba28-b1162ccd3e15"> <img width="1276" alt="Screenshot 2023-06-09 at 13 32 21" src="https://github.com/go-gitea/gitea/assets/115237/de7ee02e-d0c7-4979-a8aa-0fd03e8db491"> Co-authored-by: Giteabot <teabot@gitea.io>	2023-06-09 15:17:30 +00:00
silverwind	6a075589bf	Fix mobile navbar and misc cleanups (#25134) ... - Fix and improve mobile navbar layout - Apply all cleanups suggested in https://github.com/go-gitea/gitea/pull/25111 - Make media query breakpoints match Fomantic's exactly - Clean up whitespace in class on navbar items Mobile navbar before and after: <img width="745" alt="Screenshot 2023-06-08 at 08 40 56" src="https://github.com/go-gitea/gitea/assets/115237/ca84b239-b10f-41db-8c06-dcf2b6dd9d28"> <img width="739" alt="Screenshot 2023-06-08 at 08 41 23" src="https://github.com/go-gitea/gitea/assets/115237/09133c54-eb7e-4110-858c-ead23c3b7521"> --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io>	2023-06-09 09:10:51 +00:00
silverwind	623b3b590e	Button and color enhancements (#24989) ... - Various corrections to button styles, especially secondary - Remove focus highlight, it's annoying when it stays on button after press - Clearly define ghost and link buttons with demos in devtest - Remove black, grey and tertiary buttons, they should not be used - Make `arc-green` slightly darker <img width="1226" alt="image" src="https://github.com/go-gitea/gitea/assets/115237/8d89786a-01ab-40f8-ae5a-e17f40e35084"> <img width="1249" alt="image" src="https://github.com/go-gitea/gitea/assets/115237/83651e6d-3c27-46ff-b8bd-ff344d70e949"> --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: Giteabot <teabot@gitea.io>	2023-06-09 08:37:47 +00:00
HesterG	63a429581c	Modify OAuth login ui and fix display name, iconurl related logic (#25030) ... Close #24808 Co-Authour @wxiaoguang @silverwind 1. Most svgs are found from https://worldvectorlogo.com/ , and some are from conversion of png to svg. (facebook and nextcloud). And also changed `templates/user/settings/security/accountlinks.tmpl`. 2. Fixed display name and iconurl related logic # After <img width="1436" alt="Screen Shot 2023-06-05 at 14 09 05" src="https://github.com/go-gitea/gitea/assets/17645053/a5db39d8-1ab0-4676-82a4-fba60a1d1f84"> On mobile <img width="378" alt="Screen Shot 2023-06-05 at 14 09 46" src="https://github.com/go-gitea/gitea/assets/17645053/71d0f51b-baac-4f48-8ca2-ae0e013bd62e"> user/settings/security/accountlinks (The dropdown might be improved later) <img width="973" alt="Screen Shot 2023-06-01 at 10 01 44" src="https://github.com/go-gitea/gitea/assets/17645053/27010e7e-2785-4fc5-8c49-b06621898f37"> --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2023-06-08 16:35:29 +00:00
yp05327	b5a2bb9ab3	Fix strange UI behavior of cancelling dismiss review modal (#25133) ... Fixes https://github.com/go-gitea/gitea/issues/25130 The old code uses `$(this).next()` to get `dismiss-review-modal`. At first, it will get `$(#dismiss-review-modal)`, but the next time it will get `$(#dismiss-review-modal).next();` and then `$(#dismiss-review-modal).next().next();`. Because div `dismiss-review-modal` will be removed when `dismiss-review-btn` clicked. Maybe the right usage is adding `show-modal` class and `data-modal` attribute.	2023-06-08 08:52:35 +00:00
silverwind	b6bcb79987	Improve notification icon and navbar (#25111) ... Improvements to the notification icon and `<nav>`: - Add a opaque color for header hover and use it, allowing the border to be the right color on hover (sadly, not otherwise possible with CSS, not even `color-mix`). - Increase font size by 1px - Use flexbox for slightly better text centering - Reduce padding of user and add repo button, add margin on right side of user menu - Remove the `following bar` wrapper on navbar <img width="176" alt="Screenshot 2023-06-07 at 00 07 08" src="https://github.com/go-gitea/gitea/assets/115237/23cdc3d6-7f63-49df-bec3-f2e75e32a304"> <img width="63" alt="Screenshot 2023-06-07 at 00 07 14" src="https://github.com/go-gitea/gitea/assets/115237/fae602c2-4467-4d50-b1ec-56317843f9a2"> <img width="84" alt="Screenshot 2023-06-07 at 00 07 36" src="https://github.com/go-gitea/gitea/assets/115237/c48141b8-0b3c-48cc-846a-3a272524dbdb"> <img width="329" alt="Screenshot 2023-06-07 at 00 25 10" src="https://github.com/go-gitea/gitea/assets/115237/cda612f1-426e-466b-a351-fc992bfd18fd"> <img width="186" alt="Screenshot 2023-06-07 at 00 35 45" src="https://github.com/go-gitea/gitea/assets/115237/04484a2e-9bbf-493c-aa26-8e936da008fa"> <img width="797" alt="Screenshot 2023-06-07 at 16 57 40" src="https://github.com/go-gitea/gitea/assets/115237/e7ccb672-5807-4cb6-b306-b18ae0c7e321">	2023-06-07 22:21:57 +00:00
wxiaoguang	027014d7de	Fix webauthn regression and improve code (#25113) ... Follow: * #22697 There are some bugs in #22697: * https://github.com/go-gitea/gitea/pull/22697#issuecomment-1577957966 * the webauthn failure message is never shown and causes console error * The `document.getElementById('register-button')` and `document.getElementById('login-button')` is wrong * there is no such element in code * it causes JS error when a browser doesn't provide webauthn * the end user can't see the real error message These bugs are fixed in this PR. Other changes: * Use simple HTML/CSS layouts, no need to use too many `gt-` patches * Make the webauthn page have correct "page-content" layout * The "data-webauthn-error-msg" elements are only used to provide locale texts, so move them into a single "gt-hidden", then no need to repeat a lot of "gt-hidden" in code * The `{{.CsrfTokenHtml}}` is a no-op because there is no form * Many `hideElem('#webauthn-error')` in code is no-op because the `webauthn-error` already has "gt-hidden" by default * Make the tests for "URLEncodedBase64" really test with concrete cases. Screenshots: * Error message when webauthn fails (before, there is no error message): <details>  </details> * Error message when webauthn is unavailable <details>  </details>	2023-06-07 19:20:18 +08:00
HesterG	58536093b3	Add details summary for vertical menus in settings to allow toggling (#25098) ... Close #25051 [referenced answer](https://stackoverflow.com/questions/10813581/can-i-replace-the-expand-icon-of-the-details-element/69722686#69722686) for marker overwrite. One limitation is that fomantic does not have hover and active effects for the vertical submenu ([reference](https://fomantic-ui.com/collections/menu.html#sub-menu)). And we might need to overwrite some styles if hover and active effects are needed. Update: Used `data:image/svg` instead of `marker` content. And adjusted styles for hover effect. Take admin settings as an example: https://github.com/go-gitea/gitea/assets/17645053/63f69823-ef43-47d5-a518-544b5ea35ba6 --------- Co-authored-by: silverwind <me@silverwind.io>	2023-06-07 10:49:48 +08:00
zeripath	036fb7861f	Clean up WebAuthn javascript code and remove JQuery code (#22697) ... There were several issues with the WebAuthn registration and testing code and the style was very old javascript with jquery callbacks. This PR uses async and fetch to replace the JQuery code. Ref #22651 Signed-off-by: Andrew Thornton <art27@cantab.net> --------- Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: silverwind <me@silverwind.io>	2023-06-06 13:29:37 +08:00
wxiaoguang	8e63373c01	Use correct selector for hiding RSS icon link in the branch selector dropdown (#25080) ... Fix #25079    	2023-06-05 12:34:25 +00:00
JakobDev	7d192cb674	Add Progressbar to Milestone Page (#25050) ... This is adds the progress bar, which is already on the Milestone List, also to the Page of a Single Milestone.  --------- Co-authored-by: silverwind <me@silverwind.io>	2023-06-05 14:25:46 +08:00
Jack Hay	18de83b2a3	Redesign Scoped Access Tokens (#24767) ... ## Changes - Adds the following high level access scopes, each with `read` and `write` levels: - `activitypub` - `admin` (hidden if user is not a site admin) - `misc` - `notification` - `organization` - `package` - `issue` - `repository` - `user` - Adds new middleware function `tokenRequiresScopes()` in addition to `reqToken()` - `tokenRequiresScopes()` is used for each high-level api section - _if_ a scoped token is present, checks that the required scope is included based on the section and HTTP method - `reqToken()` is used for individual routes - checks that required authentication is present (but does not check scope levels as this will already have been handled by `tokenRequiresScopes()` - Adds migration to convert old scoped access tokens to the new set of scopes - Updates the user interface for scope selection ### User interface example <img width="903" alt="Screen Shot 2023-05-31 at 1 56 55 PM" src="https://github.com/go-gitea/gitea/assets/23248839/654766ec-2143-4f59-9037-3b51600e32f3"> <img width="917" alt="Screen Shot 2023-05-31 at 1 56 43 PM" src="https://github.com/go-gitea/gitea/assets/23248839/1ad64081-012c-4a73-b393-66b30352654c"> ## tokenRequiresScopes Design Decision - `tokenRequiresScopes()` was added to more reliably cover api routes. For an incoming request, this function uses the given scope category (say `AccessTokenScopeCategoryOrganization`) and the HTTP method (say `DELETE`) and verifies that any scoped tokens in use include `delete:organization`. - `reqToken()` is used to enforce auth for individual routes that require it. If a scoped token is not present for a request, `tokenRequiresScopes()` will not return an error ## TODO - [x] Alphabetize scope categories - [x] Change 'public repos only' to a radio button (private vs public). Also expand this to organizations - [X] Disable token creation if no scopes selected. Alternatively, show warning - [x] `reqToken()` is missing from many `POST/DELETE` routes in the api. `tokenRequiresScopes()` only checks that a given token has the correct scope, `reqToken()` must be used to check that a token (or some other auth) is present. - _This should be addressed in this PR_ - [x] The migration should be reviewed very carefully in order to minimize access changes to existing user tokens. - _This should be addressed in this PR_ - [x] Link to api to swagger documentation, clarify what read/write/delete levels correspond to - [x] Review cases where more than one scope is needed as this directly deviates from the api definition. - _This should be addressed in this PR_ - For example: ```go m.Group("/users/{username}/orgs", func() { m.Get("", reqToken(), org.ListUserOrgs) m.Get("/{org}/permissions", reqToken(), org.GetUserOrgsPermissions) }, tokenRequiresScopes(auth_model.AccessTokenScopeCategoryUser, auth_model.AccessTokenScopeCategoryOrganization), context_service.UserAssignmentAPI()) ``` ## Future improvements - [ ] Add required scopes to swagger documentation - [ ] Redesign `reqToken()` to be opt-out rather than opt-in - [ ] Subdivide scopes like `repository` - [ ] Once a token is created, if it has no scopes, we should display text instead of an empty bullet point - [ ] If the 'public repos only' option is selected, should read categories be selected by default Closes #24501 Closes #24799 Co-authored-by: Jonathan Tran <jon@allspice.io> Co-authored-by: Kyle D <kdumontnu@gmail.com> Co-authored-by: silverwind <me@silverwind.io>	2023-06-04 20:57:16 +02:00
Tyrone Yeh	b6d8d695da	Add up and down arrows to selected lookup repositories (#24727) ... Use up and down arrow key to select repositories  --------- Co-authored-by: silverwind <me@silverwind.io>	2023-06-02 18:39:07 +00:00
Kyle D	72eedfb915	Show file tree by default (#25052) ... Feel free to close this if there isn't interest. The tree view looks amazing, and all of our users are really enjoying it (major kudos to developers!), but only IF I tell them it exists! Essentially, the file tree view as it is effectively undiscoverable. This PR changes the default state for the tree view to open, which should significantly help with discoverability. An alternative could be to reserve more horizontal space, as a typical accordion panel would look (eg. VS Code), eg. 	2023-06-02 23:39:01 +08:00
wxiaoguang	e3897148f9	Minor UI improvements: logo alignment, auth map editor, auth name display (#25043) ... Some minor UI improvements together (then no need to review 3 small PRs) # The Map for auth sources Close #24826 Now the LDAP and OAuth2 both have multiple line editor for the map (and it can be resized by the handler) <details>   </details> # The account link display Before, the UI is misaligned This PR fixes the misalignment, remove "float right", and show the auth source name and auth type (in the tooltip). And the "active" color is changed from dark red to primary color. Before: <details>  </details> After: <details>  </details> # The UI logo alignment Changed file: `css/base.css`. Before, there were some "fine tunes", these "fine tunes" only causes misalignment. <details>  </details> After this PR: <details>   </details>	2023-06-02 18:02:20 +08:00
silverwind	c5ede35124	Add button on diff header to copy file name, misc diff header tweaks (#24986) ... 1. Add this button: <img width="232" alt="Screenshot 2023-05-29 at 15 21 47" src="https://github.com/go-gitea/gitea/assets/115237/5eaf6bd1-83db-4ffc-9503-eda0c59807d2"> <img width="297" alt="Screenshot 2023-05-29 at 15 20 22" src="https://github.com/go-gitea/gitea/assets/115237/708a344f-f6d7-4229-bfda-76e1571b42c8"> 2. Correct `button-link` styles to not have a background hover effect. 3. Tweak `.ui.container` padding to be the same for fluid and non-fluid. 4. Misc enhancements to diff header: Before: <img width="984" alt="Screenshot 2023-05-29 at 15 38 53" src="https://github.com/go-gitea/gitea/assets/115237/c7926f6a-bd0a-4b05-97ad-c91fc25c62d5"> After: <img width="987" alt="Screenshot 2023-05-29 at 15 43 10" src="https://github.com/go-gitea/gitea/assets/115237/0149f545-45f8-42cf-b443-e1c76bd5cdeb">	2023-06-01 10:47:28 +00:00
wxiaoguang	48bfea6705	Fix incorrect issuel filter menu style (#25018) ... Before: <details>  </details> After: <details>   </details>	2023-05-31 12:44:28 +02:00
silverwind	50bd7d0b24	Remove the service worker (#25010) ... It's been disabled by default since 1.17 (https://github.com/go-gitea/gitea/pull/18914), and it never really delivered any benefit except being another cache layer that has its own unsolved invalidation issues. HTTP cache works, we don't need two cache layers at the browser for assets. ## ⚠️ BREAKING You can remove the config `[ui].USE_SERVICE_WORKER` from your `app.ini` now.	2023-05-31 02:07:04 +00:00