3 commits

Author	SHA1	Message	Date
WGH	98fd085039	Fix lax comparison in validation tests (#7815) ... If you add t.Logf("%+v %+v", actual, testCase.expectedErrors) to the test code, you'll notice that only Errors' Messages are being compared: --- PASS: Test_ValidURLValidation/Invalid_schema (0.00s) binding_test.go:43: [Url] [Url] FieldNames and Classification are ignored in comparison. Moreover, an Errors slice with a single Error with empty message is formatted as '[]' (the same as empty slice), which is also error-prone. I discovered this when working on #7791 when one test which was not supposed to pass did pass. https://play.golang.org/p/qC4wVLrm4NG This commit changes the test to do the comparison properly.	2019-08-12 10:17:25 +08:00
kolaente	f9ec2f89f2	Add golangci (#6418)	2019-06-12 15:41:28 -04:00
Lauris BH	f42ec6120e	Better URL validation (#1507) ... * Add correct git branch name validation * Change git refname validation error constant name * Implement URL validation based on GoLang url.Parse method * Backward compatibility with older Go compiler * Add git reference name validation unit tests * Remove unused variable in unit test * Implement URL validation based on GoLang url.Parse method * Backward compatibility with older Go compiler * Add url validation unit tests	2017-04-19 11:02:20 +08:00