magic_rb/forgejo
Template
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo synced 2024-11-28 04:36:11 +01:00
Code Issues Packages Projects Releases Wiki Activity

Update milestone counters when issue is deleted (#21459) (#21586)

Browse source 
Backports #21459 

When actions besides "delete" are performed on issues, the milestone
counter is updated. However, since deleting issues goes through a
different code path, the associated milestone's count wasn't being
updated, resulting in inaccurate counts until another issue in the same
milestone had a non-delete action performed on it.

I verified this change fixes the inaccurate counts using a local docker
build.

Co-authored-by: 6543 <6543@obermui.de>
This commit is contained in:
Ashley Nelson 2022-10-26 02:44:05 -05:00 committed by GitHub
parent 2ccf940464
commit e504410708
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
services/issue/issue.go
View file

@ -224,6 +224,11 @@ func deleteIssue(issue *issues_model.Issue) error {
return err
}
if err := issues_model.UpdateMilestoneCounters(ctx, issue.MilestoneID); err != nil {
return fmt.Errorf("error updating counters for milestone id %d: %w",
issue.MilestoneID, err)
}
if err := models.DeleteIssueActions(ctx, issue.RepoID, issue.ID); err != nil {
return err
}