magic_rb/forgejo
Template
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo synced 2024-11-22 09:54:24 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove jQuery class from the code range selection (#30173)

Browse source 
- Switched from jQuery class functions to plain JavaScript `classList`
- Tested the code range selection functionality and it works as before

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
(cherry picked from commit 911993429f3bec0ff4440c012b2a8f295673f961)
This commit is contained in:
Yarden Shoham 2024-03-29 20:08:54 +03:00 committed by Gergely Nagy
parent e08f05b069
commit 811c14b8ba
No known key found for this signature in database
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
web_src/js/features/repo-code.js
View file

@ -25,7 +25,9 @@ function getLineEls() {
} }
function selectRange($linesEls, $selectionEndEl, $selectionStartEls) { function selectRange($linesEls, $selectionEndEl, $selectionStartEls) {
$linesEls.closest('tr').removeClass('active'); for (const el of $linesEls) {
el.closest('tr').classList.remove('active');
}
// add hashchange to permalink // add hashchange to permalink
const refInNewIssue = document.querySelector('a.ref-in-new-issue'); const refInNewIssue = document.querySelector('a.ref-in-new-issue');
@ -72,7 +74,7 @@ function selectRange($linesEls, $selectionEndEl, $selectionStartEls) {
classes.push(`[rel=L${i}]`); classes.push(`[rel=L${i}]`);
} }
$linesEls.filter(classes.join(',')).each(function () { $linesEls.filter(classes.join(',')).each(function () {
$(this).closest('tr').addClass('active'); this.closest('tr').classList.add('active');
}); });
changeHash(`#L${a}-L${b}`); changeHash(`#L${a}-L${b}`);
@ -82,7 +84,7 @@ function selectRange($linesEls, $selectionEndEl, $selectionStartEls) {
return; return;
} }
} }
$selectionEndEl.closest('tr').addClass('active'); $selectionEndEl[0].closest('tr').classList.add('active');
changeHash(`#${$selectionEndEl[0].getAttribute('rel')}`); changeHash(`#${$selectionEndEl[0].getAttribute('rel')}`);
updateIssueHref($selectionEndEl[0].getAttribute('rel')); updateIssueHref($selectionEndEl[0].getAttribute('rel'));