Add tests for the previous changes

This adds a number of tests to exercise the changed functionality and
bugfixes introduced by the two previous commits.

Signed-off-by: Gergely Nagy <forgejo@gergo.csillger.hu>

tests/integration/pull_create_test.go

@@ -1,4 +1,5 @@
 // Copyright 2017 The Gitea Authors. All rights reserved.
+// Copyright 2024 The Forgejo Authors c/o Codeberg e.V.. All rights reserved.
 // SPDX-License-Identifier: MIT
 
 package integration
@@ -12,7 +13,11 @@ import (
 	"strings"
 	"testing"
 
+	"code.gitea.io/gitea/models/db"
+	repo_model "code.gitea.io/gitea/models/repo"
+	unit_model "code.gitea.io/gitea/models/unit"
 	"code.gitea.io/gitea/modules/test"
+	repo_service "code.gitea.io/gitea/services/repository"
 	"code.gitea.io/gitea/tests"
 
 	"github.com/stretchr/testify/assert"
@@ -162,3 +167,135 @@ func TestPullBranchDelete(t *testing.T) {
 		session.MakeRequest(t, req, http.StatusOK)
 	})
 }
+
+func TestRecentlyPushed(t *testing.T) {
+	onGiteaRun(t, func(t *testing.T, u *url.URL) {
+		session := loginUser(t, "user1")
+		testRepoFork(t, session, "user2", "repo1", "user1", "repo1")
+		testCreateBranch(t, session, "user1", "repo1", "branch/master", "recent-push", http.StatusSeeOther)
+		testEditFile(t, session, "user1", "repo1", "recent-push", "README.md", "Hello recently!\n")
+
+		repo, err := repo_model.GetRepositoryByOwnerAndName(db.DefaultContext, "user1", "repo1")
+		assert.NoError(t, err)
+
+		enablePRs := func(t *testing.T, repo *repo_model.Repository) {
+			t.Helper()
+
+			err := repo_service.UpdateRepositoryUnits(db.DefaultContext, repo,
+				[]repo_model.RepoUnit{{
+					RepoID: repo.ID,
+					Type:   unit_model.TypePullRequests,
+				}},
+				nil)
+			assert.NoError(t, err)
+		}
+
+		disablePRs := func(t *testing.T, repo *repo_model.Repository) {
+			t.Helper()
+
+			err := repo_service.UpdateRepositoryUnits(db.DefaultContext, repo, nil,
+				[]unit_model.Type{unit_model.TypePullRequests})
+			assert.NoError(t, err)
+		}
+
+		// Test that there's a recently pushed branches banner, and it contains
+		// a link to the branch.
+		t.Run("recently-pushed-banner", func(t *testing.T) {
+			defer tests.PrintCurrentTest(t)()
+
+			testBanner := func(t *testing.T) {
+				t.Helper()
+
+				req := NewRequest(t, "GET", "/user1/repo1")
+				resp := session.MakeRequest(t, req, http.StatusOK)
+				htmlDoc := NewHTMLParser(t, resp.Body)
+
+				message := strings.TrimSpace(htmlDoc.Find(".ui.message").Text())
+				link, _ := htmlDoc.Find(".ui.message a").Attr("href")
+				expectedMessage := "You pushed on branch recent-push"
+
+				assert.Contains(t, message, expectedMessage)
+				assert.Equal(t, "/user1/repo1/src/branch/recent-push", link)
+			}
+
+			testBanner(t)
+
+			// Test that it is still there if the fork has PRs disabled
+			t.Run("with-fork-prs-disabled", func(t *testing.T) {
+				defer tests.PrintCurrentTest(t)()
+				defer func() {
+					enablePRs(t, repo)
+				}()
+
+				disablePRs(t, repo)
+				testBanner(t)
+			})
+
+			// Test that the banner is not present if the base repo has PRs
+			// disabled
+			t.Run("with-base-prs-disabled", func(t *testing.T) {
+				defer tests.PrintCurrentTest(t)()
+
+				baseRepo, err := repo_model.GetRepositoryByOwnerAndName(db.DefaultContext, "user2", "repo1")
+				assert.NoError(t, err)
+
+				defer func() {
+					enablePRs(t, baseRepo)
+				}()
+
+				disablePRs(t, baseRepo)
+
+				req := NewRequest(t, "GET", "/user1/repo1")
+				resp := session.MakeRequest(t, req, http.StatusOK)
+				htmlDoc := NewHTMLParser(t, resp.Body)
+
+				messageCount := htmlDoc.Find(".ui.message").Length()
+
+				assert.Equal(t, 0, messageCount)
+			})
+		})
+
+		// Visiting the base repo, while the fork has recently pushed branch,
+		// works.
+		t.Run("visiting the base repo", func(t *testing.T) {
+			defer tests.PrintCurrentTest(t)()
+
+			session.MakeRequest(t, NewRequest(t, "GET", "/user2/repo1"), http.StatusOK)
+		})
+
+		// Test scenarios where the fork has PRs disabled
+		t.Run("local prs", func(t *testing.T) {
+			defer tests.PrintCurrentTest(t)()
+			defer func() {
+				enablePRs(t, repo)
+			}()
+
+			disablePRs(t, repo)
+
+			t.Run("branch view doesn't offer creating PRs", func(t *testing.T) {
+				defer tests.PrintCurrentTest(t)()
+
+				req := NewRequest(t, "GET", "/user1/repo1/branches")
+				resp := session.MakeRequest(t, req, http.StatusOK)
+				htmlDoc := NewHTMLParser(t, resp.Body)
+
+				newPRButtonCount := htmlDoc.Find("a[href='/user1/repo1/compare/master...recent-push']").Length()
+				assert.Equal(t, 0, newPRButtonCount)
+			})
+
+			t.Run("compare doesn't offer local branches", func(t *testing.T) {
+				defer tests.PrintCurrentTest(t)()
+
+				req := NewRequest(t, "GET", "/user2/repo1/compare/master...user1/repo1:recent-push")
+				resp := session.MakeRequest(t, req, http.StatusOK)
+				htmlDoc := NewHTMLParser(t, resp.Body)
+				branches := htmlDoc.Find(".choose.branch .menu .reference-list-menu.base-branch-list .item, .choose.branch .menu .reference-list-menu.base-tag-list .item")
+
+				expectedPrefix := "user2:"
+				for i := 0; i < len(branches.Nodes); i++ {
+					assert.True(t, strings.HasPrefix(branches.Eq(i).Text(), expectedPrefix))
+				}
+			})
+		})
+	})
+}