magic_rb/forgejo
Template
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo synced 2024-11-22 01:44:24 +01:00
Code Issues Packages Projects Releases Wiki Activity

[CHORE] Add extra testing

Browse source 
- Do more property testing for null values.
- Add test for `AbsoluteLong`.
This commit is contained in:
Gusted 2024-11-05 21:20:55 +01:00
parent fddde93759
commit 2f8e7a2c67
No known key found for this signature in database
GPG key ID: FD821B732837125F
2 changed files with 16 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
modules/templates/util_date.go
View file

@ -27,7 +27,7 @@ func (du *DateUtils) AbsoluteShort(time any) template.HTML {
// AbsoluteLong renders in "January 01, 2006" format // AbsoluteLong renders in "January 01, 2006" format
func (du *DateUtils) AbsoluteLong(time any) template.HTML { func (du *DateUtils) AbsoluteLong(time any) template.HTML {
return timeutil.DateTime("short", time) return timeutil.DateTime("long", time)
} }
// FullTime renders in "Jan 01, 2006 20:33:44" format // FullTime renders in "Jan 01, 2006 20:33:44" format

20
modules/templates/util_date_test.go
View file

@ -4,6 +4,7 @@
package templates package templates
import ( import (
"html/template"
"testing" "testing"
"time" "time"
@ -12,10 +13,12 @@ import (
"code.gitea.io/gitea/modules/timeutil" "code.gitea.io/gitea/modules/timeutil"
"github.com/stretchr/testify/assert" "github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
) )
func TestDateTime(t *testing.T) { func TestDateTime(t *testing.T) {
testTz, _ := time.LoadLocation("America/New_York") testTz, err := time.LoadLocation("America/New_York")
require.NoError(t, err)
defer test.MockVariableValue(&setting.DefaultUILocation, testTz)() defer test.MockVariableValue(&setting.DefaultUILocation, testTz)()
defer test.MockVariableValue(&setting.IsInTesting, false)() defer test.MockVariableValue(&setting.IsInTesting, false)()
@ -26,10 +29,11 @@ func TestDateTime(t *testing.T) {
refTime, _ := time.Parse(time.RFC3339, refTimeStr) refTime, _ := time.Parse(time.RFC3339, refTimeStr)
refTimeStamp := timeutil.TimeStamp(refTime.Unix()) refTimeStamp := timeutil.TimeStamp(refTime.Unix())
assert.EqualValues(t, "-", du.AbsoluteShort(nil)) for _, val := range []any{nil, 0, time.Time{}, timeutil.TimeStamp(0)} {
assert.EqualValues(t, "-", du.AbsoluteShort(0)) for _, fun := range []func(val any) template.HTML{du.AbsoluteLong, du.AbsoluteShort, du.FullTime} {
assert.EqualValues(t, "-", du.AbsoluteShort(time.Time{})) assert.EqualValues(t, "-", fun(val))
assert.EqualValues(t, "-", du.AbsoluteShort(timeutil.TimeStamp(0))) }
}
actual := dateTimeLegacy("short", "invalid") actual := dateTimeLegacy("short", "invalid")
assert.EqualValues(t, `-`, actual) assert.EqualValues(t, `-`, actual)
@ -40,12 +44,18 @@ func TestDateTime(t *testing.T) {
actual = du.AbsoluteShort(refTime) actual = du.AbsoluteShort(refTime)
assert.EqualValues(t, `<absolute-date weekday="" year="numeric" month="short" day="numeric" date="2018-01-01T00:00:00Z">2018-01-01</absolute-date>`, actual) assert.EqualValues(t, `<absolute-date weekday="" year="numeric" month="short" day="numeric" date="2018-01-01T00:00:00Z">2018-01-01</absolute-date>`, actual)
actual = du.AbsoluteLong(refTime)
assert.EqualValues(t, `<absolute-date weekday="" year="numeric" month="long" day="numeric" date="2018-01-01T00:00:00Z">2018-01-01</absolute-date>`, actual)
actual = dateTimeLegacy("short", refDateStr) actual = dateTimeLegacy("short", refDateStr)
assert.EqualValues(t, `<absolute-date weekday="" year="numeric" month="short" day="numeric" date="2018-01-01T00:00:00-05:00">2018-01-01</absolute-date>`, actual) assert.EqualValues(t, `<absolute-date weekday="" year="numeric" month="short" day="numeric" date="2018-01-01T00:00:00-05:00">2018-01-01</absolute-date>`, actual)
actual = du.AbsoluteShort(refTimeStamp) actual = du.AbsoluteShort(refTimeStamp)
assert.EqualValues(t, `<absolute-date weekday="" year="numeric" month="short" day="numeric" date="2017-12-31T19:00:00-05:00">2017-12-31</absolute-date>`, actual) assert.EqualValues(t, `<absolute-date weekday="" year="numeric" month="short" day="numeric" date="2017-12-31T19:00:00-05:00">2017-12-31</absolute-date>`, actual)
actual = du.AbsoluteLong(refTimeStamp)
assert.EqualValues(t, `<absolute-date weekday="" year="numeric" month="long" day="numeric" date="2017-12-31T19:00:00-05:00">2017-12-31</absolute-date>`, actual)
actual = du.FullTime(refTimeStamp) actual = du.FullTime(refTimeStamp)
assert.EqualValues(t, `<relative-time weekday="" year="numeric" format="datetime" month="short" day="numeric" hour="numeric" minute="numeric" second="numeric" data-tooltip-content data-tooltip-interactive="true" datetime="2017-12-31T19:00:00-05:00">2017-12-31 19:00:00 -05:00</relative-time>`, actual) assert.EqualValues(t, `<relative-time weekday="" year="numeric" format="datetime" month="short" day="numeric" hour="numeric" minute="numeric" second="numeric" data-tooltip-content data-tooltip-interactive="true" datetime="2017-12-31T19:00:00-05:00">2017-12-31 19:00:00 -05:00</relative-time>`, actual)
} }