magic_rb/forgejo
Template
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo synced 2024-11-28 20:56:11 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request '[FEAT] Mark database errors in tests as failure' (#2972) from gusted/forgejo-log-db into forgejo

Browse source 
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2972
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
This commit is contained in:
Earl Warren 2024-04-02 14:47:32 +00:00
parent 3aad608649 2dabd202ce
commit 2a006e850e
2 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
models/db/engine.go
View file

@ -155,8 +155,14 @@ func InitEngine(ctx context.Context) error {
Logger: log.GetLogger("xorm"), Logger: log.GetLogger("xorm"),
}) })
} }
errorLogger := log.GetLogger("xorm")
if setting.IsInTesting {
errorLogger = log.GetLogger(log.DEFAULT)
}
xormEngine.AddHook(&ErrorQueryHook{ xormEngine.AddHook(&ErrorQueryHook{
Logger: log.GetLogger("xorm"), Logger: errorLogger,
}) })
SetDefaultEngine(ctx, xormEngine) SetDefaultEngine(ctx, xormEngine)

3
modules/testlogger/testlogger.go
View file

@ -357,6 +357,9 @@ var ignoredErrorMessage = []string{
// TestRenameInvalidUsername // TestRenameInvalidUsername
`TrString() [E] Missing translation "form.Name"`, `TrString() [E] Missing translation "form.Name"`,
// TestDatabaseCollation
`[E] [Error SQL Query] INSERT INTO test_collation_tbl (txt) VALUES ('main') []`,
} }
func (w *testLoggerWriterCloser) recordError(msg string) { func (w *testLoggerWriterCloser) recordError(msg string) {