From 0c56ae07ad22b7c75cb49f664907a73e7c378e06 Mon Sep 17 00:00:00 2001 From: Nirmal Kumar R Date: Wed, 20 Nov 2024 20:52:10 +0530 Subject: [PATCH] Use expect for editor in e2e + Title case comment --- tests/e2e/markdown-editor.test.e2e.ts | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/tests/e2e/markdown-editor.test.e2e.ts b/tests/e2e/markdown-editor.test.e2e.ts index 85a938cdf4..e88371a34a 100644 --- a/tests/e2e/markdown-editor.test.e2e.ts +++ b/tests/e2e/markdown-editor.test.e2e.ts @@ -14,28 +14,29 @@ test.beforeAll(async ({browser}, workerInfo) => { test('Markdown image preview behaviour', async ({browser}, workerInfo) => { const context = await load_logged_in_context(browser, workerInfo, 'user2'); - // editing the root README.md file for image preview + // Editing the root README.md file for image preview const editPath = '/user2/repo1/src/branch/master/README.md'; const page = await context.newPage(); const response = await page.goto(editPath, {waitUntil: 'domcontentloaded'}); expect(response?.status()).toBe(200); - // click 'Edit file' tab + // Click 'Edit file' tab await page.locator('[data-tooltip-content="Edit file"]').click(); - // this yields the monaco editor + // This yields the monaco editor const editor = page.getByRole('presentation').nth(0); + expect(editor).toBeVisible(); await editor.click(); - // clear all the content + // Clear all the content await page.keyboard.press('ControlOrMeta+KeyA'); - // add the image + // Add the image await page.keyboard.type('![Logo of Forgejo](./assets/logo.svg "Logo of Forgejo")'); - // click 'Preview' tab + // Click 'Preview' tab await page.locator('a[data-tab="preview"]').click(); - // check for the image preview via the expected attribute + // Check for the image preview via the expected attribute const preview = page.locator('div[data-tab="preview"] p[dir="auto"] a'); await expect(preview).toHaveAttribute('href', 'http://localhost:3003/user2/repo1/media/branch/master/assets/logo.svg'); });